On Nov. 29, 2014, 8:29 p.m., Steve Reinhardt wrote:
src/mem/packet.hh, line 822
http://reviews.gem5.org/r/2492/diff/1/?file=42516#file42516line822
Would it make sense to have an internal 'const' flag that we assert is
cleared when calling the non-const getPtr() accessors? That
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2492/#review5570
---
Ship it!
src/mem/packet.hh
http://reviews.gem5.org/r/2492/#comment4993
On Nov. 18, 2014, 3:36 p.m., Nilay Vaish wrote:
src/mem/port_proxy.cc, line 80
http://reviews.gem5.org/r/2492/diff/1/?file=42518#file42518line80
Do we need this scope resolution?
We do. It took me the better part of a day to track it down even...
- Andreas
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2492/#review5475
---
Ship it!
Ship It!
- Nilay Vaish
On Nov. 17, 2014, 6:14 a.m., Andreas
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2492/
---
Review request for Default.
Repository: gem5
Description
---
Changeset