Re: [gem5-dev] Review Request 2492: mem: Use const pointers for port proxy write functions

2014-11-30 Thread Andreas Hansson via gem5-dev
On Nov. 29, 2014, 8:29 p.m., Steve Reinhardt wrote: src/mem/packet.hh, line 822 http://reviews.gem5.org/r/2492/diff/1/?file=42516#file42516line822 Would it make sense to have an internal 'const' flag that we assert is cleared when calling the non-const getPtr() accessors? That

Re: [gem5-dev] Review Request 2492: mem: Use const pointers for port proxy write functions

2014-11-29 Thread Steve Reinhardt via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2492/#review5570 --- Ship it! src/mem/packet.hh http://reviews.gem5.org/r/2492/#comment4993

Re: [gem5-dev] Review Request 2492: mem: Use const pointers for port proxy write functions

2014-11-18 Thread Andreas Hansson via gem5-dev
On Nov. 18, 2014, 3:36 p.m., Nilay Vaish wrote: src/mem/port_proxy.cc, line 80 http://reviews.gem5.org/r/2492/diff/1/?file=42518#file42518line80 Do we need this scope resolution? We do. It took me the better part of a day to track it down even... - Andreas

Re: [gem5-dev] Review Request 2492: mem: Use const pointers for port proxy write functions

2014-11-18 Thread Nilay Vaish via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2492/#review5475 --- Ship it! Ship It! - Nilay Vaish On Nov. 17, 2014, 6:14 a.m., Andreas

[gem5-dev] Review Request 2492: mem: Use const pointers for port proxy write functions

2014-11-16 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2492/ --- Review request for Default. Repository: gem5 Description --- Changeset