Re: [gem5-dev] Review Request 2519: x86: i8042: Give the keyboard controller a little TLC.

2014-12-21 Thread Ali Saidi via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2519/#review5700 --- Ship it! seems fine to me, although I can't say I know the code well -

Re: [gem5-dev] Review Request 2519: x86: i8042: Give the keyboard controller a little TLC.

2014-12-16 Thread Gabe Black via gem5-dev
On Nov. 25, 2014, 10:31 p.m., Nilay Vaish wrote: What's TLC and CL? tender loving care and change list - Gabe --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2519/#review5547

Re: [gem5-dev] Review Request 2519: x86: i8042: Give the keyboard controller a little TLC.

2014-12-16 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2519/ --- (Updated Dec. 17, 2014, 7:35 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2519: x86: i8042: Give the keyboard controller a little TLC.

2014-12-16 Thread Gabe Black via gem5-dev
On Nov. 25, 2014, 10:23 p.m., Nilay Vaish wrote: src/dev/x86/i8042.cc, line 418 http://reviews.gem5.org/r/2519/diff/1/?file=42718#file42718line418 We don't need this nack(). I changed the panic to a warn and left the nack in. On Nov. 25, 2014, 10:23 p.m., Nilay Vaish wrote:

Re: [gem5-dev] Review Request 2519: x86: i8042: Give the keyboard controller a little TLC.

2014-11-25 Thread Nilay Vaish via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2519/#review5547 --- What's TLC and CL? - Nilay Vaish On Nov. 22, 2014, 1:32 p.m., Gabe

[gem5-dev] Review Request 2519: x86: i8042: Give the keyboard controller a little TLC.

2014-11-22 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2519/ --- Review request for Default. Repository: gem5 Description --- Changeset