On Dec. 4, 2014, 4:01 p.m., Steve Reinhardt wrote:
src/base/remote_gdb.hh, line 157
http://reviews.gem5.org/r/2538/diff/1/?file=42808#file42808line157
a comment here like '// size of cache in bytes' would be nice just to
be clear (and since that has changed)
Fixed.
- Gabe
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2538/#review5624
---
Ship it!
Looks good other than minor comment below
On Dec. 2, 2014, 5:47 p.m., Nilay Vaish wrote:
src/base/remote_gdb.hh, line 143
http://reviews.gem5.org/r/2538/diff/1/?file=42808#file42808line143
Should this not be divCeil() * sizeof(uint64_t)?
No. The size member reflects the size you asked for, not the size you got
which is
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2538/#review5604
---
Ship it!
Seems fine other than the one comment I have made below.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2538/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
