Re: [gem5-dev] Review Request 2547: x86: Clean up style in process.cc.

2014-12-03 Thread Gabe Black via gem5-dev
On Dec. 2, 2014, 6:26 a.m., Steve Reinhardt wrote: It would be nice to actually test this code just to be sure nothing slipped through, but style-wise it does look like an improvement. I might spend some personal time (vs. work time) at some point seeing if I can figure out what the

[gem5-dev] Review Request 2547: x86: Clean up style in process.cc.

2014-12-01 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2547/ --- Review request for Default. Repository: gem5 Description --- changesets:

Re: [gem5-dev] Review Request 2547: x86: Clean up style in process.cc.

2014-12-01 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2547/#review5593 --- I wasn't able to test this because I couldn't get hello world to run

Re: [gem5-dev] Review Request 2547: x86: Clean up style in process.cc.

2014-12-01 Thread Steve Reinhardt via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2547/#review5602 --- Ship it! It would be nice to actually test this code just to be sure