---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2611/#review5866
---
Ship it!
Looks fine to me. In the abstract I agree with Nilay that DMA
On Jan. 30, 2015, 9:47 p.m., Nilay Vaish wrote:
src/cpu/testers/memtest/MemTest.py, line 55
http://reviews.gem5.org/r/2611/diff/1/?file=43345#file43345line55
Are you sure this should be dropped? I think the coherence protocols
that provide a dma controller need this for testing.
On Jan. 30, 2015, 9:47 p.m., Nilay Vaish wrote:
src/cpu/testers/memtest/MemTest.py, line 55
http://reviews.gem5.org/r/2611/diff/1/?file=43345#file43345line55
Are you sure this should be dropped? I think the coherence protocols
that provide a dma controller need this for testing.
Hi Nilay,
It did not do anything sensible. The MemTest fundamentally only tests
false sharing since it has no notion of a memory consistency model. Thus,
the “non DMA” transactions access a specific byte in the cache line.
The DMA transactions were multi-byte transactions, that had no tests
On Sun, 1 Feb 2015, Andreas Hansson wrote:
Hi Nilay,
I think the “DMA” bit of this tester was broken and rather pointless. In
essence the MemTest is only fit for testing false sharing, and that is
what it now does. I do not quite understand what a DMA has to do with any
of that.
Separately we
On Jan. 30, 2015, 9:47 p.m., Nilay Vaish wrote:
src/cpu/testers/memtest/MemTest.py, line 55
http://reviews.gem5.org/r/2611/diff/1/?file=43345#file43345line55
Are you sure this should be dropped? I think the coherence protocols
that provide a dma controller need this for testing.
Hi Nilay,
I think the “DMA” bit of this tester was broken and rather pointless. In
essence the MemTest is only fit for testing false sharing, and that is
what it now does. I do not quite understand what a DMA has to do with any
of that.
Separately we will now have a tester that actually tests
On Sat, 31 Jan 2015, Andreas Hansson wrote:
On Jan. 30, 2015, 9:47 p.m., Nilay Vaish wrote:
src/cpu/testers/memtest/MemTest.py, line 55
http://reviews.gem5.org/r/2611/diff/1/?file=43345#file43345line55
Are you sure this should be dropped? I think the coherence protocols that
provide
On Jan. 30, 2015, 9:47 p.m., Nilay Vaish wrote:
src/cpu/testers/memtest/MemTest.py, line 55
http://reviews.gem5.org/r/2611/diff/1/?file=43345#file43345line55
Are you sure this should be dropped? I think the coherence protocols
that provide a dma controller need this for testing.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2611/#review5809
---
src/cpu/testers/memtest/MemTest.py
10 matches
Mail list logo
