Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

2015-09-14 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2965/#review7175 --- Any last comments? I plan to ship this before the EoD today. - Tony

Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

2015-09-04 Thread Jason Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2965/#review7117 --- Ship it! I had been putting off this review since it touched so many

Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

2015-09-03 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2965/#review7107 --- Are they comments on this? We'd like to ship this soon. - Tony

Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

2015-09-03 Thread Gutierrez, Anthony
We can do either hg mv, or hg rm and hg add. What is preferred? From: Nilay Vaish [mailto:nore...@gem5.org] On Behalf Of Nilay Vaish Sent: Thursday, September 03, 2015 1:51 PM To: Nilay Vaish; Gutierrez, Anthony; Hashe, David; Default Subject: Re: Review Request 2965: rename System.{hh,cc} to

Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

2015-09-03 Thread Tony Gutierrez
> On Sept. 3, 2015, 11:36 a.m., Tony Gutierrez wrote: > > Are they comments on this? We'd like to ship this soon. > > Nilay Vaish wrote: > Has hg mv been used to move those two files? We can do hg mv or hg rm/hg add. What is preferred? - Tony

Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

2015-09-03 Thread Nilay Vaish
On Thu, 3 Sep 2015, Tony Gutierrez wrote: On Sept. 3, 2015, 11:36 a.m., Tony Gutierrez wrote: Are they comments on this? We'd like to ship this soon. Nilay Vaish wrote: Has hg mv been used to move those two files? We can do hg mv or hg rm/hg add. What is preferred? hg rm/hg add

Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

2015-09-03 Thread Nilay Vaish
> On Sept. 3, 2015, 6:36 p.m., Tony Gutierrez wrote: > > Are they comments on this? We'd like to ship this soon. Has hg mv been used to move those two files? - Nilay --- This is an automatically generated e-mail. To reply, visit:

[gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

2015-07-13 Thread David Hashe
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2965/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

2015-07-13 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2965/#review6758 --- I am as such fine with the patch. I myself have faced similar problem

Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

2015-07-13 Thread David Hashe
On July 13, 2015, 8:10 p.m., Nilay Vaish wrote: I am as such fine with the patch. I myself have faced similar problem with the naming of the header file. Can you expand on your eventual aim? I am trying to understand the need for spreading the ruby system pointer around.