Re: [gem5-dev] Review Request 3083: ruby: slicc: remove nextLineHack from Type.py

2015-09-04 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3083/#review7119 --- Ship it! Ship It! - Brad Beckmann On Sept. 2, 2015, 12:52 a.m.,

Re: [gem5-dev] Review Request 3083: ruby: slicc: remove nextLineHack from Type.py

2015-09-04 Thread Brad Beckmann
> On Sept. 2, 2015, 7:41 p.m., Jason Lowe-Power wrote: > > Do you know what this was used for? I've never encountered this, but it > > probably had a good reason to be there at some point... > > Nilay Vaish wrote: > None of the current protocols use it. The line has seen not any changes

Re: [gem5-dev] Review Request 3083: ruby: slicc: remove nextLineHack from Type.py

2015-09-03 Thread Jason Power
> On Sept. 2, 2015, 7:41 p.m., Jason Power wrote: > > Do you know what this was used for? I've never encountered this, but it > > probably had a good reason to be there at some point... > > Nilay Vaish wrote: > None of the current protocols use it. The line has seen not any changes >

Re: [gem5-dev] Review Request 3083: ruby: slicc: remove nextLineHack from Type.py

2015-09-02 Thread Jason Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3083/#review7095 --- Do you know what this was used for? I've never encountered this, but it

Re: [gem5-dev] Review Request 3083: ruby: slicc: remove nextLineHack from Type.py

2015-09-02 Thread Nilay Vaish
> On Sept. 2, 2015, 7:41 p.m., Jason Power wrote: > > Do you know what this was used for? I've never encountered this, but it > > probably had a good reason to be there at some point... None of the current protocols use it. The line has seen not any changes since SLICC was first merged into

[gem5-dev] Review Request 3083: ruby: slicc: remove nextLineHack from Type.py

2015-09-01 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3083/ --- Review request for Default. Repository: gem5 Description --- Changeset