Re: [gem5-dev] Review Request 3090: cpu: Support virtual addr in elastic traces

2015-12-04 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3090/#review7696 --- Ship it! Ship It! - Nilay Vaish On Dec. 3, 2015, 1:31 a.m., Curtis

Re: [gem5-dev] Review Request 3090: cpu: Support virtual addr in elastic traces

2015-12-03 Thread Nilay Vaish
> On Dec. 1, 2015, 5:58 p.m., Nilay Vaish wrote: > > src/cpu/o3/probe/elastic_trace.hh, lines 357-359 > > > > > > Do we really need this? I would rather always trace the virtual > > address as well. I don't think there

Re: [gem5-dev] Review Request 3090: cpu: Support virtual addr in elastic traces

2015-12-02 Thread Radhika Jagtap
> On Dec. 1, 2015, 5:58 p.m., Nilay Vaish wrote: > > src/cpu/o3/probe/elastic_trace.hh, lines 357-359 > > > > > > Do we really need this? I would rather always trace the virtual > > address as well. I don't think there

Re: [gem5-dev] Review Request 3090: cpu: Support virtual addr in elastic traces

2015-12-02 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3090/ --- (Updated Dec. 3, 2015, 1:31 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3090: cpu: Support virtual addr in elastic traces

2015-12-01 Thread Andreas Sandberg
> On Dec. 1, 2015, 5:58 p.m., Nilay Vaish wrote: > > src/cpu/o3/probe/elastic_trace.hh, lines 357-359 > > > > > > Do we really need this? I would rather always trace the virtual > > address as well. I don't think there

Re: [gem5-dev] Review Request 3090: cpu: Support virtual addr in elastic traces

2015-12-01 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3090/#review7665 --- src/cpu/o3/probe/elastic_trace.hh (lines 357 - 359)

[gem5-dev] Review Request 3090: cpu: Support virtual addr in elastic traces

2015-09-03 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3090/ --- Review request for Default. Repository: gem5 Description --- This patch