Re: [gem5-dev] Review Request 3525: ext: Update DRAMPower

2016-06-30 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3525/#review8459 --- Ship it! Ship It! - Andreas Hansson On June 22, 2016, 7:52 p.m.,

Re: [gem5-dev] Review Request 3525: ext: Update DRAMPower

2016-06-30 Thread Matthias Jung
> On Juni 26, 2016, 9:59 nachm., Andreas Hansson wrote: > > I realise I am commenting on DRAMPower changes here, so feel free to ignore. > > > > There seems to be an awful lot of changes from unsigned to signed types, > > which feels rather unintuitive. Why not uint64_t if the value is truly

Re: [gem5-dev] Review Request 3525: ext: Update DRAMPower

2016-06-30 Thread Andreas Hansson
> On June 26, 2016, 9:59 p.m., Andreas Hansson wrote: > > I realise I am commenting on DRAMPower changes here, so feel free to ignore. > > > > There seems to be an awful lot of changes from unsigned to signed types, > > which feels rather unintuitive. Why not uint64_t if the value is truly >

Re: [gem5-dev] Review Request 3525: ext: Update DRAMPower

2016-06-26 Thread Matthias Jung
> On Juni 26, 2016, 9:59 nachm., Andreas Hansson wrote: > > I realise I am commenting on DRAMPower changes here, so feel free to ignore. > > > > There seems to be an awful lot of changes from unsigned to signed types, > > which feels rather unintuitive. Why not uint64_t if the value is truly

Re: [gem5-dev] Review Request 3525: ext: Update DRAMPower

2016-06-26 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3525/#review8438 --- I realise I am commenting on DRAMPower changes here, so feel free to

Re: [gem5-dev] Review Request 3525: ext: Update DRAMPower

2016-06-22 Thread Matthias Jung
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3525/ --- (Updated Juni 22, 2016, 7:52 nachm.) Review request for Default and Andreas

Re: [gem5-dev] Review Request 3525: ext: Update DRAMPower

2016-06-22 Thread Matthias Jung
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3525/ --- (Updated Juni 22, 2016, 7:47 nachm.) Review request for Default and Andreas