----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3778/#review9379 -----------------------------------------------------------
Ship it! Ship It! - Matthias Jung On Jan. 30, 2017, 2:37 nachm., Christian Menard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3778/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2017, 2:37 nachm.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > The CxxConfigManager schould create objects by traversing the object tree > starting from the root object. However, currently objects are created in > aplphabetical order, which only works if the root object alphabetically comes > before any system object (e.g. 'root' < 'system'. Otherwise (e.g. 'a_system' > < 'root'), object construction may fail. The reason for this behaviour is, > that the call to findObject() in the sorting code also constructs the object > if it is not yet existent. Then findTraversalOrder() calls findObject("root") > and subseqeuently calls findObject() on all the children, and so on. However, > the call to findTraversalOrder() is redundant, since all objects are already > created in alphabetical order. This patch simply removes the alphabetical > ordering, leading to the objects being created starting from 'root'. > > > Diffs > ----- > > src/sim/cxx_manager.cc c10c50cb8ac9 > > Diff: http://reviews.gem5.org/r/3778/diff/ > > > Testing > ------- > > > Thanks, > > Christian Menard > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
