Re: [gem5-dev] SPARC cls and statute of limitation on reviews

2017-11-21 Thread Gabe Black
Ok, sounds good. I was thinking that sort of thing would make sense, but didn't want to go that way unilaterally. Gabe On Tue, Nov 21, 2017 at 6:05 AM, Andreas Sandberg wrote: > Hi Gabe, > > I won't have time to review them anytime soon. Since only Jason has > offered

Re: [gem5-dev] SPARC cls and statute of limitation on reviews

2017-11-21 Thread Andreas Sandberg
Hi Gabe, I won't have time to review them anytime soon. Since only Jason has offered to review some of them, I'd suggest that we go for a more relaxed review policy for SPARC. I would be happy for you to self approve these changes since you are the SPARC maintainer and there are no other obvious

Re: [gem5-dev] SPARC cls and statute of limitation on reviews

2017-11-17 Thread Jason Lowe-Power
Hey Gabe, I'll *try* to find some time this weekend to skim them. I'll aim for giving at least +1, after which I'm fine with you taking responsibility for any bugs and pushing :). I'll also try to catch up on all of the gem5 things that have been flying past my inbox. We'll see how that goes,

[gem5-dev] SPARC cls and statute of limitation on reviews

2017-11-17 Thread Gabe Black
Hi folks. I have a series of CLs for the SPARC ISA ( https://gem5-review.googlesource.com/c/public/gem5/+/5421/2, etc.) which haven'b gotten reviews in a while. I realize there may not be anyone to jump in and review SPARC changes, and I even chose to tinker with SPARC since it's a relatively