Re: [gem5-dev] adding reviewers in gerrit?

2017-04-05 Thread Jason Lowe-Power
Original Message- > From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Jason > Lowe-Power > Sent: Saturday, March 25, 2017 11:38 AM > To: gem5 Developer List <gem5-dev@gem5.org> > Subject: Re: [gem5-dev] adding reviewers in gerrit? > > Hi Gabe, > &g

Re: [gem5-dev] adding reviewers in gerrit?

2017-04-04 Thread Paul Rosenfeld (prosenfeld)
, the reviewer field is still blank. Regards, Paul -Original Message- From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Jason Lowe-Power Sent: Saturday, March 25, 2017 11:38 AM To: gem5 Developer List <gem5-dev@gem5.org> Subject: Re: [gem5-dev] adding reviewers in gerrit? Hi Gabe

Re: [gem5-dev] adding reviewers in gerrit?

2017-03-25 Thread Jason Lowe-Power
Hi Gabe, Hmm... It works for me. It's possible that we don't have the permissions set up correctly to allow anyone to add reviewers. I just tested with a non-admin account and it doesn't work for that account either. I'll look into it. Cheers, Jason On Sat, Mar 25, 2017 at 5:32 AM Gabe Black

[gem5-dev] adding reviewers in gerrit?

2017-03-25 Thread Gabe Black
Hi folks. I've uploaded a few CLs to gerrit now, and I notice that I can't add reviewers since it claims everyone I try to add isn't a registered user. That's very odd, because I'm trying to add people who have given me review feedback on earlier changes, and people who I can look up activity for