Before I mentioned using @, and I have a patch that makes that change in
the parser and in all the ISA descs. It was less painful than you may
assume.
I haven't looked at your patches yet... is the main point of switching from
. to @ to allow structure field accesses?
Basically. It could
There's a good chance the implementation was copied from LTR and not
completely updated. Please go ahead and make the switch, and if it works
I'm willing to say that's what the problem is. I'll look it over once
more carefully if that works and we're going to commit it.
Gabe
On 04/27/11 04:47,
On 04/27/11 08:02, Steve Reinhardt wrote:
On Wed, Apr 27, 2011 at 1:21 AM, Gabe Black gbl...@eecs.umich.edu wrote:
The XML thing is an interesting possibility, and it avoids having to
make a whole new thing that understands C++. It would still mean we'd
have to make a whole new thing that
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/653/
---
(Updated 2011-04-27 10:32:08.616217)
Review request for Default, Ali Saidi, Gabe
On Wed, Apr 27, 2011 at 10:14 AM, Gabe Black gbl...@eecs.umich.edu wrote:
On 04/27/11 08:02, Steve Reinhardt wrote:
On Wed, Apr 27, 2011 at 1:21 AM, Gabe Black gbl...@eecs.umich.edu
wrote:
Perhaps the heuristics could simply be extended to deal with
structure field accesses... if the
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/661/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/662/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/663/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/664/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
Hi Everyone,
We don't have an official policy on code reviews, but I think we're
being a bit pedantic with them. While I definitely want us to err on
the side of having code review is the author has any doubt, I think it
is completely unnecessary to have reviews on things like changing
comments
That sounds reasonable. With too many reviews it gets harder to get to
all of them, and some obscure things may languish with no reviews
because only one person is comfortable with that code. Reviews are
generally a really good thing but they have some overhead. If we don't
get more
I suspect that my recent review posts motivated this thread.
Overall, I think that the policy that you suggested Nate has been our informal
policy. The reason why I posted my somewhat trivial changes to reviewboard
this morning, is to give Tushar a chance to comment on my changes before I
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/661/#review1161
---
src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/662/#review1164
---
Ship it!
Yeah this will make things clearer between simple and garnet
On 2011-04-27 16:03:25, Tushar Krishna wrote:
src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py, line 44
http://reviews.m5sim.org/r/661/diff/1/?file=12097#file12097line44
In garnet, the link width is actually equal to flit size (i.e. the
entire flit is injected into the
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/660/#review1166
---
Ship it!
This looks good to me, though it does appear to be a
On 2011-04-27 16:03:25, Tushar Krishna wrote:
src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py, line 44
http://reviews.m5sim.org/r/661/diff/1/?file=12097#file12097line44
In garnet, the link width is actually equal to flit size (i.e. the
entire flit is injected into the
On 2011-04-27 16:03:25, Tushar Krishna wrote:
src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py, line 44
http://reviews.m5sim.org/r/661/diff/1/?file=12097#file12097line44
In garnet, the link width is actually equal to flit size (i.e. the
entire flit is injected into the
18 matches
Mail list logo
