---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/704/#review1292
---
src/mem/ruby/profiler/Profiler.hh
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/704/#review1291
---
I apologize it took me a while to review this code. Overall, my major
On 2011-05-17 12:13:18, Nathan Binkert wrote:
src/mem/ruby/profiler/AddressProfiler.cc, line 235
http://reviews.m5sim.org/r/704/diff/1/?file=12593#file12593line235
.name should really have name() as part of the name. Is the
AddressProfiler not a SimObject() ?
Derek Hower
On 2011-05-17 12:13:18, Nathan Binkert wrote:
src/mem/ruby/profiler/Profiler.cc, line 456
http://reviews.m5sim.org/r/704/diff/1/?file=12599#file12599line456
How did you pick this magic number? Can we at least make it a constant
that is defined in a header file with an
On 2011-05-17 12:13:18, Nathan Binkert wrote:
src/mem/ruby/profiler/Profiler.cc, line 456
http://reviews.m5sim.org/r/704/diff/1/?file=12599#file12599line456
How did you pick this magic number? Can we at least make it a constant
that is defined in a header file with an
On 2011-05-17 12:13:18, Nathan Binkert wrote:
src/mem/ruby/profiler/Profiler.cc, line 456
http://reviews.m5sim.org/r/704/diff/1/?file=12599#file12599line456
How did you pick this magic number? Can we at least make it a constant
that is defined in a header file with an
I agree that makes sense in some instances, but I've found that when you do
that, it makes it hard to extract stats that can compare to runs of different
systems. For example, when I'm comparing stats across different systems, I
want to easily compare how many times a coherency miss fell
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/704/#review1237
---
Overall, this is a good start. There are a couple of recurring themes
I had trouble getting my individual patches uploaded to review board (it
said they were diffs?), so I merged them into one. You should ignore the
first request that came through, as it is included below.
In the future, it's best to use the reviewboard mercurial extension and use
the command
On 2011-05-17 12:13:18, Nathan Binkert wrote:
src/mem/ruby/profiler/Profiler.cc, line 456
http://reviews.m5sim.org/r/704/diff/1/?file=12599#file12599line456
How did you pick this magic number? Can we at least make it a constant
that is defined in a header file with an
On 2011-05-17 12:13:18, Nathan Binkert wrote:
src/mem/ruby/system/Sequencer.hh, line 174
http://reviews.m5sim.org/r/704/diff/1/?file=12604#file12604line174
Hmmm. More vectors of histograms. Can we make this an array instead?
These histograms dynamically size.
Does the default in
These histograms dynamically size.
Does the default in M5 do the same? and using the same resizing algorithm?
The histogram itself dynamically resizes, but the vector that's here doesn't
need to be dynamic.
Nate
___
gem5-dev mailing list
12 matches
Mail list logo
