- Since this is mostly a big import anyway, I'd favor integrating all the
outstanding bug fixes in up front.
So are you saying that it would be best to get all the license fixes,
commented code, whitespace, etc. cleaned up and then
integrate that into just one BIG patch?
If so, I do see your
Not exactly... if there are multiple independent (or mostly independent)
things you did to get everything working, it's preferable to commit those
separately. However, if there are several steps along the way of getting
just one of those independent things ready to go (import code, add license,
I'm assuming that if I start a patch repository on say zooks that I can
give whomever access there and we can go from there... Or would one on
m5sim.org make more sense?
On Sun, Jan 18, 2009 at 11:19 PM, nathan binkert n...@binkert.org wrote:
I have a few more comments. (Steve caught the
I'd say m5sim.org would make more sense.
Nate
2009/1/21 Korey Sewell ksew...@umich.edu:
I'm assuming that if I start a patch repository on say zooks that I can
give whomever access there and we can go from there... Or would one on
m5sim.org make more sense?
On Sun, Jan 18, 2009 at 11:19
I have a few more comments. (Steve caught the major ones)
-- Please don't commit random whitespace changes as this makes
following history more difficult. If you just review your diffs,
they're easy to spot.
-- Please include commit messages with your patches. (The -m option
to qrefresh can be
Hi Korey,
Thanks for sending these out! I just did a quick skim; here are a few
initial comments based on that:
- What's up with some of the license changes? It looked to me like on some
of the files you're changing the license back from the new style (where U-M
is mentioned only at the top)
Thanks Steve,
looks like I have some re-work todo.
My original repo got corrupted when I try to pull in changes without
updating my patches. I was forced to import my patches into a new repo and I
bet what happened was things got messed up when I hand-merged things over.
agh
OK, I'll
