Re: [m5-dev] [PATCH 04 of 18] [mq]: first_patch

2009-09-15 Thread Polina Dudnik
On Mon, Sep 14, 2009 at 6:27 PM, nathan binkert n...@binkert.org wrote: You are right and that's probably more my mistake than Dereks. What happens is that mercurial crashes whenever it would detect a white-space issue. So, for me to make a patch or commit I hacked the style file, and

[m5-dev] [PATCH 04 of 18] [mq]: first_patch

2009-09-14 Thread Derek Hower
# HG changeset patch # User pdud...@gmail.com # Date 1250887966 18000 # Node ID 104115ebc206686948736edaf517718bbdfd3cd5 # Parent f9e065561d5cd8b98a88290a418381e667026a10 [mq]: first_patch diff --git a/src/mem/ruby/libruby.cc b/src/mem/ruby/libruby.cc --- a/src/mem/ruby/libruby.cc +++

Re: [m5-dev] [PATCH 04 of 18] [mq]: first_patch

2009-09-14 Thread Polina Dudnik
On Mon, Sep 14, 2009 at 6:07 PM, Gabriel Michael Black gbl...@eecs.umich.edu wrote: I notice you have several patches that change around style.py. You probably shouldn't have that in a commit ready patch, and you shouldn't change it back and forth throughout the series. You are right and

Re: [m5-dev] [PATCH 04 of 18] [mq]: first_patch

2009-09-14 Thread nathan binkert
You are right and that's probably more my mistake than Dereks. What happens is that mercurial crashes whenever it would detect a white-space issue. So, for me to make a patch or commit I hacked the style file, and these changes made it into the patch. Send me the error message and I'll fix it.