[m5-dev] Code Reviewing

2011-04-27 Thread nathan binkert
Hi Everyone, We don't have an official policy on code reviews, but I think we're being a bit pedantic with them. While I definitely want us to err on the side of having code review is the author has any doubt, I think it is completely unnecessary to have reviews on things like changing comments

Re: [m5-dev] Code Reviewing

2011-04-27 Thread Gabriel Michael Black
That sounds reasonable. With too many reviews it gets harder to get to all of them, and some obscure things may languish with no reviews because only one person is comfortable with that code. Reviews are generally a really good thing but they have some overhead. If we don't get more

Re: [m5-dev] Code Reviewing

2011-04-27 Thread Beckmann, Brad
...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of Gabriel Michael Black Sent: Wednesday, April 27, 2011 11:25 AM To: m5-dev@m5sim.org Subject: Re: [m5-dev] Code Reviewing That sounds reasonable. With too many reviews it gets harder to get to all of them, and some obscure things may