Re: [m5-dev] MIPS_SE compile error

2009-07-31 Thread Korey Sewell
Thanks for the follow-up on that Gabe! On Thu, Jul 30, 2009 at 8:30 PM, Gabriel Michael Black gbl...@eecs.umich.edu wrote: Confident that this fix is correct, that is. I just checked the diff of the older change and I did accidentally nuke an =. If you're in a hurry please go ahead and

Re: [m5-dev] MIPS_SE compile error

2009-07-30 Thread nathan binkert
Korey, can you please comment on this? I'd like to commit a fix since I'm running a compiler that fails on this as well. Nate On Wed, Jul 29, 2009 at 2:48 PM, Vince Weavervi...@csl.cornell.edu wrote: Hello not sure if this is the proper place to send packages, but here it goes currently

Re: [m5-dev] MIPS_SE compile error

2009-07-30 Thread Gabriel Michael Black
This is actually my fault, I think. I changed around the code to use BitUnions and I must have accidentally deleted an = here. I'm pretty confident it's correct, but if you want to be sure you could look at the diff of that change and see what the logic used to be. I'm a little surprised

Re: [m5-dev] MIPS_SE compile error

2009-07-30 Thread Gabriel Michael Black
Confident that this fix is correct, that is. I just checked the diff of the older change and I did accidentally nuke an =. If you're in a hurry please go ahead and commit this fix. Gabe Quoting Gabriel Michael Black gbl...@eecs.umich.edu: This is actually my fault, I think. I changed

[m5-dev] MIPS_SE compile error

2009-07-29 Thread Vince Weaver
Hello not sure if this is the proper place to send packages, but here it goes currently building for MIPS_SE fails. It looks like a = instead of a == error, but the code is pretty dense so I can't tell if it's trying to be overly clever. patch attached below. Vince diff -r b35ef789e6f6