Re: [m5-dev] Review Request: SimpleCPU: Fix a case where a DTLB fault redirects fetch and an I-side walk occurs.

2011-01-19 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/431/#review781 --- I still don't understand how the CPU ends up in a bad state. Could you

Re: [m5-dev] Review Request: SimpleCPU: Fix a case where a DTLB fault redirects fetch and an I-side walk occurs.

2011-01-19 Thread Ali Saidi
completeIFetch() - initiateAcc() -- translation hits in TLB, page marked read only so fault returned immediately - finishTranslation() is called by the DTLB and a fault has been generated - translationFault() - advanceInst() -

Re: [m5-dev] Review Request: SimpleCPU: Fix a case where a DTLB fault redirects fetch and an I-side walk occurs.

2011-01-19 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/431/#review783 --- Ship it! src/cpu/simple/timing.hh

Re: [m5-dev] Review Request: SimpleCPU: Fix a case where a DTLB fault redirects fetch and an I-side walk occurs.

2011-01-19 Thread Ali Saidi
On 2011-01-19 07:02:40, Steve Reinhardt wrote: src/cpu/simple/timing.hh, line 114 http://reviews.m5sim.org/r/431/diff/1/?file=9738#file9738line114 It's interesting that we already had an ITBWaitResponse state defined but had never used it before. Does it make sense to add an

Re: [m5-dev] Review Request: SimpleCPU: Fix a case where a DTLB fault redirects fetch and an I-side walk occurs.

2011-01-19 Thread Gabe Black
Ah, ok, yes, that makes sense. It's another example of more happening inside of a function than you expect, similar to the problem where a trace data structure was being freed and then later used way back on the stack. Things run farther and farther along until a delay is hit which may be quite a

Re: [m5-dev] Review Request: SimpleCPU: Fix a case where a DTLB fault redirects fetch and an I-side walk occurs.

2011-01-19 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/431/#review788 --- - Gabe On 2011-01-18 14:34:11, Ali Saidi wrote:

Re: [m5-dev] Review Request: SimpleCPU: Fix a case where a DTLB fault redirects fetch and an I-side walk occurs.

2011-01-19 Thread Gabe Black
On 2011-01-19 16:22:22, Gabe Black wrote: Review board lost the text of my review apparently. Your change looks good to me. - Gabe --- This is an automatically generated e-mail. To reply, visit:

[m5-dev] Review Request: SimpleCPU: Fix a case where a DTLB fault redirects fetch and an I-side walk occurs.

2011-01-18 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/431/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan