On 2011-04-18 21:20:49, Nathan Binkert wrote:
util/gem5img.py, line 25
http://reviews.m5sim.org/r/644/diff/1/?file=11664#file11664line25
This makes me feel uneasy for a script that you're likely to call using
sudo. I know it's overly paranoid, but why not just simply give the
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/inorder-timing
FAILED!
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/o3-timing FAILED!
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-atomic FAILED!
*
I was looking at some of the stuff in util, and it occurred to me that
the m5 utility program is cross compiled using different Makefiles for
different architectures. Statetrace used to be like that (sort of), but
recently I converted it over to scons and set up some configuration
variables that
On Tue, Apr 19, 2011 at 3:00 AM, Gabe Black gbl...@eecs.umich.edu wrote:
I was looking at some of the stuff in util, and it occurred to me that
the m5 utility program is cross compiled using different Makefiles for
different architectures. Statetrace used to be like that (sort of), but
Looks like it's Lisa's fault ;-)
http://repo.m5sim.org/m5/diff/ab05e20dc4a7/src/mem/cache/base.cc
I think Nate's point is that all the stats vector lengths should be
changed to _numCpus or _numCpus+1 instead of maxThreadsPerCpu to be
consistent.
We should also either (1) always do _numCpus+1
Hey Steve,
I dont disagree with your solution (at least in the interim), but
wouldn't the right solution be to have the actual CPUs pass how many
hardware threads is has to the caches?
The actual regStats happens after all the CPUs are instantiated and
ports are connected (right?), so it would
Lisa should verify, but I think that's what _numCpus is.
On Tue, Apr 19, 2011 at 8:01 AM, Korey Sewell ksew...@umich.edu wrote:
Hey Steve,
I dont disagree with your solution (at least in the interim), but
wouldn't the right solution be to have the actual CPUs pass how many
hardware threads is
It'd be good for Lisa to chime in here to comment on the exact meaning
of _numCpus and how that value is intended to be set.
If you dont care about threads per CPU (and just the raw # of CPUs
value), then I'd defer to Lisa for figuring out what the right vector
lengths are so that they are
Hi guys,
Sorry for the delay in responding. I spent last night on the couch in 3
sweatshirts and under 3 fleece blankets generally feeling like a shit
sandwich and not looking at my email. Fortunately, today I feel a bit more
like a normal human being, so let me page this in.
The point of the
I'd vote for (1) and just do the replacement commands you suggest.
The capitalisation wont work for the inorder model stats since they
all call the name() operator as prefix for their stats, but those
names are easily updated in src/cpu/inorder/resource_pool.cc
Also, the name for the stages can
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/645/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
I've already done the replacement and I'm currently regenerating all
stats :) I've just posted a diff to reviewboard. Please check it
out.
Nate
I'd vote for (1) and just do the replacement commands you suggest.
The capitalisation wont work for the inorder model stats since they
all call
I love that you guys want to fix this. Can we agree on the immediate
fix so it's no longer broken and then improve it? :)
Thanks,
Nate
I suppose you could do that kind of walking, though I think it would be
overly complicated. Let's say again you have 4 private L1s, 2 shared L2s,
and a
I think the immediate fix is the pythonic fix from a few msgs ago. I
believe that's quick and easy. I think :).
On Tue, Apr 19, 2011 at 2:27 PM, nathan binkert n...@binkert.org wrote:
I love that you guys want to fix this. Can we agree on the immediate
fix so it's no longer broken and then
I think the immediate fix is the pythonic fix from a few msgs ago. I
believe that's quick and easy. I think :).
The fix has to be more than python. I'm talking about the original
question. The stats use three different lengths: _numCpus + 1,
_numCpus,
or maxThreadsPerCPU. Which one is
I think _numCpus+1 is the safe choiceLisa?
On Tue, Apr 19, 2011 at 6:01 PM, nathan binkert n...@binkert.org wrote:
I think the immediate fix is the pythonic fix from a few msgs ago. I
believe that's quick and easy. I think :).
The fix has to be more than python. I'm talking about the
On Tue, Apr 19, 2011 at 3:13 PM, Gabriel Michael Black
gbl...@eecs.umich.edu wrote:
Caching the list of generated SLICC files sounds like a good idea to
me. I'm not sure this would require recursive scons invocations,
since we manage to build the list dynamically already without that. I
I think Lisa's pythonic fix is the one where we use the _numCpus
value that's calculated entirely in python (including the +1 offset in
FS mode) and don't attempt the automatic C++ technique that Korey
proposed. Yes, that still involves C++ changes, specifically making
everything in the C++ code
Yes, Steve's got it right. In the C++ you replace the instances of the 3
lengths Nate mentions with a single var (that can be more aptly named as
Steve wants) that is pythonically calculated and passed in from the
configuration. I'm making up words here :).
I think I can do this tonight or
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/645/#review1137
---
Ship it!
- Ali
On 2011-04-19 13:20:04, Nathan Binkert wrote:
changeset 24406820a7e0 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=24406820a7e0
description:
python: different import for dealing with demandimport
diffstat:
src/python/m5/__init__.py | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diffs (16 lines):
changeset 38befb82b2c9 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=38befb82b2c9
description:
stats: rename stats so they can be used as python expressions
diffstat:
src/cpu/inorder/pipeline_stage.cc | 2 +-
src/cpu/inorder/resource_pool.9stage.cc | 39
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/646/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
Yes, Steve's got it right. In the C++ you replace the instances of the 3
lengths Nate mentions with a single var (that can be more aptly named as
Steve wants) that is pythonically calculated and passed in from the
configuration. I'm making up words here :).
I think I can do this tonight or
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/645/#review1138
---
Ship it!
I'm sure this will cause some people headaches if they have
Quoting Steve Reinhardt ste...@gmail.com:
On Tue, Apr 19, 2011 at 3:13 PM, Gabriel Michael Black
gbl...@eecs.umich.edu wrote:
Caching the list of generated SLICC files sounds like a good idea to
me. I'm not sure this would require recursive scons invocations,
since we manage to build the
26 matches
Mail list logo
