Re: [m5-dev] Review Request: time: improve time datastructure

2011-01-14 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/425/ --- (Updated 2011-01-14 13:32:44.178285) Review request for Default, Ali Saidi, Gabe Bl

Re: [m5-dev] MOESI_CMP_token

2011-01-14 Thread Beckmann, Brad
Hi Nilay, There is often a tradeoff between doing operations in actions versus the input port. Overall, I agree with you that we should concentrate on doing most/all operations in actions, not the input ports. The input port logic is often a confusing nested conditional mess and performing ot

Re: [m5-dev] Review Request: time: improve time datastructure

2011-01-14 Thread Gabe Black
> On 2011-01-13 23:50:52, Nathan Binkert wrote: > > src/base/time.cc, line 89 > > > > > > Oh, I used whatever you used. CLOCK_REALTIME is fine too, though I > > guess I never really cared about the fact that I could print the

[m5-dev] MOESI_CMP_token

2011-01-14 Thread Nilay
I am trying to update the MOESI CMP token protocol. Line 563 in the file for the L1 cache controller caught my eye. While processing a message received through the response network, the transaction buffer entry for the address is edited. tbe.ExternalResponse := true; Should this happen

[m5-dev] Cron /z/m5/regression/do-regression quick

2011-01-14 Thread Cron Daemon
scons: *** [build/ALPHA_SE/python/m5/internal/param_RubySystem_wrap.cc] Error 1 scons: *** [build/ALPHA_SE_MOESI_hammer/python/m5/internal/param_RubySystem_wrap.cc] Error 1 scons: *** [build/ALPHA_SE_MESI_CMP_directory/python/m5/internal/param_RubySystem_wrap.cc] Error 1 scons: *** [build/ALPH