---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/720/#review1262
---
What does Self.all do? What is it for? You have one use in the change so
That does look nice. It can be a lot of work slogging through O3 trace
output to figure out what's going on, and I expect this to make that a
lot easier. I glanced through the code and didn't see anything
particularly objectionable, although I wouldn't necessarily consider
that a thorough review :-
Cool! I haven't looked at the code yet, but the output looks nice.
Steve
On Thu, May 26, 2011 at 8:19 PM, Ali Saidi wrote:
> Anyone that is curious what this looks like... lets try the picture again...
>
>
>
>
> Ali
>
> On May 26, 2011, at 9:19 PM, Ali Saidi wrote:
>
>>
>> -
Anyone that is curious what this looks like:
Ali
On May 26, 2011, at 9:19 PM, Ali Saidi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/721/
> -
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/721/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
Binke
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/720/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
Binke
On Fri, 6 May 2011, Beckmann, Brad wrote:
Hi Nilay,
Yeah, pulling the State into the Machine makes sense to me. If I
recall, my previous patch made it necessary that each machine included a
state_declaration (previously the state enum). More tightly integrating
the state to the machine see
scons: `build/ALPHA_SE/m5.debug' is up to date.
scons: `build/ALPHA_SE_MOESI_hammer/m5.debug' is up to date.
scons: `build/ALPHA_SE_MESI_CMP_directory/m5.debug' is up to date.
scons: `build/ALPHA_SE_MOESI_CMP_directory/m5.debug' is up to date.
scons: `build/ALPHA_SE_MOESI_CMP_token/m5.debug' is up
