Hi all,
I think src/mem/ruby/common/Set.hh has a bug.
It has the following lines:
static const int LONG_BITS = std::numeric_limitslong::digits;
static const int INDEX_SHIFT = LONG_BITS == 64 ? 6 : 5;
Since long by default is signed, LONG_BITS will always be 31 or 63,
depending on the
Tushar,
There should be an earlier thread about this issue (or one very similar). A
symptom of this issue is the inability to run large systems on 32-bit
machines.
I think what we wanted to do is use STL bitsets here (check that thread for
details). I would do it myself but I wont have time until
Thanks Korey.
Yeah inability to run 32 cores on 32-bit machines, and inability to
run 64 cores on 64-bit machines is the same issue, so I guess the STL
bitsets solution should fix this problem too.
Thanks,
Tushar
On 5/28/2011 2:34 AM, Korey Sewell wrote:
Tushar,
There should be an earlier
scons: `build/ALPHA_SE/m5.debug' is up to date.
scons: `build/ALPHA_SE_MOESI_hammer/m5.debug' is up to date.
scons: `build/ALPHA_SE_MESI_CMP_directory/m5.debug' is up to date.
scons: `build/ALPHA_SE_MOESI_CMP_directory/m5.debug' is up to date.
scons: `build/ALPHA_SE_MOESI_CMP_token/m5.debug' is up
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/720/#review1269
---
src/python/m5/params.py
http://reviews.m5sim.org/r/720/#comment1746
On 2011-05-26 23:29:05, Gabe Black wrote:
What does Self.all do? What is it for? You have one use in the change so I
have a basic idea, but it would be helpful to know the specifics.
Ali Saidi wrote:
It's similar to Parent.any in that it traverses the object hierarchy and
finds
On 2011-05-27 20:10:01, Nathan Binkert wrote:
src/python/m5/SimObject.py, line 729
http://reviews.m5sim.org/r/720/diff/1/?file=12673#file12673line729
Does this do what you want? It doesn't seem like it would recurse down
the tree and find all nodes that match (or does it?)
It
On 2011-05-28 09:20:00, Ali Saidi wrote:
src/python/m5/proxy.py, line 187
http://reviews.m5sim.org/r/720/diff/1/?file=12675#file12675line187
Parent.all would find every object above you in the hierarchy that
matched, although I've never tried it. I only use self.all..
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/720/#review1272
---
src/sim/System.py
http://reviews.m5sim.org/r/720/#comment1750
It
On 2011-05-28 17:22:15, Steve Reinhardt wrote:
src/sim/System.py, line 47
http://reviews.m5sim.org/r/720/diff/1/?file=12676#file12676line47
It seems odd that Parent.any here will generate an error if there are
multiple matches, but Self.all only is necessary if there are multiple
On 2011-05-28 17:22:15, Steve Reinhardt wrote:
src/sim/System.py, line 47
http://reviews.m5sim.org/r/720/diff/1/?file=12676#file12676line47
It seems odd that Parent.any here will generate an error if there are
multiple matches, but Self.all only is necessary if there are multiple
Hi Brad
I am trying to complete the patch on functional accesses in Ruby. I came
across this problem while testing the patch for higher number of
processors. I am working with MESI CMP directory protocol right now. So I
will describe the problem in its context.
Assume we are trying to
ping
Quoting Gabe Black gbl...@eecs.umich.edu:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/719/
---
Review request for Default, Ali
ping
Quoting Gabe Black gbl...@eecs.umich.edu:
Ping...
On 05/05/11 10:38, Steve Reinhardt wrote:
On Wed, May 4, 2011 at 2:25 PM, Gabe Black gbl...@eecs.umich.edu wrote:
Did that make sense?
I see how that could work... I think I was more puzzled by how you would
figure out that
for
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/719/#review1275
---
Ship it!
- Steve
On 2011-05-25 09:25:20, Gabe Black wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/655/#review1276
---
The description is a little general; can you be more specific about what
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/656/#review1277
---
This looks fine to me, but I'm confused... don't you delete this code
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/657/#review1278
---
Looks fine, but shouldn't you be doing all the ISAs if you're going to
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/658/#review1279
---
See previous reviews... this looks fine if all the ISAs are converted to
19 matches
Mail list logo
