As feared, this change does break x86 boot. I'll see if I can fix it.
Ironically I found this out while adding an X86 FS regression. We really
do need to figure out what's going on with those values and how that
maps to other ISAs.
Gabe
Gabe Black wrote:
On 2010-11-08 17:56:14, Nathan
It's not an isa thing, it's hard-coded in the struct that is passed to the ide
driver. Either way, it-s not those values that is breaking it. They do nothing
when they're 0.
Ali
On Nov 21, 2010, at 11:58 PM, Gabe Black wrote:
As feared, this change does break x86 boot. I'll see if I can
Yeah, I figured it out, and a fix will be coming soon. If we're keeping
score I'm sure I've accidentally broken more things than you, so no
sweat. There will be a regression soon so this will be less likely to
happen again.
Gabe
Ali Saidi wrote:
It's not an isa thing, it's hard-coded in the
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/292/#review441
---
Ship it!
- Nathan
On 2010-11-08 15:34:45, Ali Saidi wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/292/
---
Review request for Default.
Summary
---
ARM: Add support for a dumb IDE
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/292/#review436
---
src/dev/ide_ctrl.cc
http://reviews.m5sim.org/r/292/#comment646
Is
On 2010-11-08 17:56:14, Nathan Binkert wrote:
src/dev/ide_ctrl.cc, line 454
http://reviews.m5sim.org/r/292/diff/1/?file=5058#file5058line454
Is this something that we should deal with on a per device basis, or is
this a more generic thing? Also, is this something that should be
