Re: [m5-dev] Review Request: Ruby: Change PerfectSwitch's wakeup function

2011-02-14 Thread Nilay Vaish
Brad, this patch to affects the number of ticks required for performing a particular number of loads. I don't expect such a thing to happen. Do you? -- Nilay On Wed, 9 Feb 2011, Brad Beckmann wrote: --- This is an automatically

Re: [m5-dev] Review Request: Ruby: Change PerfectSwitch's wakeup function

2011-02-14 Thread Nilay Vaish
I realized the reason for this. Actually, the wakeup function performs a round-robin scheduling between the incoming links. This code had moved inside the a new if condition that has been introduced in the code. I have moved that code before the if condition so that the timing remains same as

Re: [m5-dev] Review Request: Ruby: Change PerfectSwitch's wakeup function

2011-02-09 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/328/#review839 --- Overall, this looks great. A pretty simple change that offers

Re: [m5-dev] Review Request: Ruby: Change PerfectSwitch's wakeup function

2011-02-09 Thread Nilay Vaish
On 2011-02-09 09:44:20, Brad Beckmann wrote: src/mem/ruby/buffers/MessageBuffer.cc, line 234 http://reviews.m5sim.org/r/328/diff/2/?file=10257#file10257line234 Is there a reason why you want to pass the message pointer instead of just the vnet id? I would change that. It is a

Re: [m5-dev] Review Request: Ruby: Change PerfectSwitch's wakeup function

2011-02-09 Thread nathan binkert
One simple nitpick before you commit is to fix the commit message so you put a proper summary line. Nate On Sat, Feb 5, 2011 at 12:47 PM, Nilay Vaish ni...@cs.wisc.edu wrote: This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/328/ Review request for

Re: [m5-dev] Review Request: Ruby: Change PerfectSwitch's wakeup function

2011-02-09 Thread Nilay Vaish
On Wed, 9 Feb 2011, nathan binkert wrote: One simple nitpick before you commit is to fix the commit message so you put a proper summary line. Nate What would you like it to be? ___ m5-dev mailing list m5-dev@m5sim.org

Re: [m5-dev] Review Request: Ruby: Change PerfectSwitch's wakeup function

2011-02-09 Thread nathan binkert
One simple nitpick before you commit is to fix the commit message so you put a proper summary line.  Nate What would you like it to be? Whatever you want. Remember that it's supposed to be a single descriptive word followed by a single line summary describing the commit. It's described

[m5-dev] Review Request: Ruby: Change PerfectSwitch's wakeup function

2011-02-05 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/328/ --- Review request for Default. Summary --- Currently the wakeup function for the