Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-30 Thread Korey Sewell
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/704/#review1292 --- src/mem/ruby/profiler/Profiler.hh

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-30 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/704/#review1291 --- I apologize it took me a while to review this code. Overall, my major co

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-18 Thread nathan binkert
> > I agree that makes sense in some instances, but I've found that when you do > that, it makes it hard to extract stats that can compare to runs of different > systems. For example, when I'm comparing stats across different systems, I > want to easily compare how many times a coherency miss fe

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-18 Thread Korey Sewell
> On 2011-05-17 12:13:18, Nathan Binkert wrote: > > src/mem/ruby/profiler/Profiler.cc, line 456 > > > > > > How did you pick this magic number? Can we at least make it a constant > > that is defined in a header file with a

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-18 Thread Nathan Binkert
> On 2011-05-17 12:13:18, Nathan Binkert wrote: > > src/mem/ruby/profiler/Profiler.cc, line 456 > > > > > > How did you pick this magic number? Can we at least make it a constant > > that is defined in a header file with a

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-18 Thread Korey Sewell
> On 2011-05-17 12:13:18, Nathan Binkert wrote: > > src/mem/ruby/profiler/Profiler.cc, line 456 > > > > > > How did you pick this magic number? Can we at least make it a constant > > that is defined in a header file with a

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-18 Thread Nathan Binkert
> On 2011-05-17 12:13:18, Nathan Binkert wrote: > > src/mem/ruby/profiler/AddressProfiler.cc, line 235 > > > > > > .name should really have name() as part of the name. Is the > > AddressProfiler not a SimObject() ? > > De

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-17 Thread nathan binkert
> > These histograms dynamically size. > > Does the default in M5 do the same? and using the same resizing algorithm? > > The histogram itself dynamically resizes, but the vector that's here doesn't need to be dynamic. Nate ___ gem5-dev mailing list ge

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-17 Thread Korey Sewell
> On 2011-05-17 12:13:18, Nathan Binkert wrote: > > src/mem/ruby/system/Sequencer.hh, line 174 > > > > > > Hmmm. More vectors of histograms. Can we make this an array instead? These histograms dynamically size. Does the

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-17 Thread Korey Sewell
> On 2011-05-17 12:13:18, Nathan Binkert wrote: > > src/mem/ruby/profiler/Profiler.cc, line 456 > > > > > > How did you pick this magic number? Can we at least make it a constant > > that is defined in a header file with a

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-17 Thread nathan binkert
> > I had trouble getting my individual patches uploaded to review board (it > said they were diffs?), so I merged them into one. You should ignore the > first request that came through, as it is included below. In the future, it's best to use the reviewboard mercurial extension and use the comm

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-17 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/704/#review1237 --- Overall, this is a good start. There are a couple of recurring themes in