[m5-dev] IsOn using a vector

2008-09-23 Thread Gabe Black
I just finished stepping through some code having to do with PCs in simple CPU, and I noticed that not printing DPRINTFs is actually a fairly involved process, considering that you're not actually doing anything. Part of the issue, I think, is that whether or not a traceflag is on is

Re: [m5-dev] IsOn using a vector

2008-09-23 Thread Ali Saidi
You're talking about replacing return flags[t]; with a space optimized bit vector? I imagine it would help performance some if for no other reason that the trace flags would fit is a single cache block rather than spanning multiple as they do now. Ali On Sep 23, 2008, at 2:42 AM, Gabe

Re: [m5-dev] IsOn using a vector

2008-09-23 Thread Kevin Lim
I think I probably started using vectorbool but wound up using bitset eventually. Likely anything I used vectorbool for could be easily cleaned up to use bitset instead. It's probably not going to make a difference performance wise where I used it, but at least it would be more consistent.

Re: [m5-dev] IsOn using a vector

2008-09-23 Thread nathan binkert
I think vectorbool is indeed a vector of bools because x[0] is supposed to return a bool * that you can mess with. I think that's why bitset exists. I'd be happy to see us move to bitset. The size of the bitset is easy to get since the code is autogenerated anyway. Nate On Tue, Sep 23, 2008