[m5-dev] Review Request: ARM: Cleanup implementation of ITSTATE and put important code in PCState.

2011-03-30 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/616/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

Re: [m5-dev] Review Request: ARM: Cleanup implementation of ITSTATE and put important code in PCState.

2011-03-30 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/616/#review1038 --- This is a great change. I saw one style mistake, and also I think some

Re: [m5-dev] Review Request: ARM: Cleanup implementation of ITSTATE and put important code in PCState.

2011-03-30 Thread Ali Saidi
On 2011-03-30 09:53:54, Gabe Black wrote: src/arch/arm/types.hh, line 350 http://reviews.m5sim.org/r/616/diff/1/?file=11348#file11348line350 You could add new fields to the ITSTATE bitunion that would make this easier. cond and mask could be SubBitUnions which can be treated as

Re: [m5-dev] Review Request: ARM: Cleanup implementation of ITSTATE and put important code in PCState.

2011-03-30 Thread Gabe Black
On 2011-03-30 09:53:54, Gabe Black wrote: src/arch/arm/types.hh, line 350 http://reviews.m5sim.org/r/616/diff/1/?file=11348#file11348line350 You could add new fields to the ITSTATE bitunion that would make this easier. cond and mask could be SubBitUnions which can be treated as