Re: [m5-dev] Review Request: Ruby: Convert AccessModeType to RubyAccessMode

2011-03-22 Thread Nilay 

On Sat, March 19, 2011 3:57 pm, Beckmann, Brad wrote:
> Nevermind, I understand the reason now.  This looks good to me.
>
> Thanks,
>
> Brad
>
>> -Original Message-
>> From: Beckmann, Brad
>> Sent: Saturday, March 19, 2011 1:50 PM
>> To: 'M5 Developer List'
>> Subject: RE: [m5-dev] Review Request: Ruby: Convert AccessModeType to
>> RubyAccessMode
>>
>> Hi Nilay,
>>
>> Why do you want to change the name?  Both names seem equivalent to me.
>>
>> Brad
>>
>>

Brad, I had to make the decision in favor of one of the two names. I
decided not to choose AccessModeType because Mode and Type have almost the
same meaning.


--
Nilay

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: Ruby: Convert AccessModeType to RubyAccessMode

2011-03-22 Thread Beckmann, Brad 
Nevermind, I understand the reason now.  This looks good to me.

Thanks,

Brad

> -Original Message-
> From: Beckmann, Brad
> Sent: Saturday, March 19, 2011 1:50 PM
> To: 'M5 Developer List'
> Subject: RE: [m5-dev] Review Request: Ruby: Convert AccessModeType to
> RubyAccessMode
> 
> Hi Nilay,
> 
> Why do you want to change the name?  Both names seem equivalent to me.
> 
> Brad
> 
> 
> > -Original Message-
> > From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On
> > Behalf Of Nilay Vaish
> > Sent: Friday, March 18, 2011 9:55 PM
> > To: Nilay Vaish; Default
> > Subject: [m5-dev] Review Request: Ruby: Convert AccessModeType to
> > RubyAccessMode
> >
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviews.m5sim.org/r/601/
> > ---
> >
> > Review request for Default.
> >
> >
> > Summary
> > ---
> >
> > Ruby: Convert AccessModeType to RubyAccessMode
> > This patch converts AccessModeType to RubyAccessMode so that both the
> > protocol dependent and independent code uses the same access mode.
> >
> >
> > Diffs
> > -
> >
> >   src/cpu/testers/rubytest/Check.hh 9a6a02a235f1
> >   src/cpu/testers/rubytest/Check.cc 9a6a02a235f1
> >   src/mem/protocol/MESI_CMP_directory-msg.sm 9a6a02a235f1
> >   src/mem/protocol/MOESI_CMP_directory-msg.sm 9a6a02a235f1
> >   src/mem/protocol/MOESI_CMP_token-L1cache.sm 9a6a02a235f1
> >   src/mem/protocol/MOESI_CMP_token-dir.sm 9a6a02a235f1
> >   src/mem/protocol/MOESI_CMP_token-msg.sm 9a6a02a235f1
> >   src/mem/protocol/RubySlicc_Exports.sm 9a6a02a235f1
> >   src/mem/protocol/RubySlicc_Types.sm 9a6a02a235f1
> >   src/mem/ruby/profiler/AccessTraceForAddress.hh 9a6a02a235f1
> >   src/mem/ruby/profiler/AccessTraceForAddress.cc 9a6a02a235f1
> >   src/mem/ruby/profiler/AddressProfiler.hh 9a6a02a235f1
> >   src/mem/ruby/profiler/AddressProfiler.cc 9a6a02a235f1
> >   src/mem/ruby/profiler/CacheProfiler.hh 9a6a02a235f1
> >   src/mem/ruby/profiler/CacheProfiler.cc 9a6a02a235f1
> >   src/mem/ruby/profiler/Profiler.hh 9a6a02a235f1
> >   src/mem/ruby/slicc_interface/RubyRequest.hh 9a6a02a235f1
> >   src/mem/ruby/system/CacheMemory.hh 9a6a02a235f1
> >   src/mem/ruby/system/CacheMemory.cc 9a6a02a235f1
> >   src/mem/ruby/system/Sequencer.hh 9a6a02a235f1
> >   src/mem/ruby/system/Sequencer.cc 9a6a02a235f1
> >
> > Diff: http://reviews.m5sim.org/r/601/diff
> >
> >
> > Testing
> > ---
> >
> >
> > Thanks,
> >
> > Nilay
> >
> > ___
> > m5-dev mailing list
> > m5-dev@m5sim.org
> > http://m5sim.org/mailman/listinfo/m5-dev


___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: Ruby: Convert AccessModeType to RubyAccessMode

2011-03-22 Thread Beckmann, Brad 
Hi Nilay,

Why do you want to change the name?  Both names seem equivalent to me.

Brad


> -Original Message-
> From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On
> Behalf Of Nilay Vaish
> Sent: Friday, March 18, 2011 9:55 PM
> To: Nilay Vaish; Default
> Subject: [m5-dev] Review Request: Ruby: Convert AccessModeType to
> RubyAccessMode
> 
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/601/
> ---
> 
> Review request for Default.
> 
> 
> Summary
> ---
> 
> Ruby: Convert AccessModeType to RubyAccessMode
> This patch converts AccessModeType to RubyAccessMode so that both the
> protocol dependent and independent code uses the same access mode.
> 
> 
> Diffs
> -
> 
>   src/cpu/testers/rubytest/Check.hh 9a6a02a235f1
>   src/cpu/testers/rubytest/Check.cc 9a6a02a235f1
>   src/mem/protocol/MESI_CMP_directory-msg.sm 9a6a02a235f1
>   src/mem/protocol/MOESI_CMP_directory-msg.sm 9a6a02a235f1
>   src/mem/protocol/MOESI_CMP_token-L1cache.sm 9a6a02a235f1
>   src/mem/protocol/MOESI_CMP_token-dir.sm 9a6a02a235f1
>   src/mem/protocol/MOESI_CMP_token-msg.sm 9a6a02a235f1
>   src/mem/protocol/RubySlicc_Exports.sm 9a6a02a235f1
>   src/mem/protocol/RubySlicc_Types.sm 9a6a02a235f1
>   src/mem/ruby/profiler/AccessTraceForAddress.hh 9a6a02a235f1
>   src/mem/ruby/profiler/AccessTraceForAddress.cc 9a6a02a235f1
>   src/mem/ruby/profiler/AddressProfiler.hh 9a6a02a235f1
>   src/mem/ruby/profiler/AddressProfiler.cc 9a6a02a235f1
>   src/mem/ruby/profiler/CacheProfiler.hh 9a6a02a235f1
>   src/mem/ruby/profiler/CacheProfiler.cc 9a6a02a235f1
>   src/mem/ruby/profiler/Profiler.hh 9a6a02a235f1
>   src/mem/ruby/slicc_interface/RubyRequest.hh 9a6a02a235f1
>   src/mem/ruby/system/CacheMemory.hh 9a6a02a235f1
>   src/mem/ruby/system/CacheMemory.cc 9a6a02a235f1
>   src/mem/ruby/system/Sequencer.hh 9a6a02a235f1
>   src/mem/ruby/system/Sequencer.cc 9a6a02a235f1
> 
> Diff: http://reviews.m5sim.org/r/601/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nilay
> 
> ___
> m5-dev mailing list
> m5-dev@m5sim.org
> http://m5sim.org/mailman/listinfo/m5-dev


___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: Ruby: Convert AccessModeType to RubyAccessMode

2011-03-19 Thread Brad Beckmann 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/601/#review996
---

Ship it!


- Brad


On 2011-03-18 21:55:08, Nilay Vaish wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/601/
> ---
> 
> (Updated 2011-03-18 21:55:08)
> 
> 
> Review request for Default.
> 
> 
> Summary
> ---
> 
> Ruby: Convert AccessModeType to RubyAccessMode
> This patch converts AccessModeType to RubyAccessMode so that both the
> protocol dependent and independent code uses the same access mode.
> 
> 
> Diffs
> -
> 
>   src/cpu/testers/rubytest/Check.hh 9a6a02a235f1 
>   src/cpu/testers/rubytest/Check.cc 9a6a02a235f1 
>   src/mem/protocol/MESI_CMP_directory-msg.sm 9a6a02a235f1 
>   src/mem/protocol/MOESI_CMP_directory-msg.sm 9a6a02a235f1 
>   src/mem/protocol/MOESI_CMP_token-L1cache.sm 9a6a02a235f1 
>   src/mem/protocol/MOESI_CMP_token-dir.sm 9a6a02a235f1 
>   src/mem/protocol/MOESI_CMP_token-msg.sm 9a6a02a235f1 
>   src/mem/protocol/RubySlicc_Exports.sm 9a6a02a235f1 
>   src/mem/protocol/RubySlicc_Types.sm 9a6a02a235f1 
>   src/mem/ruby/profiler/AccessTraceForAddress.hh 9a6a02a235f1 
>   src/mem/ruby/profiler/AccessTraceForAddress.cc 9a6a02a235f1 
>   src/mem/ruby/profiler/AddressProfiler.hh 9a6a02a235f1 
>   src/mem/ruby/profiler/AddressProfiler.cc 9a6a02a235f1 
>   src/mem/ruby/profiler/CacheProfiler.hh 9a6a02a235f1 
>   src/mem/ruby/profiler/CacheProfiler.cc 9a6a02a235f1 
>   src/mem/ruby/profiler/Profiler.hh 9a6a02a235f1 
>   src/mem/ruby/slicc_interface/RubyRequest.hh 9a6a02a235f1 
>   src/mem/ruby/system/CacheMemory.hh 9a6a02a235f1 
>   src/mem/ruby/system/CacheMemory.cc 9a6a02a235f1 
>   src/mem/ruby/system/Sequencer.hh 9a6a02a235f1 
>   src/mem/ruby/system/Sequencer.cc 9a6a02a235f1 
> 
> Diff: http://reviews.m5sim.org/r/601/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nilay
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

[m5-dev] Review Request: Ruby: Convert AccessModeType to RubyAccessMode

2011-03-18 Thread Nilay Vaish 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/601/
---

Review request for Default.


Summary
---

Ruby: Convert AccessModeType to RubyAccessMode
This patch converts AccessModeType to RubyAccessMode so that both the
protocol dependent and independent code uses the same access mode.


Diffs
-

  src/cpu/testers/rubytest/Check.hh 9a6a02a235f1 
  src/cpu/testers/rubytest/Check.cc 9a6a02a235f1 
  src/mem/protocol/MESI_CMP_directory-msg.sm 9a6a02a235f1 
  src/mem/protocol/MOESI_CMP_directory-msg.sm 9a6a02a235f1 
  src/mem/protocol/MOESI_CMP_token-L1cache.sm 9a6a02a235f1 
  src/mem/protocol/MOESI_CMP_token-dir.sm 9a6a02a235f1 
  src/mem/protocol/MOESI_CMP_token-msg.sm 9a6a02a235f1 
  src/mem/protocol/RubySlicc_Exports.sm 9a6a02a235f1 
  src/mem/protocol/RubySlicc_Types.sm 9a6a02a235f1 
  src/mem/ruby/profiler/AccessTraceForAddress.hh 9a6a02a235f1 
  src/mem/ruby/profiler/AccessTraceForAddress.cc 9a6a02a235f1 
  src/mem/ruby/profiler/AddressProfiler.hh 9a6a02a235f1 
  src/mem/ruby/profiler/AddressProfiler.cc 9a6a02a235f1 
  src/mem/ruby/profiler/CacheProfiler.hh 9a6a02a235f1 
  src/mem/ruby/profiler/CacheProfiler.cc 9a6a02a235f1 
  src/mem/ruby/profiler/Profiler.hh 9a6a02a235f1 
  src/mem/ruby/slicc_interface/RubyRequest.hh 9a6a02a235f1 
  src/mem/ruby/system/CacheMemory.hh 9a6a02a235f1 
  src/mem/ruby/system/CacheMemory.cc 9a6a02a235f1 
  src/mem/ruby/system/Sequencer.hh 9a6a02a235f1 
  src/mem/ruby/system/Sequencer.cc 9a6a02a235f1 

Diff: http://reviews.m5sim.org/r/601/diff


Testing
---


Thanks,

Nilay

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev