Re: [m5-dev] changeset in m5: Use logical operator instead of bitwise operato...

2008-09-26 Thread Steve Reinhardt
Your response was not without humor... On Fri, Sep 26, 2008 at 4:38 PM, nathan binkert <[EMAIL PROTECTED]> wrote: > I don't disagree. > > 2008/9/26 Steve Reinhardt <[EMAIL PROTECTED]>: > > Why the double negative > ___ m5-dev mailing list m5-dev@m5sim.o

Re: [m5-dev] changeset in m5: Use logical operator instead of bitwise operato...

2008-09-26 Thread nathan binkert
I don't disagree. Korey, can you comment? What is correct here? Nate 2008/9/26 Steve Reinhardt <[EMAIL PROTECTED]>: > Why the double negative ("!yield_mask != 0")? Seems like this should either > be "!yield_mask" or "yield_mask == 0", but not something in between... > > Steve > > On Fri, Sep

Re: [m5-dev] changeset in m5: Use logical operator instead of bitwise operato...

2008-09-26 Thread Steve Reinhardt
Why the double negative ("!yield_mask != 0")? Seems like this should either be "!yield_mask" or "yield_mask == 0", but not something in between... Steve On Fri, Sep 26, 2008 at 3:29 PM, Nathan Binkert <[EMAIL PROTECTED]> wrote: > changeset eb5664be6075 in /z/repo/m5 > details: http://repo.m5sim

[m5-dev] changeset in m5: Use logical operator instead of bitwise operato...

2008-09-26 Thread Nathan Binkert
changeset eb5664be6075 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=eb5664be6075 description: Use logical operator instead of bitwise operator for correctness. diffstat: 0 files changed diffs (24 lines): diff -r c2db27fc4f27 -r eb5664be6075 src/arch/mips/mt.hh ---