Re: [m5-dev] changeset in m5: style: Remove non-leading tabs everywhere they ...

2008-09-10 Thread Gabe Black
Actually, no. In the original files, tabs were replaced with enough spaces so that the things after them still started on column boundaries. When in a diff, there's a + or - at the start of the line, so one less space is needed to line up properly. Fortunately there was only one patch which did

Re: [m5-dev] changeset in m5: style: Remove non-leading tabs everywhere they ...

2008-09-10 Thread Ali Saidi
we've hacked on remote_gdb so much that preserving the tabs wouldn't really help. Ali On Sep 10, 2008, at 4:48 PM, [EMAIL PROTECTED] wrote: > Also I notice some of these are changes to the *bsd copyrights on > some files, > for instance the remote_gdbs. We probably shouldn't change those. >

Re: [m5-dev] changeset in m5: style: Remove non-leading tabs everywhere they ...

2008-09-10 Thread Ali Saidi
run expand on the patch files before trying to apply them... Everything should work fine. Ali On Sep 10, 2008, at 4:44 PM, [EMAIL PROTECTED] wrote: > I really hope this isn't going to make applying all my patches > significantly > harder... > > Gabe > > Quoting Ali Saidi <[EMAIL PROTECTED]>:

Re: [m5-dev] changeset in m5: style: Remove non-leading tabs everywhere they ...

2008-09-10 Thread gblack
Also I notice some of these are changes to the *bsd copyrights on some files, for instance the remote_gdbs. We probably shouldn't change those. Gabe Quoting Ali Saidi <[EMAIL PROTECTED]>: > changeset 3af77710f397 in /z/repo/m5 > details: http://repo.m5sim.org/m5?cmd=changeset;node=3af77710f397 >

Re: [m5-dev] changeset in m5: style: Remove non-leading tabs everywhere they ...

2008-09-10 Thread gblack
I really hope this isn't going to make applying all my patches significantly harder... Gabe Quoting Ali Saidi <[EMAIL PROTECTED]>: > changeset 3af77710f397 in /z/repo/m5 > details: http://repo.m5sim.org/m5?cmd=changeset;node=3af77710f397 > description: > style: Remove non-leading tabs ever

[m5-dev] changeset in m5: style: Remove non-leading tabs everywhere they ...

2008-09-10 Thread Ali Saidi
changeset 3af77710f397 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=3af77710f397 description: style: Remove non-leading tabs everywhere they shouldn't be. Developers should configure their editors to not insert tabs diffstat: 69 files changed, 427 insertions(+), 682