Re: [m5-dev] delete at sim exit

2011-02-24 Thread Steve Reinhardt
On Wed, Feb 23, 2011 at 5:03 PM, Gabe Black gbl...@eecs.umich.edu wrote: Forgive my ignorance here, but why is the limit event set up each time simulate is called? Couldn't it just be a member of the event queue class and always stuck at the end and left there? The limit can change from call

Re: [m5-dev] delete at sim exit

2011-02-24 Thread Ali Saidi
On Thu, 24 Feb 2011 10:43:52 -0800, Steve Reinhardt wrote: On Wed, Feb 23, 2011 at 5:03 PM, Gabe Black wrote: Forgive my ignorance here, but why is the limit event set up each time simulate is called? Couldn't it just be a member of the event queue class and always stuck at the end and

Re: [m5-dev] delete at sim exit

2011-02-24 Thread nathan binkert
I'm happy to leave it be and don't want to stand in the way of your code. Do we care about things that aren't pthreads/posix complaint? Seems like every system we're going to run on should have it (because python requires it) and we shouldn't build infrastructure with no purpose (didn't you

Re: [m5-dev] delete at sim exit

2011-02-24 Thread Ali Saidi
On Thu, 24 Feb 2011 11:11:54 -0800, nathan binkert n...@binkert.org wrote: Steve, can you get your stuff in with ifdefs and a compile time option for now? I'm assuming that the pthreads calls are pretty limited and figuring this out later isn't unreasonable. Do we care about systems that

[m5-dev] delete at sim exit

2011-02-23 Thread Ali Saidi
Does anyone know why the limit event isn't deleted and instead it prints be nice to actually delete the event here Why can't we just delete it? Ali ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] delete at sim exit

2011-02-23 Thread nathan binkert
Does anyone know why the limit event isn't deleted and instead it prints be nice to actually delete the event here Why can't we just delete it? That is my fault. I generally don't like allocating stuff without deleting it, so I stuck the warn in there. It could be autodeleted, but we

Re: [m5-dev] delete at sim exit

2011-02-23 Thread Gabe Black
On 02/23/11 17:02, Ali Saidi wrote: On Wed, 23 Feb 2011 16:37:58 -0800, nathan binkert n...@binkert.org wrote: Does anyone know why the limit event isn't deleted and instead it prints be nice to actually delete the event here Why can't we just delete it? That is my fault. I generally

Re: [m5-dev] delete at sim exit

2011-02-23 Thread nathan binkert
Dude, you and Gabe really need to learn to prune the text that you're quoting. I think actually, we're loosing the memory ever time we call simulate() so the simulator doesn't actually need to exit even. If you're returning to python to change something/switch cpus and then simulate again a

Re: [m5-dev] delete at sim exit

2011-02-23 Thread nathan binkert
Prune text! Forgive my ignorance here, but why is the limit event set up each time simulate is called? Couldn't it just be a member of the event queue class and always stuck at the end and left there? Well, it used to be because we only checked a single variable async_event in every iteration

Re: [m5-dev] delete at sim exit

2011-02-23 Thread nathan binkert
For the case with the hack in it now, wouldn't something like rescheduling it to the current tick, and setting auto delete (it seems like there is no method to actually do this though) be better? AutoDelete is a flag.  Just call limit_event.setFlags(AutoDelete); Though you can't make an