Re: [gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3696/#review9071 --- src/mem/page_table.cc (line 110)

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3688/#review9046 --- src/arch/alpha/kernel_stats.cc

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3688/#review9047 --- src/arch/alpha/kernel_stats.cc

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

* build/HSAIL_X86/tests/opt/quick/se/04.gpu/x86/linux/gpu-ruby-GPU_RfO: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing: passed. *

Re: [gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3696/ --- (Updated Nov. 14, 2016, 8:37 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3701: syscall_emul: [PATCH 20/22] add the tgkill system call

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3701/ --- (Updated Nov. 14, 2016, 8:55 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3701: syscall_emul: [PATCH 20/22] add the tgkill system call

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3701/ --- (Updated Nov. 14, 2016, 8:56 p.m.) Review request for Default. Repository: gem5

[gem5-dev] Review Request 3704: style: change NULL to nullptr in syscall files

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3704/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3657: configs: add an option to set the deadlock timeouts for the TCPs and SQCs

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3657/#review9049 --- Ship it! Ship It! - Tony Gutierrez On Nov. 11, 2016, 1:33 p.m., Joe

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3688/#review9048 --- src/arch/alpha/kernel_stats.cc

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/ --- (Updated Nov. 14, 2016, 6:49 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

On Nov. 10, 2016, 10:52 p.m., Brandon Potter wrote: > > Minor issue, otherwise it LGTM, assuming you address Jason's comments as > > well. I'm going to create a separate patch that does this after all of my other patches are applied. I don't want to have to go through each one individually

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

> On Nov. 8, 2016, 4:56 p.m., Jason Lowe-Power wrote: > > src/sim/system.hh, line 543 > > > > > > Can this just be an std::set? This is only used to make sure there > > are no duplicates, right? Why is the std::set

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

On Nov. 10, 2016, 2:52 p.m., Brandon Potter wrote: > > Minor issue, otherwise it LGTM, assuming you address Jason's comments as > > well. > > Brandon Potter wrote: > I'm going to create a separate patch that does this after all of my other > patches are applied. I don't want to have to go

Re: [gem5-dev] Review Request 3680: syscall_emul: [patch 13/22] add system call retry capability

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3680/#review9056 --- This patch looks ok to me, as it seems we're more-or-less implementing

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/#review9052 --- src/sim/futex_map.hh (line 65)

Re: [gem5-dev] Review Request 3703: syscall_emul: [PATCH 22/22] ignore system calls that are unimplemented.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3703/#review9057 --- Ship it! OK with me after you beef up commit message. - Michael

Re: [gem5-dev] Review Request 3701: syscall_emul: [PATCH 20/22] add the tgkill system call

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3701/#review9058 --- src/sim/syscall_emul.hh (line 2043)

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3681/ --- (Updated Nov. 14, 2016, 7:48 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3690: x86, ext: fix buf overflow in fp80 ops; pad fp80_t in fputils

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3690/#review9050 --- Any thoughts? Otherwise I'll ship this soon. - Tony Gutierrez On Nov.

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

> On Nov. 8, 2016, 4:56 p.m., Jason Lowe-Power wrote: > > src/sim/system.hh, line 543 > > > > > > Can this just be an std::set? This is only used to make sure there > > are no duplicates, right? > > Brandon Potter wrote:

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3681/ --- (Updated Nov. 14, 2016, 7:20 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3699: syscall_emul: [PATCH 18/22] refactor and add functionality for dup, dup2, and pipe

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3699/#review9060 --- src/sim/syscall_emul.cc (line 222)

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

> On Nov. 8, 2016, 4:56 p.m., Jason Lowe-Power wrote: > > src/sim/system.hh, line 543 > > > > > > Can this just be an std::set? This is only used to make sure there > > are no duplicates, right? > > Brandon Potter wrote:

Re: [gem5-dev] Review Request 3700: syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3700/ --- (Updated Nov. 14, 2016, 6:56 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3700: syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3700/#review9059 --- Where is this used? src/sim/se_signal.hh (line 39)

Re: [gem5-dev] Review Request 3698: syscall_emul: [PATCH 17/22] refactor and add functionality to open syscall family

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3698/#review9061 --- Ship it! Looks good. Please add a bit more to the commit message saying

Re: [gem5-dev] Status of RISC-V patches

Hi all, Merely a thought when it comes to adding tests: I would suggest we ditch all proprietary/closed-source tests and move in the direction of something that is open and maintained. My proposal would be to adopt a few of the tests from the llvm test suite. There are both very short

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

> On Nov. 14, 2016, 7:19 p.m., Michael LeBeane wrote: > > src/sim/futex_map.hh, line 81 > > > > > > Why not something simple, like: > > > > return std::hash(addr) ^ (std::hash(tgid) << 1) The return value has to be

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/ --- (Updated Nov. 14, 2016, 9:30 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3704: style: change NULL to nullptr in syscall files

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3704/#review9067 --- Ship it! Ship It! - Jason Lowe-Power On Nov. 14, 2016, 9:02 p.m.,

Re: [gem5-dev] Review Request 3704: style: change NULL to nullptr in syscall files

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3704/#review9068 --- Ship it! Ship It! - Tony Gutierrez On Nov. 14, 2016, 1:02 p.m.,

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

> On Nov. 14, 2016, 7:19 p.m., Michael LeBeane wrote: > > src/sim/futex_map.hh, line 81 > > > > > > Why not something simple, like: > > > > return std::hash(addr) ^ (std::hash(tgid) << 1) > > Brandon Potter wrote:

Re: [gem5-dev] Review Request 3680: syscall_emul: [patch 13/22] add system call retry capability

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3680/#review9066 --- I think the commit message could be a bit clearer about the problem this

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3681/ --- (Updated Nov. 14, 2016, 8:33 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3681/#review9064 --- Ship it! Ship It! - Michael LeBeane On Nov. 14, 2016, 7:48 p.m.,

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3681/#review9065 --- Ship it! Thanks for the change! - Jason Lowe-Power On Nov. 14, 2016,