Hello Gabe Black, Jason Lowe-Power, Daniel Carvalho,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/5
to look at the new patch set (#3).
Change subject: base, mem: Disambiguate if an addr range is contained or
overlaps
Hello Jason Lowe-Power, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/10915
to look at the new patch set (#2).
Change subject: scons: Generalize building binaries.
Ok, I'll add you to future reviews. All the existing ones (or at least most
of them) are part of the systemc topic branch on gerrit, so hopefully they
should be pretty easy to find. There are about 50 of them right now I
think, so to avoid lots of tedious clicking around I'll leave the existing
Hello Gabe Black,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/7
to look at the new patch set (#2).
Change subject: mem: Use address range to find the destination port in the
xbar
Hello Jason Lowe-Power, Daniel Carvalho,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/11017
to look at the new patch set (#3).
Change subject: mem-cache: Promote targets that don't require writable
*
build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64c/simple-timing:
FAILED!
* build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64f/o3-timing:
FAILED!
* build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64c/o3-timing:
FAILED!
*
Daniel Carvalho has submitted this change and it was merged. (
https://gem5-review.googlesource.com/11096 )
Change subject: mem-cache: Forward declare ReplaceableEntry
..
mem-cache: Forward declare ReplaceableEntry
Forward
Daniel Carvalho has submitted this change and it was merged. (
https://gem5-review.googlesource.com/11097 )
Change subject: mem-cache: Initialize CacheBlk data pointer
..
mem-cache: Initialize CacheBlk data pointer
Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/11196
to review the following change.
Change subject: arch-arm: BadMode checking if corresponding EL is
implemented
Nikos Nikoleris has submitted this change and it was merged. (
https://gem5-review.googlesource.com/6 )
Change subject: dev-arm: Fix the address range for some I/O devices
..
dev-arm: Fix the address range for some I/O
Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/11197
to review the following change.
Change subject: arch-arm: AArch32 execution triggering AArch64 SW Break
..
> If you also want to be on all the reviews,
> please let me know. I don't want to unilaterally
> bomb people's inboxes if they're not interested.
Wait. I am not sure what you are saying here.
Are you proposing to *add* so Andreas, Jason and
Matthias will receive more emails over those review
Hello Jason Lowe-Power, Nikos Nikoleris,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/11100
to look at the new patch set (#3).
Change subject: mem-cache: Create cache compressor
..
Hello Jason Lowe-Power, Nikos Nikoleris,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/10763
to look at the new patch set (#4).
Change subject: mem-cache: Stub compression framework
Hello Jason Lowe-Power, Nikos Nikoleris,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/11103
to look at the new patch set (#3).
Change subject: mem-cache: Add compression stats
..
Daniel Carvalho has uploaded this change for review. (
https://gem5-review.googlesource.com/11198
Change subject: mem-cache: Data pointer in findVictim and insertBlock
..
mem-cache: Data pointer in findVictim and insertBlock
Hello Jason Lowe-Power, Nikos Nikoleris,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/11104
to look at the new patch set (#3).
Change subject: mem-cache: Create CacheComp debug flag
Hello Jason Lowe-Power, Nikos Nikoleris,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/10762
to look at the new patch set (#3).
Change subject: mem-cache: Return cycles in findVictim
Hello Jason Lowe-Power, Nikos Nikoleris,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/11098
to look at the new patch set (#2).
Change subject: mem-cache: Remove Packet dependency in Tags
Hello Jason Lowe-Power, Nikos Nikoleris,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/11105
to look at the new patch set (#3).
Change subject: mem-cache: Create CPack compressor
..
Hello Jason Lowe-Power, Nikos Nikoleris,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/11102
to look at the new patch set (#3).
Change subject: mem-cache: Add compression bit to CacheBlk
Hi Gabe,
You can use 9p and VirtiIO for this. There is a 9p implementation in
gem5 that uses diod (you'll have to install the diod package).
There is an old, and probably broken, description on the Wiki:
http://gem5.org/WA-gem5
The modern Arm platforms come with two unused VirtIO MMIO devices
Ok, *that's* what I was trying to remember. Thanks.
Gabe
On Fri, Jun 15, 2018 at 10:39 AM Andreas Sandberg
wrote:
> Hi Gabe,
>
> You can use 9p and VirtiIO for this. There is a 9p implementation in
> gem5 that uses diod (you'll have to install the diod package).
>
> There is an old, and
Hey Boris,
I think that gerrit always sends the first message when a patch is uploaded
to the whole list. Then, when adding comments or updating patches gerrit
only sends emails to people that are cc'ed in gerrit. I'm not sure what the
behavior is on merges...
I'm not sure what an easy way to be
Hey Jason, thanks for taking a look. As far as comments go, there aren't
really that many comments in the Accellera implementation either, at least
not doxygen style, per function args, ret style comments. I think for
things which are defined in the spec and/or in systemc books, tutorials,
etc.,
Hello Jason Lowe-Power, Matthias Jung, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/10829
to look at the new patch set (#3).
Change subject: systemc: Add stubbed out versions of sc_port and sc_export.
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11176
Change subject: systemc: Make a test stop including an internal path for
sc_vector.
..
systemc: Make a test stop including an
Hello Jason Lowe-Power, Matthias Jung, Giacomo Travaglini, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/10821
to look at the new patch set (#3).
Change subject: systemc: Add a stubbed out sc_object class.
Hello Jason Lowe-Power, Matthias Jung, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/10824
to look at the new patch set (#3).
Change subject: systemc: Hook up sc_main.
Hello Jason Lowe-Power, Matthias Jung, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/10835
to look at the new patch set (#3).
Change subject: systemc: Seperate the "external" header interface.
Hello Jason Lowe-Power, Matthias Jung, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/10832
to look at the new patch set (#3).
Change subject: systemc: Add a stub implementation for sc_attr related
classes.
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11175
Change subject: systemc: Add some missing enums to the utils _using.hh
..
systemc: Add some missing enums to the utils _using.hh
Hello Jason Lowe-Power, Matthias Jung, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/10841
to look at the new patch set (#3).
Change subject: systemc: Stub out all the standard utilility classes and
functions.
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11179
Change subject: systemc: Remove more Accellera source specific include
paths in tests.
..
systemc: Remove more Accellera source
Hello Jason Lowe-Power, Matthias Jung, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/10834
to look at the new patch set (#3).
Change subject: systemc: Stub out the sc_module class and related functions.
Hello Jason Lowe-Power, Matthias Jung, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/10822
to look at the new patch set (#3).
Change subject: systemc: Add a stub kernel SimObject.
Hello Jason Lowe-Power, Matthias Jung, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/10838
to look at the new patch set (#3).
Change subject: systemc: Add systemc and systemc.h header files.
Hello Jason Lowe-Power, Matthias Jung, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/10839
to look at the new patch set (#3).
Change subject: systemc: Stub out the predefined channels.
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11184
Change subject: systemc: Partially implement SC_FORK and SC_JOIN.
..
systemc: Partially implement SC_FORK and SC_JOIN.
These
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11183
Change subject: systemc: Add some deprecated features to sc_clock.*.
..
systemc: Add some deprecated features to sc_clock.*.
Add
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11186
Change subject: systemc: Add the nonstandard variable
sc_allow_process_control_corners.
..
systemc: Add the nonstandard variable
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11177
Change subject: systemc: Fill out some of the sc_vector.hh classes.
..
systemc: Fill out some of the sc_vector.hh classes.
The
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11185
Change subject: systemc: Add some "implementation defined" stuff to
sc_attr_cltn.
..
systemc: Add some "implementation defined"
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11180
Change subject: systemc: Turn some macros into enums to fix regression test
building.
..
systemc: Turn some macros into enums to
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11178
Change subject: systemc: Include boost/bind.hpp in the systemc header.
..
systemc: Include boost/bind.hpp in the systemc header.
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11182
Change subject: systemc: Add some non-standard sc_trace variants.
..
systemc: Add some non-standard sc_trace variants.
These
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11181
Change subject: systemc: Remove references to internal constants from the
tests.
..
systemc: Remove references to internal
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11187
Change subject: systemc: Add the nonstandard triggered function sc_event.
..
systemc: Add the nonstandard triggered function
Oh, by the way, I've been adding Andreas, Jason and Matthias Jung to all
the systemc reviews I've been posting. I think those folks should
definitely be in the loop, but I don't want to exclude anybody else. If you
also want to be on all the reviews, please let me know. I don't want to
Giacomo Travaglini has uploaded this change for review. (
https://gem5-review.googlesource.com/11195
Change subject: base: Add an asymmetrical Coroutine class
..
base: Add an asymmetrical Coroutine class
This patch is
Giacomo Travaglini has uploaded a new patch set (#4) to the change
originally created by Gabe Black. (
https://gem5-review.googlesource.com/10935 )
Change subject: base: Add a class which encapsulates Fibers.
..
base: Add a
Hi Gabe,
please consider myself interested on reviewing SystemC patches ??
From: gem5-dev on behalf of Gabe Black
Sent: 15 June 2018 09:55:30
To: gem5 Developer List
Subject: Re: [gem5-dev] systemc reviews
Oh, by the way, I've been adding Andreas, Jason and
52 matches
Mail list logo