Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/30240 )
Change subject: ext: Remove dead code from runner.py
......................................................................
ext: Remove dead code from runner.py
This has been tested with vulture:
https://pypi.org/project/vulture
JIRA: https://gem5.atlassian.net/projects/GEM5/issues/GEM5-533
Change-Id: Ic851c3681a40b7e61ee53b81b17df52dc1289e9f
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30240
Maintainer: Bobby R. Bruce <bbr...@ucdavis.edu>
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Hoa Nguyen <hoangu...@ucdavis.edu>
---
M ext/testlib/runner.py
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Hoa Nguyen: Looks good to me, approved
Bobby R. Bruce: Looks good to me, approved
kokoro: Regressions pass
diff --git a/ext/testlib/runner.py b/ext/testlib/runner.py
index 9b09637..7425e79 100644
--- a/ext/testlib/runner.py
+++ b/ext/testlib/runner.py
@@ -39,11 +39,9 @@
# Authors: Sean Wilson
import multiprocessing.dummy
-import threading
import traceback
import testlib.helper as helper
-import testlib.state as state
import testlib.log as log
from testlib.state import Status, Result
@@ -169,9 +167,6 @@
def set_threads(self, threads):
self.threads = threads
- def _entrypoint(self, suite):
- suite.runner(suite).run()
-
def test(self):
pool = multiprocessing.dummy.Pool(self.threads)
pool.map(lambda suite : suite.runner(suite).run(), self.testable)
@@ -181,8 +176,6 @@
class BrokenFixtureException(Exception):
def __init__(self, fixture, testitem, trace):
- self.fixture = fixture
- self.testitem = testitem
self.trace = trace
self.msg = ('%s\n'
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/30240
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic851c3681a40b7e61ee53b81b17df52dc1289e9f
Gerrit-Change-Number: 30240
Gerrit-PatchSet: 4
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Hoa Nguyen <hoangu...@ucdavis.edu>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
