Re: [gem5-dev] Review Request 2462: mem: Page Table map api modification

2014-11-19 Thread Alexandru Dutu via gem5-dev
On Nov. 18, 2014, 4:30 p.m., Andreas Hansson wrote: src/mem/page_table.hh, line 95 http://reviews.gem5.org/r/2462/diff/1/?file=42140#file42140line95 I'd suggest to specify the storage type (uint32_t) Thought it is the only enum that will have an explicit storage type. - Alexandru

Re: [gem5-dev] Review Request 2462: mem: Page Table map api modification

2014-11-19 Thread Alexandru Dutu via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2462/ --- (Updated Nov. 20, 2014, 6:27 a.m.) Review request for Default. Changes ---

Re: [gem5-dev] Review Request 2462: mem: Page Table map api modification

2014-11-19 Thread Andreas Hansson via gem5-dev
On Nov. 18, 2014, 4:30 p.m., Andreas Hansson wrote: src/mem/page_table.hh, line 95 http://reviews.gem5.org/r/2462/diff/1/?file=42140#file42140line95 I'd suggest to specify the storage type (uint32_t) Alexandru Dutu wrote: Thought it is the only enum that will have an

Re: [gem5-dev] Review Request 2462: mem: Page Table map api modification

2014-11-18 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2462/#review5474 --- src/arch/x86/pagetable.hh http://reviews.gem5.org/r/2462/#comment4922