Re: [gem5-dev] Review Request 3493: dev: Add 'simLength' parameter in EthPacketData

[Andreas Sandberg]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3493/#review8921
---

Ship it!


Ship It!

- Andreas Sandberg


On Oct. 12, 2016, 4:50 p.m., Michael LeBeane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3493/
> ---
> 
> (Updated Oct. 12, 2016, 4:50 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11637:cd6bb67002fa
> ---
> dev: Add 'simLength' parameter in EthPacketData
> Currently, all the network devices create a 16K buffer for the 'data' field
> in EthPacketData, and use 'length' to keep track of the size of the packet
> in the buffer.  This patch introduces the 'simLength' parameter to
> EthPacketData, which is used to hold the effective length of the packet used
> for all timing calulations in the simulator.  Serialization is performed using
> only the useful data in the packet ('length') and not necessarily the entire
> original buffer.
> 
> 
> Diffs
> -
> 
>   src/dev/net/i8254xGBe.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/ns_gige.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/pktfifo.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/dist_etherlink.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/dist_iface.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/dist_packet.hh e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/etherbus.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/etherlink.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/etherpkt.hh e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/etherpkt.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/etherswitch.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/ethertap.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/tcp_iface.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/sinic.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
> 
> Diff: http://reviews.gem5.org/r/3493/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael LeBeane
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3493: dev: Add 'simLength' parameter in EthPacketData

[Michael LeBeane]

> On Oct. 3, 2016, 4:27 p.m., Andreas Sandberg wrote:
> > src/dev/net/etherpkt.cc, line 44
> > 
> >
> > I really don't like the way this is breaking checkpoints.
> > 
> > The right thing to do here would be to implement this in a way that 
> > doesn't break checkpoint. The simplest way would probably be to use length 
> > as the name for dataLength. If simLength is present (I'm going to push a 
> > helper function to test for that shortly), you just unserialize the value. 
> > If not, you use a fallback such as simLength = dataLength.
> > 
> > The other option is to provide a checkpoint updater, which is pretty 
> > tricky since you need to find all places where packets are serialized.
> 
> Michael LeBeane wrote:
> The first option sounds reasonable.  Did you push the helper function 
> that tests if something is present in a checkpoint?  I don't think I've seen 
> it in the commit logs recently.
> 
> Andreas Sandberg wrote:
> I committed the helper functions last week 
> (https://github.com/gem5/gem5/commit/18135ce6abc0ee02e36aef424be183cd7238a55).
>  I thought a bit more about this and the optParamIn helper probably 
> implements the functionality you need.

I reposted using your suggestions.  Does this work for you?  Thanks!


- Michael


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3493/#review8763
---


On Oct. 12, 2016, 3:50 p.m., Michael LeBeane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3493/
> ---
> 
> (Updated Oct. 12, 2016, 3:50 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11637:cd6bb67002fa
> ---
> dev: Add 'simLength' parameter in EthPacketData
> Currently, all the network devices create a 16K buffer for the 'data' field
> in EthPacketData, and use 'length' to keep track of the size of the packet
> in the buffer.  This patch introduces the 'simLength' parameter to
> EthPacketData, which is used to hold the effective length of the packet used
> for all timing calulations in the simulator.  Serialization is performed using
> only the useful data in the packet ('length') and not necessarily the entire
> original buffer.
> 
> 
> Diffs
> -
> 
>   src/dev/net/i8254xGBe.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/ns_gige.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/pktfifo.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/dist_etherlink.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/dist_iface.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/dist_packet.hh e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/etherbus.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/etherlink.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/etherpkt.hh e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/etherpkt.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/etherswitch.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/ethertap.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/tcp_iface.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
>   src/dev/net/sinic.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
> 
> Diff: http://reviews.gem5.org/r/3493/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael LeBeane
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3493: dev: Add 'simLength' parameter in EthPacketData

[Michael LeBeane]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3493/
---

(Updated Oct. 12, 2016, 3:50 p.m.)


Review request for Default.


Summary (updated)
-

dev: Add 'simLength' parameter in EthPacketData


Repository: gem5


Description (updated)
---

Changeset 11637:cd6bb67002fa
---
dev: Add 'simLength' parameter in EthPacketData
Currently, all the network devices create a 16K buffer for the 'data' field
in EthPacketData, and use 'length' to keep track of the size of the packet
in the buffer.  This patch introduces the 'simLength' parameter to
EthPacketData, which is used to hold the effective length of the packet used
for all timing calulations in the simulator.  Serialization is performed using
only the useful data in the packet ('length') and not necessarily the entire
original buffer.


Diffs (updated)
-

  src/dev/net/i8254xGBe.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
  src/dev/net/ns_gige.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
  src/dev/net/pktfifo.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
  src/dev/net/dist_etherlink.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
  src/dev/net/dist_iface.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
  src/dev/net/dist_packet.hh e92bf392bf4302e2e88e19907e7fc981f59e777d 
  src/dev/net/etherbus.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
  src/dev/net/etherlink.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
  src/dev/net/etherpkt.hh e92bf392bf4302e2e88e19907e7fc981f59e777d 
  src/dev/net/etherpkt.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
  src/dev/net/etherswitch.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
  src/dev/net/ethertap.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
  src/dev/net/tcp_iface.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 
  src/dev/net/sinic.cc e92bf392bf4302e2e88e19907e7fc981f59e777d 

Diff: http://reviews.gem5.org/r/3493/diff/


Testing
---


Thanks,

Michael LeBeane

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev