Thanks all for the comments and discussions!
The voting for the release of Apache ECharts 4.1.0 (release candidate 3) is
closed.
And a new voting for the release of Apache ECharts 4.1.0 (release candidate
4)
has been initialized in another thread:
https://lists.apache.org/thread.html/4a551cd183a7e
On Wed, May 23, 2018 at 6:16 AM, Greg Stein wrote:
> On Mon, May 21, 2018 at 2:52 AM Justin Mclean
> wrote:
>>... Do people think it OK to include minified JS in a source release if:
>> 1. It's ASF developed code and the full unminified source code is included
>> as well.
>>
> Absolutely...
Same
On Wed, May 23, 2018 at 12:16 AM Greg Stein wrote:
> On Mon, May 21, 2018 at 2:52 AM Justin Mclean
> wrote:
>
> > Hi,
> >
> > > Javascript code that is minified or combined in any major way is much
> > more
> > > like binary code in that respect. It is true that somebody *could*
> > inspect
> >
On Mon, May 21, 2018 at 2:52 AM Justin Mclean
wrote:
> Hi,
>
> > Javascript code that is minified or combined in any major way is much
> more
> > like binary code in that respect. It is true that somebody *could*
> inspect
> > the correlation, but it is not true that this inspection is either
> n
On Mon, May 21, 2018 at 4:22 PM, Ted Dunning wrote:
> On Mon, May 21, 2018, 21:12 Justin Mclean
> wrote:
>
> > Hi,
> >
> > > Why does this need to be included at all? Why not just provide a
> pointer
> > to
> > > the canonical minified version?
> >
> > Most common occurrence (off the top of my h
On Mon, May 21, 2018, 21:12 Justin Mclean wrote:
> Hi,
>
> > Why does this need to be included at all? Why not just provide a pointer
> to
> > the canonical minified version?
>
> Most common occurrence (off the top of my head) is a minified version of
> bootstrap for project site / documentations
Hi,
> Why does this need to be included at all? Why not just provide a pointer to
> the canonical minified version?
Most common occurrence (off the top of my head) is a minified version of
bootstrap for project site / documentations. So your view is that that
shouldn’t be included in a source r
Mike and Ted, thanks a lot for your detailed explanation!
I've been gradually understanding the way that the community thinks
about the "release". And I will fix the artifact soon.
Thanks,
Shuang
--
Su Shuang (100pah)
--
2018-05-21 14:
On Mon, May 21, 2018 at 12:52 AM, Justin Mclean
wrote:
> Hi,
>
> > Javascript code that is minified or combined in any major way is much
> more
> > like binary code in that respect. It is true that somebody *could*
> inspect
> > the correlation, but it is not true that this inspection is either
>
Hi,
> Javascript code that is minified or combined in any major way is much more
> like binary code in that respect. It is true that somebody *could* inspect
> the correlation, but it is not true that this inspection is either normally
> done or easily done.
Thanks Ted I’ve not thought of it in t
The general meaning of source code is that it is the artifact that people
will edit and which they can inspect by normal textual or graphical means
to ensure that there are no surprises.
Javascript code that is minified or combined in any major way is much more
like binary code in that respect. It
On Sun, May 20, 2018 at 10:07 PM, SHUANG SU wrote:
> Thanks, Justin,
>
> I think I should remove the jar about rat from the artifact, and then
> there is no binary code anymore.
>
> But I am puzzled about the definition of the term "compiled code".
> Generally, the JavaScript code does not need t
Thanks, Justin,
I think I should remove the jar about rat from the artifact, and then there
is no binary code anymore.
But I am puzzled about the definition of the term "compiled code".
Generally, the JavaScript code does not need to be compiled to binary.
The code in "dist/**" is also JavaScript
Hi,
Releases at the ASF must not contain compiled code. You can if you want
also produce a conviance binary for users at the same time but the source
release needs to contain no compiled code otherwise it's not open source.
Thanks,
Justin
On Mon., 21 May 2018, 7:10 am SHUANG SU, wrote:
> Thank
Thanks, Willem.
But I will explain the reason that provides an all-in-one artifact.
I understand that one of the reasons for separating src and binary files
is that in some project the compilation is depending on the target runtime
environment and thus the products cannot be enumerated completely
If the release candidate isn't correct for the artifacts you need to roll
an rc4 which might be two files not one and send that for a vote.
On Sat, May 19, 2018, 22:34 Willem Jiang wrote:
> Hi,
>
> As there is only one zip file, I guess it just the src distribution.
> But after went through the
Hi,
As there is only one zip file, I guess it just the src distribution.
But after went through the file, I found lot of echart js files in the dist
directory and the rat jar.
So I'm confused what's the purpose of apache-echarts-4.1.0.rc3-
incubating.zip
Normally we distribute the src and binary
John,
(1) The included jar file of license check tool (Rat) is for developers'
convenience.
Basically, the infrastructure about building, checking and releasing of the
ECharts is based on
Node.js, thus it is not convenient for the developers and users to find and
install Java-based
tool (Rat) to c
Shuang,
Apologies for my late reply.
Only issue I see is the inclusion of compiled code in the source release. It's
generally expected to not have class files, jars in the source release. We
have good faith on what is included, but no way to confirm. Also, since you
now include RAT in the d
BTW:
>From the Apache Echarts (incubating) 4.1.0.rc1 to 4.1.0.rc3,
the license of source code files has been added, including the
licenses of the third-party libs, and the Apache Rat has been
executed against the project.
--
Su Shuang (100pah)
---
I am pleased to be calling this vote for the release of Apache ECharts
4.1.0.rc3.
Apache ECharts community has voted and approved the release.
Vote thread:
https://lists.apache.org/thread.html/67dffef28ecffd66689ac991ca027c0868d734629949d958e7b12dd3@%3Cdev.echarts.apache.org%3E
Results thread:
h
21 matches
Mail list logo
