Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-23 Thread Jaroslav Tulach
2017-10-21 14:06 GMT+02:00 Mark Struberg : > +1 IPMC binding > > LICENSE, NOTICE, rat, dependencies, signing, etc all looks good. > > However when building it from the distribution zip on my macbook with > java8 144 I sometimes get test errors. > All of them in

Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-23 Thread Jaroslav Tulach
2017-10-23 8:32 GMT+02:00 Ate Douma : > +1 (binding) > > One improvement to consider for the next release is appending the > license for Knockout (MIT) to the embedded LICENSE in the build ko4j > jar artifact, as is required for distributing this artifact. > I see. Good

Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-23 Thread Ate Douma
+1 (binding) One improvement to consider for the next release is appending the license for Knockout (MIT) to the embedded LICENSE in the build ko4j jar artifact, as is required for distributing this artifact. And another is maybe generating a more explicit artifact name for ko4j. Thanks, Ate

Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-22 Thread sebb
On 22 October 2017 at 17:53, Mark Struberg wrote: > Hmm, well, but that usually only happens if it is clear that the vote should > get cancelled. Isn't that what I wrote? > LieGrue, > strub > >> Am 22.10.2017 um 15:29 schrieb sebb : >> >> On 21

Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-22 Thread Mark Struberg
Hmm, well, but that usually only happens if it is clear that the vote should get cancelled. LieGrue, strub > Am 22.10.2017 um 15:29 schrieb sebb : > > On 21 October 2017 at 18:27, Mark Struberg wrote: >>> Even though there is no >>> veto vote on

Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-22 Thread sebb
On 21 October 2017 at 18:27, Mark Struberg wrote: >> Even though there is no >> veto vote on releases, if someone raised a valid issue, the group might >> postpone a release as well, even after +1s. > > > Yes indeed. Sometimes a single person discovers a problem during

Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-21 Thread Mark Struberg
> Even though there is no > veto vote on releases, if someone raised a valid issue, the group might > postpone a release as well, even after +1s. Yes indeed. Sometimes a single person discovers a problem during the voting process and casts -1. A -1 always should come with good arguments.

Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-21 Thread Mark Struberg
Hi Geertjan After the 72h is up you need 3 more (binding) +1 than (binding) -1. By having 0x -1 and 3x +1 the vote does pass _right now_. But of course we have to wait till the 72h are over ;) Looks very promising though. LieGrue, strub > Am 21.10.2017 um 14:55 schrieb Geertjan Wielenga >

Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-21 Thread Wade Chandler
https://www.apache.org/foundation/voting.html https://www.apache.org/foundation/voting.html#ReleaseVotes It is technically both with nuances. Time and 3 binding +1s plus a majority +1s. The 72 hours is a participation enabler. The 3 bindings is the minimum required, but a majority -1s would be a

Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-21 Thread Wade Chandler
+1 On Oct 21, 2017 08:07, "Mark Struberg" wrote: > +1 IPMC binding > > LICENSE, NOTICE, rat, dependencies, signing, etc all looks good. > > However when building it from the distribution zip on my macbook with > java8 144 I sometimes get test errors. > All of them in

Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-21 Thread Geertjan Wielenga
Many thanks -- so, right now, Bertrand, John, and Mark have done binding votes -- i.e., two of our mentors and the VP Incubator. How many binding votes are needed or is it simply a question of time, i.e., at the time that the vote expires, if there's no -1, and only +1 binding votes, then the

Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-21 Thread Mark Struberg
+1 IPMC binding LICENSE, NOTICE, rat, dependencies, signing, etc all looks good. However when building it from the distribution zip on my macbook with java8 144 I sometimes get test errors. All of them in knockout.js, but each time something different: Configuring TestNG with:

Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-21 Thread John D. Ament
Here's my +1 to release. On Thu, Oct 19, 2017 at 8:43 AM Bertrand Delacretaz < bdelacre...@codeconsult.ch> wrote: > On Thu, Oct 19, 2017 at 2:17 PM, Jaroslav Tulach > wrote: > > ...I'd like to ask you to hold the Incubator > > PMC vote to release:.. > > Here's my +1

Re: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-10-19 Thread Bertrand Delacretaz
On Thu, Oct 19, 2017 at 2:17 PM, Jaroslav Tulach wrote: > ...I'd like to ask you to hold the Incubator > PMC vote to release:.. Here's my +1 repeated from the podling list for SHA1(incubating-netbeans-html4j-1.5.zip)= fd77975f1adbcbc4b926e1cfab6865f47db6df3c