Hi,
> If you look at these NOTICE files: for Hadoop, it is still dated 2006;
> Spark is dated 2014;
Spark and Hadoop license and notice files, are for a a number of reasons. poor
examples to copy, please don’t copy what they do.
Thanks,
Justin
Hi,
> It is my understanding that if a file has not been substantially changed,
> that it is not necessary to change the year on a Copyright notice every
> time the year rolls over.
INAL but under US law my understanding is:
- The copyright notice contains the word copyright or the symbol, the
IANAL, but I think for an individual file your analysis is correct, i.e. no
change required if no substantive change to the file.
For the NOTICE file, my understanding is that it represents a summary for
the entire release, so best to change.
I don't have a definitive reference to give you though
Paul,
WRT the year bump on Copyright notices.
It is my understanding that if a file has not been substantially changed,
that it is not necessary to change the year on a Copyright notice every
time the year rolls over.
As for the NOTICE file, it has not changed at all. So it should not be
Paul, If I am reading your error message correctly, it is finding a ":"
character in your file path somewhere. This is a "reserved" character for
file names and for Java cannot appear in the path. (
https://en.wikipedia.org/wiki/Filename).
So I'm not sure how to advise you to fix it.
Lee.
On
Paul,
None of us on our team use Windows (we don't even have any Windows machines
around! ) so thank you for finding this.
Could you please send me the stack trace that you got with this error?
Thanks.
Lee.
On Sat, Jan 25, 2020 at 3:19 PM Paul King wrote:
> +1 (binding) with one minor comment
+1 (binding) with one minor comment
Checked:
* incubating in name
* DISCLAIMER-WIP exists
* LICENSE
* NOTICE (year bump needed 2019 => 2019-2020 as already noted by Justin)
* no unexpected binary files
* signatures
* hash
* mvn clean install (1)
* mvn apache-rat:check
(1) Works on Linux. On
Hello IPMC,
This is a gentle reminder that we need one more IPMC member to vote on this
thread. We have one more day to go :)
Thanks,
Lee.
On Thu, Jan 23, 2020 at 2:15 AM Furkan KAMACI
wrote:
> Hi,
>
> +1 from me (binding, carrying over my vote).
>
> I checked:
>
> - Incubating in name
> -
Hi,
+1 from me (binding, carrying over my vote).
I checked:
- Incubating in name
- DISCLAIMER-WIP exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked Checksums
- Code compiles and tests successfully run
Kind Regards,
Furkan KAMACI
On Thu, Jan
Hi,
+1 (binding)
I checked:
- incubating in name
- signatures and hashes are fine
- DISCLAIMER exists
- LICENSE fine
- NOTICE need year updating
- No unpacked binary files
- All source files have ASF headers
- Can compile from source
There's a couple of very minor things I noticed (links to
10 matches
Mail list logo
