Re: [VOTE] Release Apache Fineract 0.6.0 (incubating)

2017-01-17 Thread Nazeer Shaik
Thank you John. On Tue, Jan 17, 2017 at 5:26 PM, John D. Ament wrote: > Yes, please treat my vote as a +1 :-) > > On Tue, Jan 17, 2017 at 4:42 AM Nazeer Shaik < > nazeer.sh...@confluxtechnologies.com> wrote: > > > Hi John, > > > > As you suggested we have closed the issue

Re: [VOTE] Release Apache Fineract 0.6.0 (incubating)

2017-01-17 Thread John D. Ament
Yes, please treat my vote as a +1 :-) On Tue, Jan 17, 2017 at 4:42 AM Nazeer Shaik < nazeer.sh...@confluxtechnologies.com> wrote: > Hi John, > > As you suggested we have closed the issue https://issues.apache.org/ > jira/browse/FINERACT-357 >

Re: [VOTE] Release Apache Fineract 0.6.0 (incubating)

2017-01-17 Thread Nazeer Shaik
Hi John, As you suggested we have closed the issue https://issues.apache.org/ jira/browse/FINERACT-357 and created two separate issues to address remaining 2 suggestions/reviews. https://issues.apache.org/jira/browse/FINERACT-371 https://issues.apache.org/jira/browse/FINERACT-368 With this

Re: [VOTE] Release Apache Fineract 0.6.0 (incubating)

2017-01-12 Thread Jim Jagielski
+1. Thx! > On Jan 12, 2017, at 7:36 AM, Nazeer Shaik wrote: > > Hi John, > > We have closed the Jira issue > https://issues.apache.org/jira/browse/FINERACT-357 and created two separate > jira issues for remaining two items.RAT is integrated such a way it will > check

Re: [VOTE] Release Apache Fineract 0.6.0 (incubating)

2017-01-12 Thread Nazeer Shaik
Hi John, We have closed the Jira issue https://issues.apache.org/jira/browse/FINERACT-357 and created two separate jira issues for remaining two items.RAT is integrated such a way it will check all directories and files from top level directory. So nothing will be missed. Thanks, Nazeer On Thu,

Re: [VOTE] Release Apache Fineract 0.6.0 (incubating)

2017-01-12 Thread Justin Mclean
Hi, > My struggle is that you have a build directory in one of the child dirs. > There is no top level build - as a result, there's no easy way to run rat > from the root. This means that there are a number of files not easily > verified. Yep it’s a little less than ideal and may mean that the

Re: [VOTE] Release Apache Fineract 0.6.0 (incubating)

2017-01-12 Thread John D. Ament
On Thu, Jan 12, 2017 at 2:23 AM Nazeer Shaik wrote: > Hi John, > > Thank you for reviewing this release. > > 1) I have kept https://issues.apache.org/jira/browse/FINERACT-357 open as > we have addressed 4 out of 6 suggestions given for 0.5.0-incubating > release. Other

Re: [VOTE] Release Apache Fineract 0.6.0 (incubating)

2017-01-12 Thread Nazeer Shaik
Thank you Justin reviewing the release. We will add suggested details in readme file. Let me discuss with Fineract mentors about spring boot version. Thanks, Nazeer On Thu, Jan 12, 2017 at 1:42 PM, Justin Mclean wrote: > Hi, > > +1 binding > > I can see that most items

Re: [VOTE] Release Apache Fineract 0.6.0 (incubating)

2017-01-12 Thread Myrle Krantz
On Thu, Jan 12, 2017 at 3:58 AM, John D. Ament wrote: > Nazeer, > > Sorry but -1. There was a ticket raised to address release issues in the > prior release vote. The IPMC typically looks to see those release issue > tickets reolved in the following release. > >

Re: [VOTE] Release Apache Fineract 0.6.0 (incubating)

2017-01-12 Thread Justin Mclean
Hi, +1 binding I can see that most items in the JIRA ticket have been fixed (ie adding jQuery) to LICENSE it’s just not been closed. I checked: - name contains incubating - disclaimer exists - signatures and hash correct - NOTICE good (but year needs updating) - LICENSE is good - Source files

Re: [VOTE] Release Apache Fineract 0.6.0 (incubating)

2017-01-11 Thread Nazeer Shaik
Hi John, Thank you for reviewing this release. 1) I have kept https://issues.apache.org/jira/browse/FINERACT-357 open as we have addressed 4 out of 6 suggestions given for 0.5.0-incubating release. Other two will be addressed in next/future releases. I have added these details in note section of

Re: [VOTE] Release Apache Fineract 0.6.0 (incubating)

2017-01-11 Thread John D. Ament
Nazeer, Sorry but -1. There was a ticket raised to address release issues in the prior release vote. The IPMC typically looks to see those release issue tickets reolved in the following release. https://issues.apache.org/jira/browse/FINERACT-357 was not resolved in this release. Can you