Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Justin, 2018-02-06 22:07 GMT+09:00 Justin Mclean : > Hi, > >> Update the NOTICE file. >> https://github.com/apache/incubator-hivemall/blob/v0.5.0/NOTICE > > Look there is obvious a disconnect here and you are not understanding what > isand required in regard with licensing

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi, > Update the NOTICE file. > https://github.com/apache/incubator-hivemall/blob/v0.5.0/NOTICE Look there is obvious a disconnect here and you are not understanding what isand required in regard with licensing and ASF policy. That's OK as incubating project, it's hard to understand and hard

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi Justin, 2018-02-06 17:53 GMT+09:00 Justin Mclean : > Hi, > >> To clear discussion, the missing license body is specifically for >> https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L315 > > Again please carefully read [1] to comply you need to include a

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi, Yep looks like you are including Font Awesome 4.6.3 not 5. [1] A good reason to put the exact version of the 3rd party software somewhere so you know which license applies. Thanks, Justin 1.

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi, Sorry links got removed for some reason. Again please read [1] and check the CC-BY license [2][, you may also want to read [3] re CC-BY which may be an issue here. However it's not clear what version of font awesome you are including the links provided refer to version 5 which is under

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi, > To clear discussion, the missing license body is specifically for > https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L315 Again please carefully read [1] to comply you need to include a pointer to the full text of the license not a URL. If you need to download the license

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi Justin, Thank you for your reply. 2018-02-06 16:12 GMT+09:00 Justin Mclean : > Note the mix of public and private lists (as I’m replying to where it was > sent). CC'd private@ to notify discussion to our project mentors. Changed to dev@ > From a quick look: > - In

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi, > I'm wondering how to fix the license headers of modified codes. See points 3 to 5 of [1] so unless major changes have been made it best to keep the original header and not add an ASF one. Points 1 and 2 are sort of important as well :-) Thanks, Justin 1.

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi, Note the mix of public and private lists (as I’m replying to where it was sent). However I think this should be discussed on dev@hivemall not private@. > I'm revising LICENSE and NOTICE files following your comments and [D]. > >

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

2018-02-06 15:49 GMT+09:00 Makoto Yui : > https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L205 > (copyrights are removed from LICENSE) > https://github.com/apache/incubator-hivemall/blob/v0.5.0/NOTICE Let me correct. LICENSE information is removed from NOTICE.

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi Justin, I'm revising LICENSE and NOTICE files following your comments and [D]. https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L205 (copyrights are removed from LICENSE) https://github.com/apache/incubator-hivemall/blob/v0.5.0/NOTICE Does it seem okey for you? [D] says

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi, >> IMO, adding license information along with copyrights in NOTICE sounds >> reasonable because comparing LICENSE with NOTICE is hard when divided >> while it may be redundant. > > In general only LICENSE should contain license information [1] as the NOTICE > file is informational only [2],

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi, > IMO, adding license information along with copyrights in NOTICE sounds > reasonable because comparing LICENSE with NOTICE is hard when divided > while it may be redundant. In general only LICENSE should contain license information [1] as the NOTICE file is informational only [2], (see d.

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

On 30 January 2018 at 03:02, Makoto Yui wrote: > Justin, > > 2018-01-30 11:33 GMT+09:00 Justin Mclean : >> You should be careful following other TLPs as examples and follow the >> instructions here. [1] If you want some good example that the HTTP project >>

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Justin, 2018-01-30 11:33 GMT+09:00 Justin Mclean : > You should be careful following other TLPs as examples and follow the > instructions here. [1] If you want some good example that the HTTP project or > TomCat are I believe good ones to follow. That or perhaps more

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi, > I used NOTICE file of Hadoop/Spark project as a reference. You should be careful following other TLPs as examples and follow the instructions here. [1] If you want some good example that the HTTP project or TomCat are I believe good ones to follow. That or perhaps more recently

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi Justin, Thank you for a careful verification. [1] is not used anymore and should be removed. I'll discuss with PPMC members about LICENSE/NOTICE file format. I'll add appendix to LICENSE file about other license headers. I used NOTICE file of Hadoop/Spark project as a reference.

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Hi, Sorry it -1 from me as there is compiled code in the sure release. [1] I checked: - incubating in name - signatures and hashes fine - DISCLAIMER exists - LICENSE is missing several things including the licence appendix and licenses of included software [2] - NOTICE has some issues - File