Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread Justin Mclean
Hi, There are several files missing license headers - is this a concern? ./dev/phoenix.importorder ./examples/STOCK_SYMBOL.csv ./examples/WEB_STAT.csv ./examples/pig/test.pig ./examples/pig/testdata ./phoenix-core/src/main/resources/java.sql.Driver (ignoring CHANGES and rat.txt

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread James Taylor
Thanks for all the feedback. We'll spin up another RC shortly for our 3.0 and 4.0 release with the corrections to our NOTICE and LICENSE files, along with ensuring that our source release matches the source bundle exactly. One question: given that we'll indicate the bundled products and their

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread James Taylor
Below is our updated NOTICE (which includes the copyright for the bundled bits) and LICENSE (minus the standard Apache 2.0 part). Would appreciate a review. Thanks, James * NOTICE ** Apache Phoenix (Incubating) Copyright 2014 The Apache Software

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread Marvin Humphrey
On Wed, Mar 26, 2014 at 12:59 PM, James Taylor jamestay...@apache.org wrote: Below is our updated NOTICE (which includes the copyright for the bundled bits) and LICENSE (minus the standard Apache 2.0 part). Would appreciate a review. What follows is a superficial review of what I see in this

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread James Taylor
Thanks, Marvin. So remove the copyrights from NOTICE. Are they required anywhere then, as their not in the LICENSE file? On Wed, Mar 26, 2014 at 2:57 PM, Marvin Humphrey mar...@rectangular.comwrote: On Wed, Mar 26, 2014 at 12:59 PM, James Taylor jamestay...@apache.org wrote: Below is our

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread James Taylor
Marvin - The one example in that email thread (airavata), has a bunch of copyright notices in there NOTICE file: https://github.com/apache/airavata/blob/master/modules/distribution/airavata-server/src/main/resources/NOTICE Is that correct or incorrect? I think the reason this comes up a lot is

[DISCUSS] Where does copyright information go for a binary distribution?

2014-03-26 Thread James Taylor
Hello, I'm getting a release ready for Apache Phoenix (incubating) and have a question about where copyright information should go for our binary distribution. It seems that there's quite a bit of variation, as all projects are different. So I'll describe our binary distribution, and perhaps

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread sebb
On 26 March 2014 22:45, James Taylor jamestay...@apache.org wrote: Marvin - The one example in that email thread (airavata), has a bunch of copyright notices in there NOTICE file: https://github.com/apache/airavata/blob/master/modules/distribution/airavata-server/src/main/resources/NOTICE Is

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread sebb
On 26 March 2014 19:59, James Taylor jamestay...@apache.org wrote: Below is our updated NOTICE (which includes the copyright for the bundled bits) and LICENSE (minus the standard Apache 2.0 part). Would appreciate a review. Thanks, James * NOTICE

Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1

2014-03-26 Thread James Taylor
Thanks, Sebb. I added the version info and the copyright to the LICENSE file and based on feedback from Marvin removed the copyright info from our NOTICE file. See this thread:

Re: [DISCUSS] Where does copyright information go for a binary distribution?

2014-03-26 Thread sebb
On 26 March 2014 23:55, James Taylor jamestay...@apache.org wrote: Hello, I'm getting a release ready for Apache Phoenix (incubating) and have a question about where copyright information should go for our binary distribution. It seems that there's quite a bit of variation, as all projects

Re: [DISCUSS] Where does copyright information go for a binary distribution?

2014-03-26 Thread James Taylor
Where does the copyright information go in our case? On Wed, Mar 26, 2014 at 5:48 PM, sebb seb...@gmail.com wrote: On 26 March 2014 23:55, James Taylor jamestay...@apache.org wrote: Hello, I'm getting a release ready for Apache Phoenix (incubating) and have a question about where

Re: [DISCUSS] Where does copyright information go for a binary distribution?

2014-03-26 Thread sebb
On 27 March 2014 00:52, James Taylor jamestay...@apache.org wrote: Where does the copyright information go in our case? What copyright information? Where was it originally? On Wed, Mar 26, 2014 at 5:48 PM, sebb seb...@gmail.com wrote: On 26 March 2014 23:55, James Taylor

Re: [DISCUSS] Where does copyright information go for a binary distribution?

2014-03-26 Thread James Taylor
The copyright for the bits we're bundling. See the LICENSE file I included at the end of my email. For example: Guava, version 12.0.1, http://code.google.com/p/guava-libraries/ Copyright 2008 Google Inc. Is that the correct way to include the Copyright? Or is this not required? Also, how do I

Re: [DISCUSS] Where does copyright information go for a binary distribution?

2014-03-26 Thread Alex Harui
Hi James, Welcome to Apache. I wish I could help more, but I mainly wanted to thank you for going through all of this effort to get these files right. I'm learning a lot from this thread, and I am as confused about the right answer as you are. But here's my guess: You are going to create a