Re: [RESULT][VOTE] Graduate Apache ECharts as TLP (round 2)
Congratulations!! I'm so excited to see this happen! On Tue, Dec 1, 2020 at 2:17 PM Ovilia wrote: > Hi everyone, > > The vote [1] passes with 10 +1 (binding) votes, 1 0 votes, and no -1 votes. > > Binding Votes: > > +1 votes: 10 > Sheng Wu > Willem Jiang > vongosling > Liu Ted > Duo Zhang > Kevin Ratnasekera > Tianqi Chen > Furkan KAMACI > Dave Fisher > Kevin A. McGrail > > 0 votes: 1 > Justin Mclean > > -1: 0 > none > > The vote is successful. > Thanks everyone voted! > > [1] > > https://lists.apache.org/thread.html/r3021c99905a63f0289195f4568360afc4a46eb06eeb5d123379c91b8%40%3Cgeneral.incubator.apache.org%3E > > Thanks > > *Ovilia* > -- Yi Shen Apache ECharts(incubating) PPMC
[ANNOUNCE] Release Apache ECharts (incubating) 4.9.0
Hi all, The Apache ECharts (incubating) team is proud to announce Apache ECharts version 4.9.0-incubating. ECharts is a powerful, interactive charting and visualization library. Download Links: https://dist.apache.org/repos/dist/release/incubator/echarts/4.9.0/ Release Notes: http://www.apache.org/dist/incubator/echarts/4.9.0/RELEASE_NOTE.txt Website: http://echarts.apache.org/ ECharts Resources: - Issue: https://github.com/apache/incubator-echarts/issues - Build Guide: https://github.com/apache/incubator-echarts/blob/4.9.0/README.md - Mailing list: d...@echarts.incubator.apache.org Regards. -- Yi Shen Apache ECharts(incubating) PPMC
[RESULT] [VOTE] Release Apache ECharts (incubating) 4.9.0
Thanks to all who voted or provided comments! The release has PASSED with the following IPMC votes: +1 Dave Fisher (binding) +1 Sheng Wu (binding) +1 Felix Cheung (binding) Vote thread: https://lists.apache.org/thread.html/rd34bcfae1b2f2045b4d647e199d40535b62dbdfaaa53fb75cfce8f90%40%3Cgeneral.incubator.apache.org%3E I'm going to release the source release of Apache ECharts (incubating) 4.9.0. Regards -- Yi Shen Apache ECharts(incubating) PPMC
Re: [VOTE] Release Apache ECharts (incubating) 4.9.0 (release candidate 1)
Thanks for the votes! On Wed, Aug 26, 2020 at 2:58 PM Felix Cheung wrote: > +1 binding > > - incubating in name > - signature and hash are fine > - tarball (see note) > the file unpacks into the current and not a subdirectory, is a bit strange > - DISCLAIMER is fine > - LICENSE and NOTICE are fine > - No unexpected binary files > - All source files have ASF headers > - build from source > > > > On Tue, Aug 25, 2020 at 7:50 PM Sheng Wu > wrote: > > > +1 binding > > > > > > > > 1. incubating in name > > > > 2. download link correct > > > > 3. LICENSE, NOTICE and DISCLAIMER exist > > > > 4. ASC checked > > > > 5. sha512 exists. > > > > > > > > Good luck. > > > > > > > > Sheng Wu 吴晟 > > > > Twitter, wusheng1108 > > > > > > > > > > > > Yi Shen 于2020年8月24日周一 下午5:21写道： > > > > > > > > > Thanks, Dave. > > > > > > > > > > We still need 2 more votes. > > > > > > > > > > Thanks a lot. > > > > > > > > > > On Wed, Aug 19, 2020 at 2:19 AM Dave Fisher wrote: > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > Incubating in name > > > > > > Verified signature and checksum > > > > > > LICENSE checked > > > > > > NOTICE checked > > > > > > DISCLAIMER checked > > > > > > Rat Check passed > > > > > > > > > > > > Regards, > > > > > > Dave > > > > > > > > > > > > > On Aug 9, 2020, at 8:57 PM, Yi Shen wrote: > > > > > > > > > > > > > > Dear IPMC > > > > > > > > > > > > > > I am pleased to be calling this vote for the release of Apache > > ECharts > > > > > > > (incubating) 4.9.0 (release candidate 1). > > > > > > > > > > > > > > Apache ECharts community has voted and approved the release. > > > > > > > > > > > > > > Vote thread: > > > > > > > > > > > > > > > > > > > > > https://lists.apache.org/thread.html/r67639d86c9b5944b1804fca86939052978df9594b45bc0d6474b9fb6%40%3Cdev.echarts.apache.org%3E > > > > > > > > > > > > > > Results thread: > > > > > > > > > > > > > > > > > > > > > https://lists.apache.org/thread.html/rd9b5170f1f1bdda97c502aa4435650f86ec2ce14cd372ed3d548ce24%40%3Cdev.echarts.apache.org%3E > > > > > > > > > > > > > > The release candidate to be voted over is available at: > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.9.0-rc.1/ > > > > > > > > > > > > > > The release candidate is signed with a GPG key available at: > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > > > > > > > > > > > The Git commit for this release is: > > > > > > > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=90243fc > > > > > > > > > > > > > > The Release Note is available in: > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.9.0-rc.1/RELEASE_NOTE.txt > > > > > > > > > > > > > > Build Guide: > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-echarts/blob/4.9.0-rc.1/README.md#build > > > > > > > > > > > > > > Please vote on releasing this package as: > > > > > > > Apache ECharts (incubating) 4.9.0 (release candidate 1) > > > > > > > by "2020-08-13T05:00:00.000Z". > > > > > > > > > > > > > > [ ] +1 Release this package > > > > > > > [ ] 0 I don't feel strongly about it, but don't object > > > > > > > [ ] -1 Do not release this package because... > > > > > > > > > > > > > > Anyone can participate in testing and voting, not just committers, > > > > > please > > > > > > > feel free to try out the release candidate and provide your votes. > > > > > > > > > > > > > > A checklist for reference: > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > -- > > > > > > > Yi Shen > > > > > > > Apache ECharts(incubating) PPMC > > > > > > > > > > > > > > > > > > - > > > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Yi Shen > > > > > Apache ECharts(incubating) PPMC > > > > > > > > > > -- Yi Shen Apache ECharts(incubating) PPMC
Re: [VOTE] Release Apache ECharts (incubating) 4.9.0 (release candidate 1)
Thanks, Dave. We still need 2 more votes. Thanks a lot. On Wed, Aug 19, 2020 at 2:19 AM Dave Fisher wrote: > +1 (binding) > > Incubating in name > Verified signature and checksum > LICENSE checked > NOTICE checked > DISCLAIMER checked > Rat Check passed > > Regards, > Dave > > > On Aug 9, 2020, at 8:57 PM, Yi Shen wrote: > > > > Dear IPMC > > > > I am pleased to be calling this vote for the release of Apache ECharts > > (incubating) 4.9.0 (release candidate 1). > > > > Apache ECharts community has voted and approved the release. > > > > Vote thread: > > > https://lists.apache.org/thread.html/r67639d86c9b5944b1804fca86939052978df9594b45bc0d6474b9fb6%40%3Cdev.echarts.apache.org%3E > > > > Results thread: > > > https://lists.apache.org/thread.html/rd9b5170f1f1bdda97c502aa4435650f86ec2ce14cd372ed3d548ce24%40%3Cdev.echarts.apache.org%3E > > > > The release candidate to be voted over is available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.9.0-rc.1/ > > > > The release candidate is signed with a GPG key available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > The Git commit for this release is: > > > https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=90243fc > > > > The Release Note is available in: > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.9.0-rc.1/RELEASE_NOTE.txt > > > > Build Guide: > > > https://github.com/apache/incubator-echarts/blob/4.9.0-rc.1/README.md#build > > > > Please vote on releasing this package as: > > Apache ECharts (incubating) 4.9.0 (release candidate 1) > > by "2020-08-13T05:00:00.000Z". > > > > [ ] +1 Release this package > > [ ] 0 I don't feel strongly about it, but don't object > > [ ] -1 Do not release this package because... > > > > Anyone can participate in testing and voting, not just committers, please > > feel free to try out the release candidate and provide your votes. > > > > A checklist for reference: > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > Thanks > > > > -- > > Yi Shen > > Apache ECharts(incubating) PPMC > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Yi Shen Apache ECharts(incubating) PPMC
Re: [VOTE] Release Apache ECharts (incubating) 4.9.0 (release candidate 1)
Hi IPMC, Please help us vote for the release. We still need 3 binding votes. Many thanks! On Fri, Aug 14, 2020 at 10:52 AM Yi Shen wrote: > We still need 3 binding votes on this release. Can anyone help vote? > > Thanks! > > On Mon, Aug 10, 2020 at 11:57 AM Yi Shen wrote: > >> Dear IPMC >> >> I am pleased to be calling this vote for the release of Apache ECharts >> (incubating) 4.9.0 (release candidate 1). >> >> Apache ECharts community has voted and approved the release. >> >> Vote thread: >> >> https://lists.apache.org/thread.html/r67639d86c9b5944b1804fca86939052978df9594b45bc0d6474b9fb6%40%3Cdev.echarts.apache.org%3E >> >> Results thread: >> >> https://lists.apache.org/thread.html/rd9b5170f1f1bdda97c502aa4435650f86ec2ce14cd372ed3d548ce24%40%3Cdev.echarts.apache.org%3E >> >> The release candidate to be voted over is available at: >> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.9.0-rc.1/ >> >> The release candidate is signed with a GPG key available at: >> https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS >> >> The Git commit for this release is: >> >> https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=90243fc >> >> The Release Note is available in: >> >> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.9.0-rc.1/RELEASE_NOTE.txt >> >> Build Guide: >> >> https://github.com/apache/incubator-echarts/blob/4.9.0-rc.1/README.md#build >> >> Please vote on releasing this package as: >> Apache ECharts (incubating) 4.9.0 (release candidate 1) >> by "2020-08-13T05:00:00.000Z". >> >> [ ] +1 Release this package >> [ ] 0 I don't feel strongly about it, but don't object >> [ ] -1 Do not release this package because... >> >> Anyone can participate in testing and voting, not just committers, please >> feel free to try out the release candidate and provide your votes. >> >> A checklist for reference: >> >> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist >> >> Thanks >> >> -- >> Yi Shen >> Apache ECharts(incubating) PPMC >> > > > -- > Yi Shen > Apache ECharts(incubating) PPMC > -- Yi Shen Apache ECharts(incubating) PPMC
Re: [VOTE] Release Apache ECharts (incubating) 4.9.0 (release candidate 1)
We still need 3 binding votes on this release. Can anyone help vote? Thanks! On Mon, Aug 10, 2020 at 11:57 AM Yi Shen wrote: > Dear IPMC > > I am pleased to be calling this vote for the release of Apache ECharts > (incubating) 4.9.0 (release candidate 1). > > Apache ECharts community has voted and approved the release. > > Vote thread: > > https://lists.apache.org/thread.html/r67639d86c9b5944b1804fca86939052978df9594b45bc0d6474b9fb6%40%3Cdev.echarts.apache.org%3E > > Results thread: > > https://lists.apache.org/thread.html/rd9b5170f1f1bdda97c502aa4435650f86ec2ce14cd372ed3d548ce24%40%3Cdev.echarts.apache.org%3E > > The release candidate to be voted over is available at: > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.9.0-rc.1/ > > The release candidate is signed with a GPG key available at: > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > The Git commit for this release is: > > https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=90243fc > > The Release Note is available in: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.9.0-rc.1/RELEASE_NOTE.txt > > Build Guide: > https://github.com/apache/incubator-echarts/blob/4.9.0-rc.1/README.md#build > > Please vote on releasing this package as: > Apache ECharts (incubating) 4.9.0 (release candidate 1) > by "2020-08-13T05:00:00.000Z". > > [ ] +1 Release this package > [ ] 0 I don't feel strongly about it, but don't object > [ ] -1 Do not release this package because... > > Anyone can participate in testing and voting, not just committers, please > feel free to try out the release candidate and provide your votes. > > A checklist for reference: > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > Thanks > > -- > Yi Shen > Apache ECharts(incubating) PPMC > -- Yi Shen Apache ECharts(incubating) PPMC
[VOTE] Release Apache ECharts (incubating) 4.9.0 (release candidate 1)
Dear IPMC I am pleased to be calling this vote for the release of Apache ECharts (incubating) 4.9.0 (release candidate 1). Apache ECharts community has voted and approved the release. Vote thread: https://lists.apache.org/thread.html/r67639d86c9b5944b1804fca86939052978df9594b45bc0d6474b9fb6%40%3Cdev.echarts.apache.org%3E Results thread: https://lists.apache.org/thread.html/rd9b5170f1f1bdda97c502aa4435650f86ec2ce14cd372ed3d548ce24%40%3Cdev.echarts.apache.org%3E The release candidate to be voted over is available at: https://dist.apache.org/repos/dist/dev/incubator/echarts/4.9.0-rc.1/ The release candidate is signed with a GPG key available at: https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS The Git commit for this release is: https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=90243fc The Release Note is available in: https://dist.apache.org/repos/dist/dev/incubator/echarts/4.9.0-rc.1/RELEASE_NOTE.txt Build Guide: https://github.com/apache/incubator-echarts/blob/4.9.0-rc.1/README.md#build Please vote on releasing this package as: Apache ECharts (incubating) 4.9.0 (release candidate 1) by "2020-08-13T05:00:00.000Z". [ ] +1 Release this package [ ] 0 I don't feel strongly about it, but don't object [ ] -1 Do not release this package because... Anyone can participate in testing and voting, not just committers, please feel free to try out the release candidate and provide your votes. A checklist for reference: https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist Thanks -- Yi Shen Apache ECharts(incubating) PPMC
Re: [VOTE] Release Apache ECharts (incubating) 4.8.0 (release candidate 1)
Hi Justin, thanks for the check! I can compile from source successfully. Do you meet any errors when using `npm install` to install dependencies? On Fri, May 22, 2020 at 1:34 PM Justin Mclean wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - signatures and hashes are fine > - LICENSE and NOTICE are fine > - DISCLAIMER exists > - No unexpected binary files > - All ASF file have ASF headers > > I was unable to get it to “compile” but that is likely my setup it was > complaining: > Error: Cannot find module ‘rollup' > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Yi Shen Apache ECharts(incubating) PPMC
Re: [VOTE] Release Apache ECharts (incubating) 4.6.0 (release candidate 1)
Merry Christmas Kevin:) On Tue, Dec 24, 2019 at 12:27 AM Kevin A. McGrail wrote: > I'm sorry I cannot vote at this time due to the holiday. > > On 12/20/2019 1:18 AM, Justin Mclean wrote: > > Hi, > > > > +1 (binding) > > > > I checked: > > - incubating in name > > - DISCLAIMER exists > > - LICENSE and NOTICE OK > > - No unexpected binary files > > - All files have ASF headers > > > > I notice the README has the line: > > + [Baidu Map 百度地图扩展]( > https://github.com/apache/incubator-echarts/tree/master/extension/bmap) > > > > Why is it called Baidu Map, when the code belongs to the ASF and the > code has ASF headers? > > > > Thanks, > > Justin > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > -- > Kevin A. McGrail > kmcgr...@apache.org > > Member, Apache Software Foundation > Chair Emeritus Apache SpamAssassin Project > https://www.linkedin.com/in/kmcgrail - 703.798.0171 > > > ----- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Yi Shen Apache ECharts(incubating) PPMC
Re: [VOTE] Release Apache ECharts (incubating) 4.6.0 (release candidate 1)
Hi Justin, Baidu Map is a map service provided by Baidu in China. It's similar to Google Map. + [Baidu Map 百度地图扩展]( > https://github.com/apache/incubator-echarts/tree/master/extension/bmap) > This is an extension of ECharts which provides a wrapper to the JS SDK[1] of Baidu Map. For the convenience of using ECharts with Baidu Map. Perhaps we should use a more specific name like Extension for Baidu Map to avoid the confusion? [1] http://lbsyun.baidu.com/index.php?title=jspopular3.0 On Fri, Dec 20, 2019 at 2:18 PM Justin Mclean wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - DISCLAIMER exists > - LICENSE and NOTICE OK > - No unexpected binary files > - All files have ASF headers > > I notice the README has the line: > + [Baidu Map 百度地图扩展]( > https://github.com/apache/incubator-echarts/tree/master/extension/bmap) > > Why is it called Baidu Map, when the code belongs to the ASF and the code > has ASF headers? > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Yi Shen Apache ECharts(incubating) PPMC
Re: [VOTE] Release Apache ECharts (incubating) 4.5.0 (release candidate 2)
> > But we can make this page more clearly about the version hint. About the online builder page. Perhaps we can download the source release zip from Apache Server and do unzipping and bundling on the fly in the browser. We can even do sha512 validation in the browser if necessary. On Sat, Nov 16, 2019 at 9:21 PM Furkan KAMACI wrote: > Hi, > > +1 from me (binding). > > I checked: > > - Incubating in name > - DISCLAIMER exists > - LICENSE and NOTICE are fine > - No unexpected binary files > - Checked PGP signatures > - Checked Checksums > > Kind Regards, > Furkan KAMACI > > On Sat, Nov 16, 2019 at 3:55 PM Kevin Ratnasekera > > wrote: > > > +1 ( binding ) > > > > I checked the following. > > > > 1. Incubating in name. > > 2. PGP Signature. > > 3. SHA512 Checksum. > > 4. DISCLAIMER exists. > > 5. LICENSE and NOTICE are fine. > > > > Regards > > > > On Sat, Nov 16, 2019 at 6:15 PM Sheng Wu > > wrote: > > > > > +1 binding > > > > > > ASC checked. > > > sha512 is there > > > LICENSE, NOTICE, and DISCLAIMER are right. > > > > > > You should be good to go, now. Good luck. > > > > > > Sheng Wu 吴晟 > > > Twitter, wusheng1108 > > > > > > > > > SHUANG SU 于2019年11月16日周六 下午12:14写道： > > > > > > > Hi > > > > > > > > Just a reminder to vote on the release of Apache ECharts(incubating) > > > 4.5.0, > > > > We have got 2 binding vote from Justin and Dave. Still needs few > more > > > > binding votes to finish the vote. > > > > > > > > Thanks a lot! > > > > > > > > -- > > > > Su Shuang (100pah) > > > > -- > > > > > > > > > > > > > > > > On Thu, 14 Nov 2019 at 12:15, Dave Fisher wrote: > > > > > > > > > Carrying over my +1 (binding) from the dev@echarts thread. > > > > > > > > > > Regards, > > > > > Dave > > > > > > > > > > Sent from my iPhone > > > > > > > > > > > On Nov 11, 2019, at 10:38 AM, SHUANG SU > > > > wrote: > > > > > > > > > > > > I am pleased to be calling this vote for the release of Apache > > > ECharts > > > > > > (incubating) 4.5.0 (release candidate 2). > > > > > > > > > > > > Apache ECharts community has voted and approved the release. > > > > > > > > > > > > Vote thread: > > > > > > > > > > > > > > > > > > > > > https://lists.apache.org/thread.html/5138fd89d1ded77cffa41cd9f3aecbdf7911fac488db422a441108a8@%3Cdev.echarts.apache.org%3E > > > > > > > > > > > > Results thread: > > > > > > > > > > > > > > > > > > > > > https://lists.apache.org/thread.html/1709ae1c1b6aa584c6d9d1de6ce36a9fc53d25053b82c7d86ca7e747@%3Cdev.echarts.apache.org%3E > > > > > > > > > > > > The release candidate to be voted over is available at: > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.5.0-rc.2/ > > > > > > > > > > > > The release candidate is signed with a GPG key available at: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > > > > > > > > > The Git commit for this release is: > > > > > > > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=0ebdeaf4 > > > > > > > > > > > > The Release Note is available in: > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.5.0-rc.2/RELEASE_NOTE.txt > > > > > > > > > > > > Build Guide: > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-echarts/blob/4.5.0-rc.2/README.md#build > > > > > > > > > > > > Please vote on releasing this package as: > > > > > > Apache ECharts (incubating) 4.5.0 (release candidate 2) > > > > > > by "2019-11-14T19:35:11.982Z". > > > > > > > > > > > > [ ] +1 Release this package > > > > > > [ ] 0 I don't feel strongly about it, but don't object > > > > > > [ ] -1 Do not release this package because... > > > > > > > > > > > > Anyone can participate in testing and voting, not just > committers, > > > > please > > > > > > feel free to try out the release candidate and provide your > votes. > > > > > > > > > > > > A checklist for reference: > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > > > > > > > Thanks, > > > > > > -- > > > > > > Su Shuang (100pah) > > > > > > -- > > > > > > > > > > > > > > > > - > > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > > > -- Yi Shen Apache ECharts(incubating) PPMC
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release candidate 1)
Hi, thanks for the advice. We don't recommend using author tag any more. The remaining author tags in these codes can also be removed. I'd suggest fixing these issues and start a new release vote. On Fri, Sep 6, 2019 at 2:36 PM Justin Mclean wrote: > Hi, > > > File author is optional for me, if you want to keep it, just keep it, as > it > > has ASF header already. > > It was long ago decided that @author tags should generally not be used in > any ASF code. This the main discussion was back in 2004 I think and the > board recommend that author tags not be used for both legal and community > reasons. Perhaps someone who been around longer to me can remember the > discussion / find a link? > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Yi Shen Senior Developer Baidu, Inc.
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release candidate 1)
Hi Justin, 1. The Stack Overflow link we referenced in file [1] is an explanation of why this issue happens. We didn't use the code. 2. About files with author tags [6] - [24], it's because we used to add author names at the beginning of files as a convention. There are still some files keep it. They are not third party files Author of files [6], [7], [8], [21], [22], [24] is me (she...@apache.org) Author of files [9] - [20] is Deqing Li (deqin...@apache.org) Author of file [23] is Xiaohong Deng. She is one of our contributors, but not committer. We will remove the author tags in these files. 3. I wrote the code of file [28]. It's a parser of GEXF file format. The link in this file is broken. It's the specification of this format. The new link is https://gephi.org/gexf/1.2draft/gexf-12draft-primer.pdf 4. We will remove the function related to the code from Stack Overflow in file [5] and rewrite the code in file [26] before we start a new vote. Thanks. On Fri, Sep 6, 2019 at 7:33 AM Justin Mclean wrote: > Hi, > > -1 binding (release includes Category X licensed code) > > I checked: > - signatures and hashes fine > - DISCLAIMER exists > - LICENSE may have some issues and missing some license information (see > below) > - NOTICE is fine > - all source file have ASF headers > - no unexpected binary files > > This file [1] contain code from [2] this is probably not compatible with > the ALv2 [3][4]. Also this file [5]. > > It’s unclear how this file [6] is licensed and it may incorrectly have an > ASF header. On closer inspection there see to be a number of files which > might be 3rd party and incorrectly have an ASF header. [7] - [24]. You’ll > note these files have author tags. Where did these files come from? > > Some code in here [25] from this blog is licensed CC 4.0 BY_SA, this is > not compatible with the Apache license. [27] > > Do you have permission to use this code [28] from the authors and is it in > under an Apache license as the file header states? > > There are also a number of references to http://echarts.baidu.com in the > code which should probably change. > > You might want to consider using the work in progress disclaimer [29] and > documenting the issues in that until they are fixed. > > Thanks, > Justin > > 1. ./src/component/tooltip/TooltipContent.js > 2. > https://stackoverflow.com/questions/21125587/css3-transition-not-working-in-chrome-anymore > 3. https://apache.org/legal/resolved.html#stackoverflow > 4. https://issues.apache.org/jira/browse/LEGAL-471 > 5. ./src/component/toolbox/feature/DataView.js > 6. ./src/chart/chord/chordCircularLayout.js > 7. ./src/util/KDTree.js > 8. ./src/util/quickSelect.js > 9. ./src/chart/tree/TreeSeries.js > 10. ./src/chart/tree/treeAction.js > 11. ./src/chart/tree/TreeView.js > 12. ./src/chart/sankey/sankeyAction.js > 13. ./src/chart/sankey/SankeySeries.js > 14. ./src/chart/sankey/sankeyLayout.js > 15. ./src/chart/sankey/SankeyView.js > 16. ./src/chart/sankey/sankeyVisual.js > 17. ./src/chart/themeRiver/themeRiverVisual.js > 18. ./src/chart/themeRiver/themeRiverLayout.js > 19. ./src/chart/themeRiver/ThemeRiverSeries.js > 20. ./src/chart/themeRiver/ThemeRiverView.js > 21. ./src/chart/heatmap/HeatmapLayer.js > 22, ./src/chart/chord/chordCircularLayout.js > 23. ./src/component/calendar.js > 24. ./src/data/Graph.js > 25. ./src/component/brush/selector.js > 26. http://blog.csdn.net/rickliuxiao/article/details/6259322 > 27. https://apache.org/legal/resolved.html#cc-sa > 28. ./extension-src/dataTool/gexf.js > 29. https://incubator.apache.org/policy/incubation.html#disclaimers > > > > ----- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Yi Shen Senior Developer Baidu, Inc.
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
> > The whole file is based on the tree layout of D3 Sorry about missing the reference. https://github.com/d3/d3-hierarchy/blob/44ba491e8c6d5b8af21280f6507d4d372bc4272d/src/tree.js Yi Shen 于2018年6月1日周五 下午3:40写道： > Hi Dave: > > Without deep analysis I have no idea what parts are D3. If this whole file >> is based on D3 then in my opinion this whole source file needs to be BSD-3 >> clause licensed. >> >> I would change my VOTE to +1 if there is a good explanation. >> > > The whole file is based on the tree layout of D3. But we modified the code > a lot so the layout algorithm can be integrated into our architecture. > > Dave Fisher 于2018年6月1日周五 上午1:07写道： > >> Hi - >> >> I’m VOTING +0. >> >> (1) I am rather confused by this D3 license. For example: >> >> src/chart/tree/layoutHelper.js >> /* >> * Licensed to the Apache Software Foundation (ASF) under one >> * or more contributor license agreements. See the NOTICE file >> * distributed with this work for additional information >> * regarding copyright ownership. The ASF licenses this file >> * to you under the Apache License, Version 2.0 (the >> * "License"); you may not use this file except in compliance >> * with the License. You may obtain a copy of the License at >> * >> * http://www.apache.org/licenses/LICENSE-2.0 >> * >> * Unless required by applicable law or agreed to in writing, >> * software distributed under the License is distributed on an >> * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >> * KIND, either express or implied. See the License for the >> * specific language governing permissions and limitations >> * under the License. >> */ >> >> /* >> * The tree layout implementation references to d3.js >> * (https://github.com/d3/d3-hierarchy). The use of the source >> * code of this file is also subject to the terms and consitions >> * of its license (BSD-3Clause, see ). >> */ >> >> /** >> * @file The layout algorithm of node-link tree diagrams. Here we using >> Reingold-Tilford algorithm to drawing >> * the tree. >> * @see https://github.com/d3/d3-hierarchy >> */ >> >> import * as layout from '../../util/layout'; >> ... >> >> Without deep analysis I have no idea what parts are D3. If this whole >> file is based on D3 then in my opinion this whole source file needs to be >> BSD-3 clause licensed. >> >> I would change my VOTE to +1 if there is a good explanation. >> >> (2) I think that licenses/LICENSE-zrender is covered by the SGA. If this >> is correct then this file needs to be removed. >> >> (3) KEYS should not be included in the release package. >> >> (4) RELEASE-NOTE.txt should be part of the release package. >> >> Regards, >> Dave >> >> On May 30, 2018, at 11:28 PM, Justin Mclean >> wrote: >> >> Hi, >> >> sankeyLayout.js is mainly an improved implementation of the original d3 >> sankey layout algorithm. We will add sankeyLayout.js to the list of files >> embed [d3.js](https://github.com/d3/d3) BSD 3-Clause in the LICENSE if >> needed. >> >> >> Seems like it should be to me. Any modification of code are in general >> under the license of the original unless they are extensive. All licenses >> of any bundled software need to be mentioned in LICENSE. >> >> And in the HeatmapLayer.js, we were inspired by the idea of simpleheat. >> But >> the implementation and code are different. In this case, should we still >> add the LICENSE of simpleheat? >> >> >> IMO (but IANAL) “inspired by” means to me that they have copied at least >> some of it. If at some future time the license isn’t actually needed in >> LICENSE that’s OK as it just a documentation issue, but if it was required >> and not included that would be a licensing error. If that doesn’t convince >> you may be best to ask on legal discuss for an answer. >> >> (But either way it still only a minor issue as all the licenses are >> permissive and my +1 still stands.) >> >> Thanks, >> Justin >> - >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> >> > > -- > Yi Shen > Senior Developer > Baidu, Inc. > -- Yi Shen Senior Developer Baidu, Inc.
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Hi Dave: Without deep analysis I have no idea what parts are D3. If this whole file > is based on D3 then in my opinion this whole source file needs to be BSD-3 > clause licensed. > > I would change my VOTE to +1 if there is a good explanation. > The whole file is based on the tree layout of D3. But we modified the code a lot so the layout algorithm can be integrated into our architecture. Dave Fisher 于2018年6月1日周五 上午1:07写道： > Hi - > > I’m VOTING +0. > > (1) I am rather confused by this D3 license. For example: > > src/chart/tree/layoutHelper.js > /* > * Licensed to the Apache Software Foundation (ASF) under one > * or more contributor license agreements. See the NOTICE file > * distributed with this work for additional information > * regarding copyright ownership. The ASF licenses this file > * to you under the Apache License, Version 2.0 (the > * "License"); you may not use this file except in compliance > * with the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, > * software distributed under the License is distributed on an > * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > * KIND, either express or implied. See the License for the > * specific language governing permissions and limitations > * under the License. > */ > > /* > * The tree layout implementation references to d3.js > * (https://github.com/d3/d3-hierarchy). The use of the source > * code of this file is also subject to the terms and consitions > * of its license (BSD-3Clause, see ). > */ > > /** > * @file The layout algorithm of node-link tree diagrams. Here we using > Reingold-Tilford algorithm to drawing > * the tree. > * @see https://github.com/d3/d3-hierarchy > */ > > import * as layout from '../../util/layout'; > ... > > Without deep analysis I have no idea what parts are D3. If this whole file > is based on D3 then in my opinion this whole source file needs to be BSD-3 > clause licensed. > > I would change my VOTE to +1 if there is a good explanation. > > (2) I think that licenses/LICENSE-zrender is covered by the SGA. If this > is correct then this file needs to be removed. > > (3) KEYS should not be included in the release package. > > (4) RELEASE-NOTE.txt should be part of the release package. > > Regards, > Dave > > On May 30, 2018, at 11:28 PM, Justin Mclean > wrote: > > Hi, > > sankeyLayout.js is mainly an improved implementation of the original d3 > sankey layout algorithm. We will add sankeyLayout.js to the list of files > embed [d3.js](https://github.com/d3/d3) BSD 3-Clause in the LICENSE if > needed. > > > Seems like it should be to me. Any modification of code are in general > under the license of the original unless they are extensive. All licenses > of any bundled software need to be mentioned in LICENSE. > > And in the HeatmapLayer.js, we were inspired by the idea of simpleheat. But > the implementation and code are different. In this case, should we still > add the LICENSE of simpleheat? > > > IMO (but IANAL) “inspired by” means to me that they have copied at least > some of it. If at some future time the license isn’t actually needed in > LICENSE that’s OK as it just a documentation issue, but if it was required > and not included that would be a licensing error. If that doesn’t convince > you may be best to ask on legal discuss for an answer. > > (But either way it still only a minor issue as all the licenses are > permissive and my +1 still stands.) > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > > -- Yi Shen Senior Developer Baidu, Inc.
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Thanks Justin! > LICENSE is probably missing: > - MIT licensed sankey layout [1] in [2][3] > - 2 clause BSD Heatmap layer [4] in [5] I will try to explain these two concerns about LICENSE. sankeyLayout.js is mainly an improved implementation of the original d3 sankey layout algorithm. We will add sankeyLayout.js to the list of files embed [d3.js](https://github.com/d3/d3) BSD 3-Clause in the LICENSE if needed. And in the HeatmapLayer.js, we were inspired by the idea of simpleheat. But the implementation and code are different. In this case, should we still add the LICENSE of simpleheat? Justin Mclean 于2018年5月31日周四 上午9:04写道： > Hi, > > +1 binding > > I checked: > - incubating in name > - signatures and hashes good > - DISCLAIMER exists > - LICENSE is probably missing a few things (see below) > - NOTICE is good > - No binary files in release > - All source files have ASF headers > > LICENSE is probably missing: > - MIT licensed sankey layout [1] in [2][3] > - 2 clause BSD Heatmap layer [4] in [5] > > Some other very minor things: > - no need for KEYS file in the release > - looks like package.json could do with an update re URL and authors > - missing README or like on how to “compile” / use > > Thanks, > Justin > > 1. https://github.com/ricklupton/sankey-layout > 2. src/chart/sankey/sankeyLayout.js > 3. src/chart/themeRiver/themeRiverLayout.js > 4. https://github.com/mourner/simpleheat > 5. src/chart/heatmap/HeatmapLayer.js > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Yi Shen Senior Developer Baidu, Inc.
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
My vote is +1 binding. But when I check the source file with github repo[1]. I found there are > some directories are missed. > I guess we can skip the benchmark, tests, but I'm not sure for the theme > directory. Can you explain it? > We need to make sure we can build the full function binary from the source > release. > BTW, it looks there lots of github links in the README.md[2] need to be > updated. > And echarts need to move the website to echarts.incubator.apache.org from > baidu. Willem, thanks for pointing out the issues. Wenli Zhang has made a request for the apache website server. We will move the English website to echarts.incubator.apache.org after that. Not sure if it's ok but we prefer the Chinese website keep the url https://www.echartsjs.com/ , which is used currently The theme folder will not be included when building the distribution. It' more like resources which can be used externally, like geojson data in the map folder on the GitHub. Willem Jiang 于2018年5月31日周四 上午10:19写道： > Hi > > I just tried to build the source according to the instruction in the mail, > it works. > But when I check the source file with github repo[1]. I found there are > some directories are missed. > I guess we can skip the benchmark, tests, but I'm not sure for the theme > directory. Can you explain it? > We need to make sure we can build the full function binary from the source > release. > > BTW, it looks there lots of github links in the README.md[2] need to be > updated. > And echarts need to move the website to echarts.incubator.apache.org from > baidu. > > > [1] https://github.com/apache/incubator-echarts > [2]https://github.com/apache/incubator-echarts/blob/master/README.md > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Tue, May 29, 2018 at 5:09 PM, SHUANG SU wrote: > > > After removing some generated files and bin files from 4.1.0.rc3, only > > source code kept in the artifact. > > I am pleased to be calling this vote for the release of Apache ECharts > > 4.1.0.rc4. > > > > > > Apache ECharts community has voted and approved the release. > > > > Vote thread: > > https://lists.apache.org/thread.html/8ebfdd7219cbfed40cd2350e487b99 > > be58ec169fb7c5673e21e10dea@%3Cdev.echarts.apache.org%3E > > > > Results thread: > > https://lists.apache.org/thread.html/238ae37a82e2a71698f41a4d878e32 > > 5601b88c665f9951d3bf912db4@%3Cdev.echarts.apache.org%3E > > > > The release candidate to be voted over is available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc4/ > > > > The release candidate is signed with a GPG key available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > The Git commit for this release is: > > https://gitbox.apache.org/repos/asf?p=incubator-echarts. > > git;a=commit;h=02842e2 > > > > The Release Note is available in: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > 1.0.rc4/RELEASE_NOTE.txt > > > > Some shell commands for validating the release: > > > > ```shell > > # Download the release: > > curl > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > 1.0.rc4/apache-echarts-4.1.0.rc4-incubating-src.zip > > -o apache-echarts-4.1.0.rc4-incubating-src.zip > > unzip apache-echarts-4.1.0.rc4-incubating-src.zip -d > > apache-echarts-4.1.0.rc4-incubating-src > /dev/null > > > > # Rebuild the project (Node.js environment is required): > > cd "apache-echarts-4.1.0.rc4-incubating-src" && npm install && cd .. > > node "apache-echarts-4.1.0.rc4-incubating-src/build/build.js" --release > > # (See help: `node "apache-echarts-4.1.0.rc4- > > incubating-src/build/build.js" > > --help`) > > ``` > > > > > > Please vote on releasing this package as: > > Apache ECharts 4.1.0.rc4 > > > > This vote will be open until "2018-06-01T10:02:35.437Z". > > > > [ ] +1 Release this package > > [ ] 0 I don't feel strongly about it, but don't object > > [ ] -1 Do not release this package because... > > > > Anyone can participate in testing and voting, not just committers, please > > feel free to try out the release candidate and provide your votes. > > > > -- > > Su Shuang (100pah) > > -- > > > -- Yi Shen Senior Developer Baidu, Inc.
