Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Hi, Thanks for bringing this up. We are doing a thorough review of the licenses for all files in the source [1] and will finish that first before rc2. Best, Sheng [1] https://github.com/apache/incubator-mxnet/issues/19427 On 2020/10/21 22:23:20, Justin Mclean wrote: > Hi, > > Re the licensed files missing from LICENSE here are some > examples[1][2][3][4], but I haven’t done a full check so there are probably > more. > > Thanks, > Justin > > 1. > ./3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/tests/test_gil_scoped.cpp > 2. > ./3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/tests/test_tagbased_polymorphic.cpp > 3. > ./3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/tests/test_union.cpp > 4. ./3rdparty/mkldnn/cmake/blas.cmake > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
HI, > Thanks, Justin. After removing stale issues and adding the statement on GPU > license, assuming we address any other license issue in the next rc, should > we name it as simply DISCLAIMER instead of DISCLAIMER-WIP? When all issue have been resolved then I would name it DISCLAIMER, probably best to keep DISCLAIMER WIP at this piont. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Thanks, Justin. After removing stale issues and adding the statement on GPU license, assuming we address any other license issue in the next rc, should we name it as simply DISCLAIMER instead of DISCLAIMER-WIP? I thought it should be the case and just want to confirm. Best, Sheng On 2020/10/21 21:41:37, Justin Mclean wrote: > Hi, > > > Thanks for the vote. It looks like we forgot to remove the mentions of the > > resolved issues in the DISCLAIMER-WIP. Checking the linked issues, all of > > them have been resolved in 1.8. Is this still a blocking issue if the > > actual issues that the DISCLAIMER-WIP links to are addressed? > > The DISCLAIMER WIP needs to be keep up to date. When I looked not all of > these issues were resolved. > > > Between 1.8 submodules [1] and that of 1.7 [2] there hasn't been any > > addition of submodule. For the four modules with updated commits > > (dmlc-core, mkldnn, nvidia-cub, onnx-tensorrt), I didn't find any license > > change. What's missing? > > If you compare the copyright statements between the two release you’ll see > there are a number of differences and mention of bundled 3rd party licenses > are missing from the LICENSE file. > > > Regarding NVIDIA licensing, I'm not sure what the standard practice is > > given that we are indeed open sourcing our GPU source code with ALv2 and > > the NVIDIA licensing only comes into picture in binary distribution and not > > in a source release. Advice is appreciated. > > You need to tell your users that using the software in this way that it is > not compatible with the Apache license. I think the DISCLAIMER would be a > good place to do this. > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Hi Justin, I reviewed the open items in INCUBATOR-253 and didn't find issue that impacts source code release. Let me know if you feel differently on any of those items. Best, Sheng On 2020/10/21 22:38:50, Justin Mclean wrote: > HI, > > Is there anything from the known issues in [1] that needs to be added? > > Justin > > 1. https://issues.apache.org/jira/browse/INCUBATOR-253 > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Hi, > Let’s discuss outside the immediate context of MxNet reasons for the IPMC to > suspend a podling. Sure, it would be best to start a seperate thread for that. I think however it would be so infrequent and each situation different that it would be hard to come up with some that would work in general. What to do about this situation has already been discussed on the IPMC private list. Thanks, Justin
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Sure. We still need to define suspension. Regards, Dave Sent from my iPhone > On Oct 21, 2020, at 9:15 PM, Justin Mclean wrote: > > Hi, > >> If NVIDIA changes the license then it must be very soon. If so then the >> issue is gone. > > And the issue may not be gone unless the license change is retroactive. > Currently the project has maven artefacts in the Apache repo that contain > category X code. [1] > > Thanks, > Justin > > 1. https://issues.apache.org/jira/browse/INFRA-20442 - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Hi, > If NVIDIA changes the license then it must be very soon. If so then the issue > is gone. And the issue may not be gone unless the license change is retroactive. Currently the project has maven artefacts in the Apache repo that contain category X code. [1] Thanks, Justin 1. https://issues.apache.org/jira/browse/INFRA-20442
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Hi - Let’s discuss outside the immediate context of MxNet reasons for the IPMC to suspend a podling. Regards, Dave Sent from my iPhone > On Oct 21, 2020, at 8:57 PM, Justin Mclean wrote: > > HI, > >> Don’t make a noncompliant binary release. > > The project is (sadly) already doing this [1], they are hoping the licensing > issue can be sorted, but its taken more than 5 months and little visible > progress on that seems to have been done. NVIDIA is considering changing, > but to what we don’t know. > >> Tell your users how to make a noncompliant build on their own knowing the >> risks. > > They don’t want to do that, as it is too hard for users to compile. > >> Third parties like NVIDIA can make their own decision and release, but can’t >> call it Apache MxNext, but have to use “powered by” if they use the brand. > > This has been brought many times by the IPMC over many months, but it seems > they still seem to have branding and naming issues. [2] > > Thanks, > Justin > > 1. https://pypi.org/project/mxnet/ > 2. https://ngc.nvidia.com/catalog/containers/nvidia:mxnet - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
HI, > Don’t make a noncompliant binary release. The project is (sadly) already doing this [1], they are hoping the licensing issue can be sorted, but its taken more than 5 months and little visible progress on that seems to have been done. NVIDIA is considering changing, but to what we don’t know. > Tell your users how to make a noncompliant build on their own knowing the > risks. They don’t want to do that, as it is too hard for users to compile. > Third parties like NVIDIA can make their own decision and release, but can’t > call it Apache MxNext, but have to use “powered by” if they use the brand. This has been brought many times by the IPMC over many months, but it seems they still seem to have branding and naming issues. [2] Thanks, Justin 1. https://pypi.org/project/mxnet/ 2. https://ngc.nvidia.com/catalog/containers/nvidia:mxnet
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Sent from my iPhone > On Oct 21, 2020, at 7:31 PM, Sheng Zha wrote: > > Hi Justin, > > Thanks for the vote. It looks like we forgot to remove the mentions of the > resolved issues in the DISCLAIMER-WIP. Checking the linked issues, all of > them have been resolved in 1.8. Is this still a blocking issue if the actual > issues that the DISCLAIMER-WIP links to are addressed? > > Between 1.8 submodules [1] and that of 1.7 [2] there hasn't been any addition > of submodule. For the four modules with updated commits (dmlc-core, mkldnn, > nvidia-cub, onnx-tensorrt), I didn't find any license change. What's missing? > > Regarding NVIDIA licensing, I'm not sure what the standard practice is given > that we are indeed open sourcing our GPU source code with ALv2 and the NVIDIA > licensing only comes into picture in binary distribution and not in a source > release. Advice is appreciated. Don’t make a noncompliant binary release. Tell your users how to make a noncompliant build on their own knowing the risks. Third parties like NVIDIA can make their own decision and release, but can’t call it Apache MxNext, but have to use “powered by” if they use the brand. If NVIDIA changes the license then it must be very soon. If so then the issue is gone. Regards, Dave > > Best, > Sheng > > [1] https://github.com/apache/incubator-mxnet/blob/v1.8.x/.gitmodules > [2] https://github.com/apache/incubator-mxnet/blob/v1.7.x/.gitmodules > >> On 2020/10/20 23:04:00, Justin Mclean wrote: >> Hi, >> >> -1 (binding) Please see [1] and note which sort of issues need to be fixed >> before making a new release. >> >> While it does include the WIP declaimers, it includes several knows issues >> that have been outstanding for several releases. It also fails to mention >> teh issue with Nvidia licensing and its incompatibility with the Apache >> license. The PPMC needs to take action on correcting licensing issues in one >> release before creating other releases. >> >> When comparing to the 1.7 release, new 3rd part code has been added, and the >> LICENSE file has not been updated to list all of the included code. The >> project needs to follow the terms of 3rd party licenses, which generally >> state to including the text of the license and follow ASF policy on >> licenses. >> >> Thanks, >> Justin >> >> 1. https://issues.apache.org/jira/browse/LEGAL-469 >> - >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
HI, Is there anything from the known issues in [1] that needs to be added? Justin 1. https://issues.apache.org/jira/browse/INCUBATOR-253 - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Regarding the disclaimer issues, I have reviewed the 3 issues called out in the disclaimer and found that they have all been resolved. Here is a PR [1] to update the disclaimer and add the additional language describing the licensing incompatibility when building for GPU with Nvidia licensed tools/libraries. Thanks! Sam [1] https://github.com/apache/incubator-mxnet/pull/19402 On 2020/10/21 22:20:08, wrote: > Hi, > > I'm the author of one of the 3rd party libraries, intgemm, that is > new in 1.8. It is MIT licensed but also includes catch for testing > under Boost. MXNet doesn't compile my tests. > https://github.com/kpu/intgemm/blob/master/LICENSE > > In https://github.com/apache/incubator-mxnet/pull/17559 we wavered > back and forth between being a submodule and being fetched by cmake in > build. It ended up on by default for x86_64, fetched during build, and > with the LICENSE dangling a reference to the third_party directory. > We've now discussed this, including with leezu who originally suggested > fetching. It will change to a submodule and at the same time sync the > LICENSE. I hope to have a pull request opened tomorrow and the > committers say this should be in the next rc. > > Regards, > > Kenneth > > > On 2020/10/21 21:41:37, Justin Mclean wrote: > > Hi,> > > > > > Thanks for the vote. It looks like we forgot to remove the mentions > of the resolved issues in the DISCLAIMER-WIP. Checking the linked > issues, all of them have been resolved in 1.8. Is this still a blocking > issue if the actual issues that the DISCLAIMER-WIP links to are addressed?> > > > > The DISCLAIMER WIP needs to be keep up to date. When I looked not all > of these issues were resolved.> > > > > > Between 1.8 submodules [1] and that of 1.7 [2] there hasn't been > any addition of submodule. For the four modules with updated commits > (dmlc-core, mkldnn, nvidia-cub, onnx-tensorrt), I didn't find any > license change. What's missing?> > > > > If you compare the copyright statements between the two release > you’ll see there are a number of differences and mention of bundled 3rd > party licenses are missing from the LICENSE file.> > > > > > Regarding NVIDIA licensing, I'm not sure what the standard practice > is given that we are indeed open sourcing our GPU source code with ALv2 > and the NVIDIA licensing only comes into picture in binary distribution > and not in a source release. Advice is appreciated.> > > > > You need to tell your users that using the software in this way that > it is not compatible with the Apache license. I think the DISCLAIMER > would be a good place to do this.> > > > > Thanks,> > > Justin> > > -> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org> > > For additional commands, e-mail: general-h...@incubator.apache.org> > > > > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Hi, Re the licensed files missing from LICENSE here are some examples[1][2][3][4], but I haven’t done a full check so there are probably more. Thanks, Justin 1. ./3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/tests/test_gil_scoped.cpp 2. ./3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/tests/test_tagbased_polymorphic.cpp 3. ./3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/tests/test_union.cpp 4. ./3rdparty/mkldnn/cmake/blas.cmake - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Hi, I'm the author of one of the 3rd party libraries, intgemm, that is new in 1.8. It is MIT licensed but also includes catch for testing under Boost. MXNet doesn't compile my tests. https://github.com/kpu/intgemm/blob/master/LICENSE In https://github.com/apache/incubator-mxnet/pull/17559 we wavered back and forth between being a submodule and being fetched by cmake in build. It ended up on by default for x86_64, fetched during build, and with the LICENSE dangling a reference to the third_party directory. We've now discussed this, including with leezu who originally suggested fetching. It will change to a submodule and at the same time sync the LICENSE. I hope to have a pull request opened tomorrow and the committers say this should be in the next rc. Regards, Kenneth On 2020/10/21 21:41:37, Justin Mclean wrote: > Hi,> > > > Thanks for the vote. It looks like we forgot to remove the mentions of the resolved issues in the DISCLAIMER-WIP. Checking the linked issues, all of them have been resolved in 1.8. Is this still a blocking issue if the actual issues that the DISCLAIMER-WIP links to are addressed?> > > The DISCLAIMER WIP needs to be keep up to date. When I looked not all of these issues were resolved.> > > > Between 1.8 submodules [1] and that of 1.7 [2] there hasn't been any addition of submodule. For the four modules with updated commits (dmlc-core, mkldnn, nvidia-cub, onnx-tensorrt), I didn't find any license change. What's missing?> > > If you compare the copyright statements between the two release you’ll see there are a number of differences and mention of bundled 3rd party licenses are missing from the LICENSE file.> > > > Regarding NVIDIA licensing, I'm not sure what the standard practice is given that we are indeed open sourcing our GPU source code with ALv2 and the NVIDIA licensing only comes into picture in binary distribution and not in a source release. Advice is appreciated.> > > You need to tell your users that using the software in this way that it is not compatible with the Apache license. I think the DISCLAIMER would be a good place to do this.> > > Thanks,> > Justin> > -> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org> > For additional commands, e-mail: general-h...@incubator.apache.org> > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Hi, > Thanks for the vote. It looks like we forgot to remove the mentions of the > resolved issues in the DISCLAIMER-WIP. Checking the linked issues, all of > them have been resolved in 1.8. Is this still a blocking issue if the actual > issues that the DISCLAIMER-WIP links to are addressed? The DISCLAIMER WIP needs to be keep up to date. When I looked not all of these issues were resolved. > Between 1.8 submodules [1] and that of 1.7 [2] there hasn't been any addition > of submodule. For the four modules with updated commits (dmlc-core, mkldnn, > nvidia-cub, onnx-tensorrt), I didn't find any license change. What's missing? If you compare the copyright statements between the two release you’ll see there are a number of differences and mention of bundled 3rd party licenses are missing from the LICENSE file. > Regarding NVIDIA licensing, I'm not sure what the standard practice is given > that we are indeed open sourcing our GPU source code with ALv2 and the NVIDIA > licensing only comes into picture in binary distribution and not in a source > release. Advice is appreciated. You need to tell your users that using the software in this way that it is not compatible with the Apache license. I think the DISCLAIMER would be a good place to do this. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Hi Justin, Thanks for the vote. It looks like we forgot to remove the mentions of the resolved issues in the DISCLAIMER-WIP. Checking the linked issues, all of them have been resolved in 1.8. Is this still a blocking issue if the actual issues that the DISCLAIMER-WIP links to are addressed? Between 1.8 submodules [1] and that of 1.7 [2] there hasn't been any addition of submodule. For the four modules with updated commits (dmlc-core, mkldnn, nvidia-cub, onnx-tensorrt), I didn't find any license change. What's missing? Regarding NVIDIA licensing, I'm not sure what the standard practice is given that we are indeed open sourcing our GPU source code with ALv2 and the NVIDIA licensing only comes into picture in binary distribution and not in a source release. Advice is appreciated. Best, Sheng [1] https://github.com/apache/incubator-mxnet/blob/v1.8.x/.gitmodules [2] https://github.com/apache/incubator-mxnet/blob/v1.7.x/.gitmodules On 2020/10/20 23:04:00, Justin Mclean wrote: > Hi, > > -1 (binding) Please see [1] and note which sort of issues need to be fixed > before making a new release. > > While it does include the WIP declaimers, it includes several knows issues > that have been outstanding for several releases. It also fails to mention teh > issue with Nvidia licensing and its incompatibility with the Apache license. > The PPMC needs to take action on correcting licensing issues in one release > before creating other releases. > > When comparing to the 1.7 release, new 3rd part code has been added, and the > LICENSE file has not been updated to list all of the included code. The > project needs to follow the terms of 3rd party licenses, which generally > state to including the text of the license and follow ASF policy on licenses. > > Thanks, > Justin > > 1. https://issues.apache.org/jira/browse/LEGAL-469 > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Hi, -1 (binding) Please see [1] and note which sort of issues need to be fixed before making a new release. While it does include the WIP declaimers, it includes several knows issues that have been outstanding for several releases. It also fails to mention teh issue with Nvidia licensing and its incompatibility with the Apache license. The PPMC needs to take action on correcting licensing issues in one release before creating other releases. When comparing to the 1.7 release, new 3rd part code has been added, and the LICENSE file has not been updated to list all of the included code. The project needs to follow the terms of 3rd party licenses, which generally state to including the text of the license and follow ASF policy on licenses. Thanks, Justin 1. https://issues.apache.org/jira/browse/LEGAL-469 - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
+1 carrying my vote from dev. On 2020/10/13 05:40:32, "Skalicky, Sam" wrote: > Dear community, > > This is a call for a releasing Apache MXNet (incubating) 1.8.0, release > candidate 1. > > Apache MXNet (incubating) community has voted and approved the release. > > Vote thread: > https://lists.apache.org/thread.html/rea5d88e6d37f6053e10068deca312c6ef27d0e8cf0308bb700f9dd0b%40%3Cdev.mxnet.apache.org%3E > > Result thread: > https://lists.apache.org/thread.html/red6e3fa3f7d266f7cbf9e52f11cc74363f5b4053e42e92cad8a18515%40%3Cdev.mxnet.apache.org%3E > > The source tarball, including signatures, digests, etc. can be found at: > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.8.0.rc1 > > The tag to be voted upon is 1.8.0.rc1: > https://github.com/apache/incubator-mxnet/releases/tag/1.8.0.rc1 > > The release hash is cc4b8ec68b6ec9dae73046e9c34ac97439efda83: > https://github.com/apache/incubator-mxnet/commit/cc4b8ec68b6ec9dae73046e9c34ac97439efda83 > > KEYS file available: > https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS > > For information about the contents of this release, see: > https://cwiki.apache.org/confluence/display/MXNET/1.8.0+Release+Notes > > The vote will be open for 72 hours. > [ ] +1 release this package as # > [ ] +0 no opinion > [ ] -1 do not release this package because... > > Best regards, > Sam Skalicky > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
[VOTE] Release Apache MXNet (incubating) version 1.8.0.rc1
Dear community, This is a call for a releasing Apache MXNet (incubating) 1.8.0, release candidate 1. Apache MXNet (incubating) community has voted and approved the release. Vote thread: https://lists.apache.org/thread.html/rea5d88e6d37f6053e10068deca312c6ef27d0e8cf0308bb700f9dd0b%40%3Cdev.mxnet.apache.org%3E Result thread: https://lists.apache.org/thread.html/red6e3fa3f7d266f7cbf9e52f11cc74363f5b4053e42e92cad8a18515%40%3Cdev.mxnet.apache.org%3E The source tarball, including signatures, digests, etc. can be found at: https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.8.0.rc1 The tag to be voted upon is 1.8.0.rc1: https://github.com/apache/incubator-mxnet/releases/tag/1.8.0.rc1 The release hash is cc4b8ec68b6ec9dae73046e9c34ac97439efda83: https://github.com/apache/incubator-mxnet/commit/cc4b8ec68b6ec9dae73046e9c34ac97439efda83 KEYS file available: https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS For information about the contents of this release, see: https://cwiki.apache.org/confluence/display/MXNET/1.8.0+Release+Notes The vote will be open for 72 hours. [ ] +1 release this package as # [ ] +0 no opinion [ ] -1 do not release this package because... Best regards, Sam Skalicky
