Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

Hi Henri and Justin, Thanks for the prompt feedbacks on the LICENSE file! I also posted a PR to update the years to be 2017-2018 in the NOTICE file. Furthermore, I created a task of moving all submodules to the 3rdparty folder in JIRA

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

Thanks Justin, We did remove that jar before creating this RC0 but thanks for answering the question. Meghna On Tue, Feb 6, 2018 at 3:36 PM, Justin Mclean wrote: > Hi, > > > Please let me know if anyone sees any other major issues in this file. > > Thanks - that's

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

Hi, > Please let me know if anyone sees any other major issues in this file. Thanks - that's looking a lot better. I did notice a question in the wiki page "Question 5: is it ok to include a necessary jar?”. Compiled source code can't be included in a source release so no it’s not OK to

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

Thanks Justin! I have reviewed this PR and made a few more changes. The final changes to the LICENSE file can be summarized as follows - 1. I have reverted commit 8930d96 (PR #9484) 2. Revisited some comments from previous release which are

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

Hi, > I have created a PR to revert the LICENSE file to the previous version. I > have also updated this file with a few packages that were missing here. > Link to PR - https://github.com/apache/incubator-mxnet/pull/9701 > > It would be great if you could review this PR to suggest any other >

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

I have created a PR to revert the LICENSE file to the previous version. I have also updated this file with a few packages that were missing here. Link to PR - https://github.com/apache/incubator-mxnet/pull/9701 It would be great if you could review this PR to suggest any other necessary changes.

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

Thank you for the comments. The license issue should be fixed in the next RC then. Other than that, is moving submodules like dmlc-core/nnvm/ps-lite etc. to 3rd-party a must-have for the the next release candidate of 1.1.0? In the original LICENSE file (MXNet 1.0.0) we explicitly state that these

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

On Mon, Feb 5, 2018 at 2:58 PM, Justin Mclean wrote: > Hi, > > > Are there any files apart from these excluded ones where you see missing > licenses? > > You don’t need to exclude files that are under a different licensesI would > rather see them in the rat report so I

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

Hi Sebb, Thanks for the suggestion. I've updated the release process wiki at https://cwiki.apache.org/confluence/display/MXNET/Release+Process#ReleaseProcess-3.7.CleanupolderreleasesonASFmirrors

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

On 5 February 2018 at 22:51, Haibin Lin wrote: > Hi Sebb, > > I've deleted the older releases and will remove 1.0.0 after 1.1.0 is > officially announced. OK, thanks. Please also update any release process docs to ensure tidyup takes place after every release. > Best,

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

Hi, > Are there any files apart from these excluded ones where you see missing > licenses? You don’t need to exclude files that are under a different licensesI would rather see them in the rat report so I know what 3rd party software is there. And yes I noticed a couple (which would not be a

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

Hi Sebb, I've deleted the older releases and will remove 1.0.0 after 1.1.0 is officially announced. Best, Haibin On Mon, Feb 5, 2018 at 2:32 PM, Haibin Lin wrote: > Hi Sebb, > > I'll clean up the old releases now. Thanks for the reminder. > > Best, > Haibin > > On

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

Hi Sebb, I'll clean up the old releases now. Thanks for the reminder. Best, Haibin On Mon, Feb 5, 2018 at 2:20 PM, sebb wrote: > On 31 January 2018 at 21:48, Haibin Lin wrote: > > Hello all, > > > > This is a call for a releasing Apache MXNet

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

On 31 January 2018 at 21:48, Haibin Lin wrote: > Hello all, > > This is a call for a releasing Apache MXNet (incubating) 1.1.0, release > candidate 0. Reminder: please delete old releases from the ASF mirrors. It's not fair to expect volunteer mirrors to carry them.

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

Hi Justin, Thank you for your time to review this Release Candidate. For this Release I attempted to fix most of the pending license issues and I have documented all the changes in this wiki - https://cwiki.apache.org/confluence/display/MXNET/MXNet+Source+Licenses Any comments/feedback would be

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

Hi, Sorry but -1 binding for me due to LICENSE issues but happy to discuss and change my vote depending on what other IPMC members think. Putting “wherever applicable” is probably not enough to compile with the terms of 3rd party licenses or ASF policy. Most licenses say the full text of the

Re: [VOTE] Apache MXNet (incubating) 1.1.0 release RC0

Hello all, Just a gentle reminder that voting is in progress. Please help verify if the release candidate meets the standard and vote accordingly. Thanks! Best, Haibin On Wed, Jan 31, 2018 at 1:48 PM, Haibin Lin wrote: > Hello all, > > This is a call for a releasing