Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[jun liu]

> You may need to close this vote if we want to start a new round of release.

Thanks for reminding.

I am closing this vote now. We’ve solved the issues reported in this round, I 
will start a new vote thread later.

Best regards,
Jun

> On 22 Aug 2018, at 17:02, Willem Jiang  wrote:
> 
> Hi Liu Jun,
> 
> You may need to close this vote if we want to start a new round of release.
> 
> 
> Willem Jiang
> 
> Twitter: willemjiang
> Weibo: 姜宁willem
> 
> On Mon, Aug 20, 2018 at 11:27 AM, Jun Liu  wrote:
> 
>>> I guess you did use the maven release plugin to do the latest release, as
>>> we cannot see the release plugin commit  log there.
>> 
>> Yes, we used maven release plugin to do the latest release, and it has
>> automatically changed the version to ‘2.6.4-SNAPSHOT’. I forgot to change
>> it back when tag in this round.
>> 
>>> As we are doing the source release, it quit import that we ship the
>> exactly
>>> source which is tagged to let the other user can do the same release
>>> without changing the code.
>> 
>> Agree, I think we should start a new round of vote to address this issue.
>> 
>> Best regards,
>> Jun
>> 
>>> On 18 Aug 2018, at 17:33, Willem Jiang  wrote:
>>> 
>>> I checked the source.zip file data, it is same with the data with the
>> tag,
>>> but the pom version was not same with the git repo as Mark already point
>>> out.
>>> I guess you did use the maven release plugin to do the latest release, as
>>> we cannot see the release plugin commit  log there.
>>> 
>>> After going through PPMC voting thread, there are several rounds of vote
>>> there, so I guess there may have some uncommitted change when doing the
>>> release.
>>> As we are doing the source release, it quit import that we ship the
>> exactly
>>> source which is tagged to let the other user can do the same release
>>> without changing the code.
>>> 
>>> @Jun Liu,  could you double check that?
>>> 
>>> 
>>> Willem Jiang
>>> 
>>> Twitter: willemjiang
>>> Weibo: 姜宁willem
>>> 
>>> On Sat, Aug 18, 2018 at 5:56 AM, Mark Thomas  wrote:
>>> 
 On 12/08/18 08:12, Jun Liu wrote:
 
 
 
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [X] -1 disapprove with the reason (binding)
 
 The sha512 hashes are missing the '*' marker that indicates they are
 hashes for binary files rather than text files. Trivial issue. Can be
 addressed in the next release.
 
 I'd expect the files to be named "apache-dubbo..." not "dubbo...". Nice
 to have (not all Apache projects use this naming convention). Something
 to consider for the next release.
 
 Consider including mvnw and mvnw.cmd in the source release so it is
 simpler to get started with the build from a source release.
 
 The 2.6.3 tag does not agree with the source release. This is a
 significant issue and enough for me to vote against the release. A diff
 shows most (all?) of the pom.xml have a version of "2.6.4-SNAPSHOT" in
 the tag but "2.6.3" in the source release.
 
 I dug into this a little. At first I thought the tag / commit in the
 vote was wrong. It is. But is isn't just that. If I go back to
 
 a8be0eaaddab198ed03b0150d4db03e2b22f023f
 
 things are better but:
 a) there are still differences
 b) the tag includes multiple commits after this point
 
 
 Mark
 
 -
 To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
 For additional commands, e-mail: general-h...@incubator.apache.org
 
 
>> 
>> 

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Willem Jiang]

Hi Liu Jun,

You may need to close this vote if we want to start a new round of release.


Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Mon, Aug 20, 2018 at 11:27 AM, Jun Liu  wrote:

> > I guess you did use the maven release plugin to do the latest release, as
> > we cannot see the release plugin commit  log there.
>
> Yes, we used maven release plugin to do the latest release, and it has
> automatically changed the version to ‘2.6.4-SNAPSHOT’. I forgot to change
> it back when tag in this round.
>
> > As we are doing the source release, it quit import that we ship the
> exactly
> > source which is tagged to let the other user can do the same release
> > without changing the code.
>
> Agree, I think we should start a new round of vote to address this issue.
>
> Best regards,
> Jun
>
> > On 18 Aug 2018, at 17:33, Willem Jiang  wrote:
> >
> > I checked the source.zip file data, it is same with the data with the
> tag,
> > but the pom version was not same with the git repo as Mark already point
> > out.
> > I guess you did use the maven release plugin to do the latest release, as
> > we cannot see the release plugin commit  log there.
> >
> > After going through PPMC voting thread, there are several rounds of vote
> > there, so I guess there may have some uncommitted change when doing the
> > release.
> > As we are doing the source release, it quit import that we ship the
> exactly
> > source which is tagged to let the other user can do the same release
> > without changing the code.
> >
> > @Jun Liu,  could you double check that?
> >
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Sat, Aug 18, 2018 at 5:56 AM, Mark Thomas  wrote:
> >
> >> On 12/08/18 08:12, Jun Liu wrote:
> >>
> >> 
> >>
> >>> Please vote accordingly:
> >>> [ ] +1 approve
> >>> [ ] +0 no opinion
> >>> [X] -1 disapprove with the reason (binding)
> >>
> >> The sha512 hashes are missing the '*' marker that indicates they are
> >> hashes for binary files rather than text files. Trivial issue. Can be
> >> addressed in the next release.
> >>
> >> I'd expect the files to be named "apache-dubbo..." not "dubbo...". Nice
> >> to have (not all Apache projects use this naming convention). Something
> >> to consider for the next release.
> >>
> >> Consider including mvnw and mvnw.cmd in the source release so it is
> >> simpler to get started with the build from a source release.
> >>
> >> The 2.6.3 tag does not agree with the source release. This is a
> >> significant issue and enough for me to vote against the release. A diff
> >> shows most (all?) of the pom.xml have a version of "2.6.4-SNAPSHOT" in
> >> the tag but "2.6.3" in the source release.
> >>
> >> I dug into this a little. At first I thought the tag / commit in the
> >> vote was wrong. It is. But is isn't just that. If I go back to
> >>
> >> a8be0eaaddab198ed03b0150d4db03e2b22f023f
> >>
> >> things are better but:
> >> a) there are still differences
> >> b) the tag includes multiple commits after this point
> >>
> >>
> >> Mark
> >>
> >> -
> >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> >> For additional commands, e-mail: general-h...@incubator.apache.org
> >>
> >>
>
>

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Jason Joo]

hi,


I suggest the next iteration of development should be on another branch such as 
"2.6.4" or "2.6.x".
We indeed should keep the pre-release branch clean (I just do some local work 
changing versions for our own nexus repo before).

best regards,

Jason

> On Aug 20, 2018, at 11:02, Jun Liu  wrote:
> 
>> The 2.6.3 tag does not agree with the source release. This is a
>> significant issue and enough for me to vote against the release. A diff
>> shows most (all?) of the pom.xml have a version of "2.6.4-SNAPSHOT" in
>> the tag but "2.6.3" in the source release.
>> 
>> I dug into this a little. At first I thought the tag / commit in the
>> vote was wrong. It is. But is isn't just that. If I go back to
>> 
>> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>> 
>> things are better but:
>> a) there are still differences
>> b) the tag includes multiple commits after this point
> 
> Thanks for your feedback, Mark, I have double checked the version mismatch 
> problem and it does exist.
> 
> Despite that all files except for the pom version are the same, I agree it’s 
> still an issue that needs revoting. It will confuse developers when trying to 
> rebuild from the tag. The root problem is more about a package or upload 
> problem than a technical problem. We used maven-release-plugin to prepare for 
> the release, which has changed the pom version to ‘2.6.4-SNAPSHOT’ since RC1, 
> I remember to change to 2.6.3 before tagging in RC2 but forget to do that in 
> this round. 
> 
> I think we should build a release script to automate the whole release 
> process to avoid this kind of problems.
> 
> Best regards,
> Jun
> 
>> On 18 Aug 2018, at 05:56, Mark Thomas  wrote:
>> 
>> On 12/08/18 08:12, Jun Liu wrote:
>> 
>> 
>> 
>>> Please vote accordingly:
>>> [ ] +1 approve 
>>> [ ] +0 no opinion 
>>> [X] -1 disapprove with the reason (binding)
>> 
>> The sha512 hashes are missing the '*' marker that indicates they are
>> hashes for binary files rather than text files. Trivial issue. Can be
>> addressed in the next release.
>> 
>> I'd expect the files to be named "apache-dubbo..." not "dubbo...". Nice
>> to have (not all Apache projects use this naming convention). Something
>> to consider for the next release.
>> 
>> Consider including mvnw and mvnw.cmd in the source release so it is
>> simpler to get started with the build from a source release.
>> 
>> The 2.6.3 tag does not agree with the source release. This is a
>> significant issue and enough for me to vote against the release. A diff
>> shows most (all?) of the pom.xml have a version of "2.6.4-SNAPSHOT" in
>> the tag but "2.6.3" in the source release.
>> 
>> I dug into this a little. At first I thought the tag / commit in the
>> vote was wrong. It is. But is isn't just that. If I go back to
>> 
>> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>> 
>> things are better but:
>> a) there are still differences
>> b) the tag includes multiple commits after this point
>> 
>> 
>> Mark
> 

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Jun Liu]

> I guess you did use the maven release plugin to do the latest release, as
> we cannot see the release plugin commit  log there.

Yes, we used maven release plugin to do the latest release, and it has 
automatically changed the version to ‘2.6.4-SNAPSHOT’. I forgot to change it 
back when tag in this round.

> As we are doing the source release, it quit import that we ship the exactly
> source which is tagged to let the other user can do the same release
> without changing the code.

Agree, I think we should start a new round of vote to address this issue.

Best regards,
Jun

> On 18 Aug 2018, at 17:33, Willem Jiang  wrote:
> 
> I checked the source.zip file data, it is same with the data with the tag,
> but the pom version was not same with the git repo as Mark already point
> out.
> I guess you did use the maven release plugin to do the latest release, as
> we cannot see the release plugin commit  log there.
> 
> After going through PPMC voting thread, there are several rounds of vote
> there, so I guess there may have some uncommitted change when doing the
> release.
> As we are doing the source release, it quit import that we ship the exactly
> source which is tagged to let the other user can do the same release
> without changing the code.
> 
> @Jun Liu,  could you double check that?
> 
> 
> Willem Jiang
> 
> Twitter: willemjiang
> Weibo: 姜宁willem
> 
> On Sat, Aug 18, 2018 at 5:56 AM, Mark Thomas  wrote:
> 
>> On 12/08/18 08:12, Jun Liu wrote:
>> 
>> 
>> 
>>> Please vote accordingly:
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [X] -1 disapprove with the reason (binding)
>> 
>> The sha512 hashes are missing the '*' marker that indicates they are
>> hashes for binary files rather than text files. Trivial issue. Can be
>> addressed in the next release.
>> 
>> I'd expect the files to be named "apache-dubbo..." not "dubbo...". Nice
>> to have (not all Apache projects use this naming convention). Something
>> to consider for the next release.
>> 
>> Consider including mvnw and mvnw.cmd in the source release so it is
>> simpler to get started with the build from a source release.
>> 
>> The 2.6.3 tag does not agree with the source release. This is a
>> significant issue and enough for me to vote against the release. A diff
>> shows most (all?) of the pom.xml have a version of "2.6.4-SNAPSHOT" in
>> the tag but "2.6.3" in the source release.
>> 
>> I dug into this a little. At first I thought the tag / commit in the
>> vote was wrong. It is. But is isn't just that. If I go back to
>> 
>> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>> 
>> things are better but:
>> a) there are still differences
>> b) the tag includes multiple commits after this point
>> 
>> 
>> Mark
>> 
>> -
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>> 
>> 

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Jun Liu]

> The 2.6.3 tag does not agree with the source release. This is a
> significant issue and enough for me to vote against the release. A diff
> shows most (all?) of the pom.xml have a version of "2.6.4-SNAPSHOT" in
> the tag but "2.6.3" in the source release.
> 
> I dug into this a little. At first I thought the tag / commit in the
> vote was wrong. It is. But is isn't just that. If I go back to
> 
> a8be0eaaddab198ed03b0150d4db03e2b22f023f
> 
> things are better but:
> a) there are still differences
> b) the tag includes multiple commits after this point

Thanks for your feedback, Mark, I have double checked the version mismatch 
problem and it does exist.

Despite that all files except for the pom version are the same, I agree it’s 
still an issue that needs revoting. It will confuse developers when trying to 
rebuild from the tag. The root problem is more about a package or upload 
problem than a technical problem. We used maven-release-plugin to prepare for 
the release, which has changed the pom version to ‘2.6.4-SNAPSHOT’ since RC1, I 
remember to change to 2.6.3 before tagging in RC2 but forget to do that in this 
round. 

I think we should build a release script to automate the whole release process 
to avoid this kind of problems.

Best regards,
Jun

> On 18 Aug 2018, at 05:56, Mark Thomas  wrote:
> 
> On 12/08/18 08:12, Jun Liu wrote:
> 
> 
> 
>> Please vote accordingly:
>> [ ] +1 approve 
>> [ ] +0 no opinion 
>> [X] -1 disapprove with the reason (binding)
> 
> The sha512 hashes are missing the '*' marker that indicates they are
> hashes for binary files rather than text files. Trivial issue. Can be
> addressed in the next release.
> 
> I'd expect the files to be named "apache-dubbo..." not "dubbo...". Nice
> to have (not all Apache projects use this naming convention). Something
> to consider for the next release.
> 
> Consider including mvnw and mvnw.cmd in the source release so it is
> simpler to get started with the build from a source release.
> 
> The 2.6.3 tag does not agree with the source release. This is a
> significant issue and enough for me to vote against the release. A diff
> shows most (all?) of the pom.xml have a version of "2.6.4-SNAPSHOT" in
> the tag but "2.6.3" in the source release.
> 
> I dug into this a little. At first I thought the tag / commit in the
> vote was wrong. It is. But is isn't just that. If I go back to
> 
> a8be0eaaddab198ed03b0150d4db03e2b22f023f
> 
> things are better but:
> a) there are still differences
> b) the tag includes multiple commits after this point
> 
> 
> Mark

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Willem Jiang]

I checked the source.zip file data, it is same with the data with the tag,
but the pom version was not same with the git repo as Mark already point
out.
I guess you did use the maven release plugin to do the latest release, as
we cannot see the release plugin commit  log there.

After going through PPMC voting thread, there are several rounds of vote
there, so I guess there may have some uncommitted change when doing the
release.
As we are doing the source release, it quit import that we ship the exactly
source which is tagged to let the other user can do the same release
without changing the code.

@Jun Liu,  could you double check that?


Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Sat, Aug 18, 2018 at 5:56 AM, Mark Thomas  wrote:

> On 12/08/18 08:12, Jun Liu wrote:
>
> 
>
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [X] -1 disapprove with the reason (binding)
>
> The sha512 hashes are missing the '*' marker that indicates they are
> hashes for binary files rather than text files. Trivial issue. Can be
> addressed in the next release.
>
> I'd expect the files to be named "apache-dubbo..." not "dubbo...". Nice
> to have (not all Apache projects use this naming convention). Something
> to consider for the next release.
>
> Consider including mvnw and mvnw.cmd in the source release so it is
> simpler to get started with the build from a source release.
>
> The 2.6.3 tag does not agree with the source release. This is a
> significant issue and enough for me to vote against the release. A diff
> shows most (all?) of the pom.xml have a version of "2.6.4-SNAPSHOT" in
> the tag but "2.6.3" in the source release.
>
> I dug into this a little. At first I thought the tag / commit in the
> vote was wrong. It is. But is isn't just that. If I go back to
>
> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>
> things are better but:
> a) there are still differences
> b) the tag includes multiple commits after this point
>
>
> Mark
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Mark Thomas]

On 12/08/18 08:12, Jun Liu wrote:



> Please vote accordingly:
> [ ] +1 approve 
> [ ] +0 no opinion 
> [X] -1 disapprove with the reason (binding)

The sha512 hashes are missing the '*' marker that indicates they are
hashes for binary files rather than text files. Trivial issue. Can be
addressed in the next release.

I'd expect the files to be named "apache-dubbo..." not "dubbo...". Nice
to have (not all Apache projects use this naming convention). Something
to consider for the next release.

Consider including mvnw and mvnw.cmd in the source release so it is
simpler to get started with the build from a source release.

The 2.6.3 tag does not agree with the source release. This is a
significant issue and enough for me to vote against the release. A diff
shows most (all?) of the pom.xml have a version of "2.6.4-SNAPSHOT" in
the tag but "2.6.3" in the source release.

I dug into this a little. At first I thought the tag / commit in the
vote was wrong. It is. But is isn't just that. If I go back to

a8be0eaaddab198ed03b0150d4db03e2b22f023f

things are better but:
a) there are still differences
b) the tag includes multiple commits after this point


Mark

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Jun Liu]

We still lack 2 binding votes,l kindly ask for the PMCs to help to verify and 
vote.

Best regards,
Jun

> On 15 Aug 2018, at 10:56, Jun Liu  wrote:
> 
> Here're some tips of how to verify the RC:
> 
> 1. Check signatures and hashes are good
>   sha512 dubbo-incubating-${release_version}-bin-release.zip.sha512
>   sha512 dubbo-incubating-${release_version}-source-release.zip.sha512
>   gpg2 --keyserver pgpkeys.mit.edu --recv-key 208B0AB1D63011C7
>   gpg2 --verify dubbo-incubating-2.6.2-source-release.zip.asc 
> dubbo-incubating-2.6.2-source-release.zip 
> 
> 2. Unzip dubbo-incubating-${release_version}-source-release.zip to the 
> default directory and check the following:
>   • Directory with 'incubating' in name 
> dubbo-incubating-${release_version}-bin-release
>   • DISCLAIMER exists
>   • LICENSE and NOTICE exists and contents are good
>   • All files and no binary files exist
>   • All files has standard ASF License header
>   • Can compile from source
>   • All unit tests can pass
>   mvn clean test # This will run all unit tests
>   mvn clean install -Drat.skip=false -Dcheckstyle.skip=false # 
> Open rat and style plugin to check if every file meets requirements.
>   • Release candidates match with corresponding tags, you can find tag 
> link and hash in vote email.
> 
> 3. Unzip dubbo-incubating-${release_version}-bin-release.zip and check:
>   * 'incubating' in name
>   * LICENSE and NOTICE exists and contents are good
> 
> Best regards,
> Jun
> 
>> On 12 Aug 2018, at 15:12, Jun Liu  wrote:
>> 
>> Hello All,
>> 
>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
>> 
>> The Apache Dubbo community has voted on and approved a proposal to release 
>> Apache Dubbo (Incubating) version 2.6.3.
>> 
>> We now kindly request the Incubator PMC members review and vote on this 
>> incubator release.
>> 
>> Apache Dubbo™ (incubating) is a high-performance, java based, open source 
>> RPC framework. Dubbo offers three key functionalities, which include 
>> interface based remote call, fault tolerance & load balancing, and automatic 
>> service registration & discovery. 
>> 
>> Dubbo community vote thread:
>> https://lists.apache.org/thread.html/9e692f525dfbd004e98707ecac33ab10d07741500433a24370e64c67@%3Cdev.dubbo.apache.org%3E
>> 
>> Dubbo community vote result thread:
>> https://lists.apache.org/thread.html/630d7ed97ca06a341a7c6626c34af52eab42515439f76e0810504533@%3Cdev.dubbo.apache.org%3E
>> 
>> The release candidates:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>> 
>> Git tag for the release:
>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>> 
>> Hash for the release tag:
>> 22899a4b395411496ebf03c514e7674e8073e0c3
>> 
>> Release Notes:
>> https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.3/CHANGES.md
>> 
>> The artifacts have been signed with Key : 28681CB1, which can be found in 
>> the keys file:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>> 
>> The vote will be open for at least 72 hours or until necessary number of 
>> votes are reached.
>> 
>> Please vote accordingly:
>> [ ] +1 approve 
>> [ ] +0 no opinion 
>> [ ] -1 disapprove with the reason
>> 
>> Thanks.
>> Jun Liu,
>> The Apache Dubbo (Incubating) Team
>> 
>> 
>> -
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>> 
> 
> 
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Jun Liu]

> ING=/tmp/keyring.$$
> gpg2 --keyring $RING --no-default-keyring --import KEYS
> gpg2 --keyring $RING --no-default-keyring --verify …

Thanks Sebb, I will try it later.

Would you mind to help verify the Release Candidate?

Best regards,
Jun

> On 16 Aug 2018, at 20:39, sebb  wrote:
> 
> On 16 August 2018 at 12:56, Jun Liu  wrote:
>>> Better to get the key from the KEYS file.
>> 
>> I think that would be:
>> 1. download and import the KEYS from 
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS 
>> 
>> 2. gpg2 --verify dubbo-incubating-2.6.2-source-release.zip.asc 
>> dubbo-incubating-2.6.2-source-release.zip
>> 
>> Is that right?
> 
> Looks OK.
> 
> I use a temporary file as the keyring to ensure that the key is
> actually present in the file, e.g.
> 
> RING=/tmp/keyring.$$
> gpg2 --keyring $RING --no-default-keyring --import KEYS
> gpg2 --keyring $RING --no-default-keyring --verify ...
> 
>> What is the exact command to specify the key to use when have multiple keys 
>> locally?
> 
> I don't know if it's possible to specify the key to be used.
> 
> But by starting with an empty keyring one can check that the right key
> is in the KEYS file.
> 
>> Best regards,
>> Jun
>> 
>>> On 15 Aug 2018, at 20:52, sebb  wrote:
>>> 
>>> On 15 August 2018 at 03:56, Jun Liu >> > wrote:
 Here're some tips of how to verify the RC:
 
 1. Check signatures and hashes are good
   sha512 dubbo-incubating-${release_version}-bin-release.zip.sha512
   sha512 dubbo-incubating-${release_version}-source-release.zip.sha512
   gpg2 --keyserver pgpkeys.mit.edu  
 --recv-key 208B0AB1D63011C7
>>> 
>>> Better to get the key from the KEYS file.
>>> 
   gpg2 --verify dubbo-incubating-2.6.2-source-release.zip.asc 
 dubbo-incubating-2.6.2-source-release.zip
 
 2. Unzip dubbo-incubating-${release_version}-source-release.zip to the 
 default directory and check the following:
   • Directory with 'incubating' in name 
 dubbo-incubating-${release_version}-bin-release
   • DISCLAIMER exists
   • LICENSE and NOTICE exists and contents are good
   • All files and no binary files exist
   • All files has standard ASF License header
   • Can compile from source
   • All unit tests can pass
   mvn clean test # This will run all unit tests
   mvn clean install -Drat.skip=false -Dcheckstyle.skip=false # 
 Open rat and style plugin to check if every file meets requirements.
   • Release candidates match with corresponding tags, you can find tag 
 link and hash in vote email.
 
 3. Unzip dubbo-incubating-${release_version}-bin-release.zip and check:
   * 'incubating' in name
   * LICENSE and NOTICE exists and contents are good
 
 Best regards,
 Jun
 
> On 12 Aug 2018, at 15:12, Jun Liu  wrote:
> 
> Hello All,
> 
> This is a call for vote to release Apache Dubbo (Incubating) version 
> 2.6.3.
> 
> The Apache Dubbo community has voted on and approved a proposal to 
> release Apache Dubbo (Incubating) version 2.6.3.
> 
> We now kindly request the Incubator PMC members review and vote on this 
> incubator release.
> 
> Apache Dubbo™ (incubating) is a high-performance, java based, open source 
> RPC framework. Dubbo offers three key functionalities, which include 
> interface based remote call, fault tolerance & load balancing, and 
> automatic service registration & discovery.
> 
> Dubbo community vote thread:
> https://lists.apache.org/thread.html/9e692f525dfbd004e98707ecac33ab10d07741500433a24370e64c67@%3Cdev.dubbo.apache.org%3E
> 
> Dubbo community vote result thread:
> https://lists.apache.org/thread.html/630d7ed97ca06a341a7c6626c34af52eab42515439f76e0810504533@%3Cdev.dubbo.apache.org%3E
> 
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
> 
> Git tag for the release:
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
> 
> Hash for the release tag:
> 22899a4b395411496ebf03c514e7674e8073e0c3
> 
> Release Notes:
> https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.3/CHANGES.md
> 
> The artifacts have been signed with Key : 28681CB1, which can be found in 
> the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
> 
> The vote will be open for at least 72 hours or until necessary number of 
> votes are reached.
> 
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks.
> Jun Liu,
> The Apache Dubbo (Incubating) Team
> 
> 
> 

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[sebb]

On 16 August 2018 at 12:56, Jun Liu  wrote:
>> Better to get the key from the KEYS file.
>
> I think that would be:
> 1. download and import the KEYS from 
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS 
> 
> 2. gpg2 --verify dubbo-incubating-2.6.2-source-release.zip.asc 
> dubbo-incubating-2.6.2-source-release.zip
>
> Is that right?

Looks OK.

I use a temporary file as the keyring to ensure that the key is
actually present in the file, e.g.

RING=/tmp/keyring.$$
gpg2 --keyring $RING --no-default-keyring --import KEYS
 gpg2 --keyring $RING --no-default-keyring --verify ...

> What is the exact command to specify the key to use when have multiple keys 
> locally?

I don't know if it's possible to specify the key to be used.

But by starting with an empty keyring one can check that the right key
is in the KEYS file.

> Best regards,
> Jun
>
>> On 15 Aug 2018, at 20:52, sebb  wrote:
>>
>> On 15 August 2018 at 03:56, Jun Liu > > wrote:
>>> Here're some tips of how to verify the RC:
>>>
>>> 1. Check signatures and hashes are good
>>>sha512 dubbo-incubating-${release_version}-bin-release.zip.sha512
>>>sha512 dubbo-incubating-${release_version}-source-release.zip.sha512
>>>gpg2 --keyserver pgpkeys.mit.edu  
>>> --recv-key 208B0AB1D63011C7
>>
>> Better to get the key from the KEYS file.
>>
>>>gpg2 --verify dubbo-incubating-2.6.2-source-release.zip.asc 
>>> dubbo-incubating-2.6.2-source-release.zip
>>>
>>> 2. Unzip dubbo-incubating-${release_version}-source-release.zip to the 
>>> default directory and check the following:
>>>• Directory with 'incubating' in name 
>>> dubbo-incubating-${release_version}-bin-release
>>>• DISCLAIMER exists
>>>• LICENSE and NOTICE exists and contents are good
>>>• All files and no binary files exist
>>>• All files has standard ASF License header
>>>• Can compile from source
>>>• All unit tests can pass
>>>mvn clean test # This will run all unit tests
>>>mvn clean install -Drat.skip=false -Dcheckstyle.skip=false # 
>>> Open rat and style plugin to check if every file meets requirements.
>>>• Release candidates match with corresponding tags, you can find tag 
>>> link and hash in vote email.
>>>
>>> 3. Unzip dubbo-incubating-${release_version}-bin-release.zip and check:
>>>* 'incubating' in name
>>>* LICENSE and NOTICE exists and contents are good
>>>
>>> Best regards,
>>> Jun
>>>
 On 12 Aug 2018, at 15:12, Jun Liu  wrote:

 Hello All,

 This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.

 The Apache Dubbo community has voted on and approved a proposal to release 
 Apache Dubbo (Incubating) version 2.6.3.

 We now kindly request the Incubator PMC members review and vote on this 
 incubator release.

 Apache Dubbo™ (incubating) is a high-performance, java based, open source 
 RPC framework. Dubbo offers three key functionalities, which include 
 interface based remote call, fault tolerance & load balancing, and 
 automatic service registration & discovery.

 Dubbo community vote thread:
 https://lists.apache.org/thread.html/9e692f525dfbd004e98707ecac33ab10d07741500433a24370e64c67@%3Cdev.dubbo.apache.org%3E

 Dubbo community vote result thread:
 https://lists.apache.org/thread.html/630d7ed97ca06a341a7c6626c34af52eab42515439f76e0810504533@%3Cdev.dubbo.apache.org%3E

 The release candidates:
 https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3

 Git tag for the release:
 https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3

 Hash for the release tag:
 22899a4b395411496ebf03c514e7674e8073e0c3

 Release Notes:
 https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.3/CHANGES.md

 The artifacts have been signed with Key : 28681CB1, which can be found in 
 the keys file:
 https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS

 The vote will be open for at least 72 hours or until necessary number of 
 votes are reached.

 Please vote accordingly:
 [ ] +1 approve
 [ ] +0 no opinion
 [ ] -1 disapprove with the reason

 Thanks.
 Jun Liu,
 The Apache Dubbo (Incubating) Team


 -
 To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
 For additional commands, e-mail: general-h...@incubator.apache.org

>>>
>>>
>>> -
>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org 
>>> 
>>> For additional commands, e-mail: general-h...@incubator.apache.org 
>>> 

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Jun Liu]

> In LICENSE there’s no need to list hessian-lite license as it’s not been 
> bundled.

We have noticed this issue during vote in Dubbo Community and it will be 
removed in the next release.

> A couple of other very minor issues exist:
> - Netty has a (poor) NOTICE file [1] given a couple of files have been used 
> from that project the Dubbo NOTICE file needs to be updated. [2]
> - Rather than including URL t license it best to use pointer to text files 
> contained within the release as content at URL change changes or no longer be 
> available.

We will take a look at these LICENSE issues.

> - several poms have "Copyright 1999-2011 Alibaba Group” in there headers 
> which should be removed.

Ops, we thought it was all removed, will double check it later.

> I also notice in the code of conduct that you put the contact address as 
> d...@dubbo.apache.org you may want to use the private list instead as this 
> may be a better place to discuss anything along those lines?


I also think it should be priv...@dubbo.apache.org 
.

Best regards,
Jun

> On 16 Aug 2018, at 06:04, Justin Mclean  wrote:
> 
> Hi,
> 
> +1 binding
> 
> I checked:
> - incubating in name
> - signatures and hashed all good
> - DISCLAIMER exists
> - LICENSE and NOTICE have minor issues (see below)
> - No unexpected binary files
> - All source files (other than a few pom files) have ASF headers
> - Can compile from source
> 
> In LICENSE there’s no need to list hessian-lite license as it’s not been 
> bundled.
> 
> A couple of other very minor issues exist:
> - Netty has a (poor) NOTICE file [1] given a couple of files have been used 
> from that project the Dubbo NOTICE file needs to be updated. [2]
> - Rather than including URL t license it best to use pointer to text files 
> contained within the release as content at URL change changes or no longer be 
> available.
> - several poms have "Copyright 1999-2011 Alibaba Group” in there headers 
> which should be removed.
> 
> I also notice in the code of conduct that you put the contact address as 
> d...@dubbo.apache.org you may want to use the private list instead as this 
> may be a better place to discuss anything along those lines?
> 
> Thanks,
> Justin
> 
> 1. https://github.com/netty/netty/blob/4.1/NOTICE.txt
> 2. http://www.apache.org/dev/licensing-howto.html#mod-notice
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Jun Liu]

> Better to get the key from the KEYS file.

I think that would be: 
1. download and import the KEYS from 
https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS 

2. gpg2 --verify dubbo-incubating-2.6.2-source-release.zip.asc 
dubbo-incubating-2.6.2-source-release.zip

Is that right? What is the exact command to specify the key to use when have 
multiple keys locally?

Best regards,
Jun

> On 15 Aug 2018, at 20:52, sebb  wrote:
> 
> On 15 August 2018 at 03:56, Jun Liu  > wrote:
>> Here're some tips of how to verify the RC:
>> 
>> 1. Check signatures and hashes are good
>>sha512 dubbo-incubating-${release_version}-bin-release.zip.sha512
>>sha512 dubbo-incubating-${release_version}-source-release.zip.sha512
>>gpg2 --keyserver pgpkeys.mit.edu  --recv-key 
>> 208B0AB1D63011C7
> 
> Better to get the key from the KEYS file.
> 
>>gpg2 --verify dubbo-incubating-2.6.2-source-release.zip.asc 
>> dubbo-incubating-2.6.2-source-release.zip
>> 
>> 2. Unzip dubbo-incubating-${release_version}-source-release.zip to the 
>> default directory and check the following:
>>• Directory with 'incubating' in name 
>> dubbo-incubating-${release_version}-bin-release
>>• DISCLAIMER exists
>>• LICENSE and NOTICE exists and contents are good
>>• All files and no binary files exist
>>• All files has standard ASF License header
>>• Can compile from source
>>• All unit tests can pass
>>mvn clean test # This will run all unit tests
>>mvn clean install -Drat.skip=false -Dcheckstyle.skip=false # 
>> Open rat and style plugin to check if every file meets requirements.
>>• Release candidates match with corresponding tags, you can find tag 
>> link and hash in vote email.
>> 
>> 3. Unzip dubbo-incubating-${release_version}-bin-release.zip and check:
>>* 'incubating' in name
>>* LICENSE and NOTICE exists and contents are good
>> 
>> Best regards,
>> Jun
>> 
>>> On 12 Aug 2018, at 15:12, Jun Liu  wrote:
>>> 
>>> Hello All,
>>> 
>>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
>>> 
>>> The Apache Dubbo community has voted on and approved a proposal to release 
>>> Apache Dubbo (Incubating) version 2.6.3.
>>> 
>>> We now kindly request the Incubator PMC members review and vote on this 
>>> incubator release.
>>> 
>>> Apache Dubbo™ (incubating) is a high-performance, java based, open source 
>>> RPC framework. Dubbo offers three key functionalities, which include 
>>> interface based remote call, fault tolerance & load balancing, and 
>>> automatic service registration & discovery.
>>> 
>>> Dubbo community vote thread:
>>> https://lists.apache.org/thread.html/9e692f525dfbd004e98707ecac33ab10d07741500433a24370e64c67@%3Cdev.dubbo.apache.org%3E
>>> 
>>> Dubbo community vote result thread:
>>> https://lists.apache.org/thread.html/630d7ed97ca06a341a7c6626c34af52eab42515439f76e0810504533@%3Cdev.dubbo.apache.org%3E
>>> 
>>> The release candidates:
>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>>> 
>>> Git tag for the release:
>>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>>> 
>>> Hash for the release tag:
>>> 22899a4b395411496ebf03c514e7674e8073e0c3
>>> 
>>> Release Notes:
>>> https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.3/CHANGES.md
>>> 
>>> The artifacts have been signed with Key : 28681CB1, which can be found in 
>>> the keys file:
>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>>> 
>>> The vote will be open for at least 72 hours or until necessary number of 
>>> votes are reached.
>>> 
>>> Please vote accordingly:
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>> 
>>> Thanks.
>>> Jun Liu,
>>> The Apache Dubbo (Incubating) Team
>>> 
>>> 
>>> -
>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>>> For additional commands, e-mail: general-h...@incubator.apache.org
>>> 
>> 
>> 
>> -
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org 
>> 
>> For additional commands, e-mail: general-h...@incubator.apache.org 
>> 
>> 
> 
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org 
> 
> For additional commands, e-mail: general-h...@incubator.apache.org 
> 

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Justin Mclean]

Hi,

+1 binding

I checked:
- incubating in name
- signatures and hashed all good
- DISCLAIMER exists
- LICENSE and NOTICE have minor issues (see below)
- No unexpected binary files
- All source files (other than a few pom files) have ASF headers
- Can compile from source

In LICENSE there’s no need to list hessian-lite license as it’s not been 
bundled.

A couple of other very minor issues exist:
- Netty has a (poor) NOTICE file [1] given a couple of files have been used 
from that project the Dubbo NOTICE file needs to be updated. [2]
- Rather than including URL t license it best to use pointer to text files 
contained within the release as content at URL change changes or no longer be 
available.
- several poms have "Copyright 1999-2011 Alibaba Group” in there headers which 
should be removed.

I also notice in the code of conduct that you put the contact address as 
d...@dubbo.apache.org you may want to use the private list instead as this may 
be a better place to discuss anything along those lines?

Thanks,
Justin

1. https://github.com/netty/netty/blob/4.1/NOTICE.txt
2. http://www.apache.org/dev/licensing-howto.html#mod-notice
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[sebb]

On 15 August 2018 at 03:56, Jun Liu  wrote:
> Here're some tips of how to verify the RC:
>
> 1. Check signatures and hashes are good
> sha512 dubbo-incubating-${release_version}-bin-release.zip.sha512
> sha512 dubbo-incubating-${release_version}-source-release.zip.sha512
> gpg2 --keyserver pgpkeys.mit.edu --recv-key 208B0AB1D63011C7

Better to get the key from the KEYS file.

> gpg2 --verify dubbo-incubating-2.6.2-source-release.zip.asc 
> dubbo-incubating-2.6.2-source-release.zip
>
> 2. Unzip dubbo-incubating-${release_version}-source-release.zip to the 
> default directory and check the following:
> • Directory with 'incubating' in name 
> dubbo-incubating-${release_version}-bin-release
> • DISCLAIMER exists
> • LICENSE and NOTICE exists and contents are good
> • All files and no binary files exist
> • All files has standard ASF License header
> • Can compile from source
> • All unit tests can pass
> mvn clean test # This will run all unit tests
> mvn clean install -Drat.skip=false -Dcheckstyle.skip=false # 
> Open rat and style plugin to check if every file meets requirements.
> • Release candidates match with corresponding tags, you can find tag 
> link and hash in vote email.
>
> 3. Unzip dubbo-incubating-${release_version}-bin-release.zip and check:
> * 'incubating' in name
> * LICENSE and NOTICE exists and contents are good
>
> Best regards,
> Jun
>
>> On 12 Aug 2018, at 15:12, Jun Liu  wrote:
>>
>> Hello All,
>>
>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
>>
>> The Apache Dubbo community has voted on and approved a proposal to release 
>> Apache Dubbo (Incubating) version 2.6.3.
>>
>> We now kindly request the Incubator PMC members review and vote on this 
>> incubator release.
>>
>> Apache Dubbo™ (incubating) is a high-performance, java based, open source 
>> RPC framework. Dubbo offers three key functionalities, which include 
>> interface based remote call, fault tolerance & load balancing, and automatic 
>> service registration & discovery.
>>
>> Dubbo community vote thread:
>> https://lists.apache.org/thread.html/9e692f525dfbd004e98707ecac33ab10d07741500433a24370e64c67@%3Cdev.dubbo.apache.org%3E
>>
>> Dubbo community vote result thread:
>> https://lists.apache.org/thread.html/630d7ed97ca06a341a7c6626c34af52eab42515439f76e0810504533@%3Cdev.dubbo.apache.org%3E
>>
>> The release candidates:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>>
>> Git tag for the release:
>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>>
>> Hash for the release tag:
>> 22899a4b395411496ebf03c514e7674e8073e0c3
>>
>> Release Notes:
>> https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.3/CHANGES.md
>>
>> The artifacts have been signed with Key : 28681CB1, which can be found in 
>> the keys file:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>>
>> The vote will be open for at least 72 hours or until necessary number of 
>> votes are reached.
>>
>> Please vote accordingly:
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>>
>> Thanks.
>> Jun Liu,
>> The Apache Dubbo (Incubating) Team
>>
>>
>> -
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>>
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Jun Liu]

> sha512 dubbo-incubating-${release_version}-bin-release.zip.sha512
> sha512 dubbo-incubating-${release_version}-source-release.zip.sha512

Sorry, the right command:
shasum -c dubbo-incubating-${release_version}-source-release.zip.sha512
shasum -c dubbo-incubating-${release_version}-bin-release.zip.sha512

Best regards,
Jun

> On 15 Aug 2018, at 10:56, Jun Liu  wrote:
> 
> Here're some tips of how to verify the RC:
> 
> 1. Check signatures and hashes are good
>   sha512 dubbo-incubating-${release_version}-bin-release.zip.sha512
>   sha512 dubbo-incubating-${release_version}-source-release.zip.sha512
>   gpg2 --keyserver pgpkeys.mit.edu --recv-key 208B0AB1D63011C7
>   gpg2 --verify dubbo-incubating-2.6.2-source-release.zip.asc 
> dubbo-incubating-2.6.2-source-release.zip 
> 
> 2. Unzip dubbo-incubating-${release_version}-source-release.zip to the 
> default directory and check the following:
>   • Directory with 'incubating' in name 
> dubbo-incubating-${release_version}-bin-release
>   • DISCLAIMER exists
>   • LICENSE and NOTICE exists and contents are good
>   • All files and no binary files exist
>   • All files has standard ASF License header
>   • Can compile from source
>   • All unit tests can pass
>   mvn clean test # This will run all unit tests
>   mvn clean install -Drat.skip=false -Dcheckstyle.skip=false # 
> Open rat and style plugin to check if every file meets requirements.
>   • Release candidates match with corresponding tags, you can find tag 
> link and hash in vote email.
> 
> 3. Unzip dubbo-incubating-${release_version}-bin-release.zip and check:
>   * 'incubating' in name
>   * LICENSE and NOTICE exists and contents are good
> 
> Best regards,
> Jun
> 
>> On 12 Aug 2018, at 15:12, Jun Liu  wrote:
>> 
>> Hello All,
>> 
>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
>> 
>> The Apache Dubbo community has voted on and approved a proposal to release 
>> Apache Dubbo (Incubating) version 2.6.3.
>> 
>> We now kindly request the Incubator PMC members review and vote on this 
>> incubator release.
>> 
>> Apache Dubbo™ (incubating) is a high-performance, java based, open source 
>> RPC framework. Dubbo offers three key functionalities, which include 
>> interface based remote call, fault tolerance & load balancing, and automatic 
>> service registration & discovery. 
>> 
>> Dubbo community vote thread:
>> https://lists.apache.org/thread.html/9e692f525dfbd004e98707ecac33ab10d07741500433a24370e64c67@%3Cdev.dubbo.apache.org%3E
>> 
>> Dubbo community vote result thread:
>> https://lists.apache.org/thread.html/630d7ed97ca06a341a7c6626c34af52eab42515439f76e0810504533@%3Cdev.dubbo.apache.org%3E
>> 
>> The release candidates:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>> 
>> Git tag for the release:
>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>> 
>> Hash for the release tag:
>> 22899a4b395411496ebf03c514e7674e8073e0c3
>> 
>> Release Notes:
>> https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.3/CHANGES.md
>> 
>> The artifacts have been signed with Key : 28681CB1, which can be found in 
>> the keys file:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>> 
>> The vote will be open for at least 72 hours or until necessary number of 
>> votes are reached.
>> 
>> Please vote accordingly:
>> [ ] +1 approve 
>> [ ] +0 no opinion 
>> [ ] -1 disapprove with the reason
>> 
>> Thanks.
>> Jun Liu,
>> The Apache Dubbo (Incubating) Team
>> 
>> 
>> -
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>> 
> 
> 
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Ian Luo]

I checked 2.6.3 RC3, it looks good. I've checked:

1. signatures and hashes are good
2. directory is correct in sources
3. DISCLAIMER exists in sources
4.  LICENSE and NOTICE exists in sources
5. files and license header looks good in sources
6. compilation passes
7. unit test can pass on my laptop (OSX and java8)
8. directory is correct in binary
9. LICENSE and NOTICE exists

I vote +1 (non-binding)

-Ian.


On Wed, Aug 15, 2018 at 10:56 AM Jun Liu  wrote:

> Here're some tips of how to verify the RC:
>
> 1. Check signatures and hashes are good
> sha512 dubbo-incubating-${release_version}-bin-release.zip.sha512
> sha512
> dubbo-incubating-${release_version}-source-release.zip.sha512
> gpg2 --keyserver pgpkeys.mit.edu --recv-key 208B0AB1D63011C7
> gpg2 --verify dubbo-incubating-2.6.2-source-release.zip.asc
> dubbo-incubating-2.6.2-source-release.zip
>
> 2. Unzip dubbo-incubating-${release_version}-source-release.zip to the
> default directory and check the following:
> • Directory with 'incubating' in name
> dubbo-incubating-${release_version}-bin-release
> • DISCLAIMER exists
> • LICENSE and NOTICE exists and contents are good
> • All files and no binary files exist
> • All files has standard ASF License header
> • Can compile from source
> • All unit tests can pass
> mvn clean test # This will run all unit tests
> mvn clean install -Drat.skip=false -Dcheckstyle.skip=false
> # Open rat and style plugin to check if every file meets requirements.
> • Release candidates match with corresponding tags, you can find
> tag link and hash in vote email.
>
> 3. Unzip dubbo-incubating-${release_version}-bin-release.zip and check:
> * 'incubating' in name
> * LICENSE and NOTICE exists and contents are good
>
> Best regards,
> Jun
>
> > On 12 Aug 2018, at 15:12, Jun Liu  wrote:
> >
> > Hello All,
> >
> > This is a call for vote to release Apache Dubbo (Incubating) version
> 2.6.3.
> >
> > The Apache Dubbo community has voted on and approved a proposal to
> release Apache Dubbo (Incubating) version 2.6.3.
> >
> > We now kindly request the Incubator PMC members review and vote on this
> incubator release.
> >
> > Apache Dubbo™ (incubating) is a high-performance, java based, open
> source RPC framework. Dubbo offers three key functionalities, which include
> interface based remote call, fault tolerance & load balancing, and
> automatic service registration & discovery.
> >
> > Dubbo community vote thread:
> >
> https://lists.apache.org/thread.html/9e692f525dfbd004e98707ecac33ab10d07741500433a24370e64c67@%3Cdev.dubbo.apache.org%3E
> >
> > Dubbo community vote result thread:
> >
> https://lists.apache.org/thread.html/630d7ed97ca06a341a7c6626c34af52eab42515439f76e0810504533@%3Cdev.dubbo.apache.org%3E
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
> >
> > Git tag for the release:
> > https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
> >
> > Hash for the release tag:
> > 22899a4b395411496ebf03c514e7674e8073e0c3
> >
> > Release Notes:
> > https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.3/CHANGES.md
> >
> > The artifacts have been signed with Key : 28681CB1, which can be found
> in the keys file:
> > https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks.
> > Jun Liu,
> > The Apache Dubbo (Incubating) Team
> >
> >
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Jun Liu]

Here're some tips of how to verify the RC:

1. Check signatures and hashes are good
sha512 dubbo-incubating-${release_version}-bin-release.zip.sha512
sha512 dubbo-incubating-${release_version}-source-release.zip.sha512
gpg2 --keyserver pgpkeys.mit.edu --recv-key 208B0AB1D63011C7
gpg2 --verify dubbo-incubating-2.6.2-source-release.zip.asc 
dubbo-incubating-2.6.2-source-release.zip 
 
2. Unzip dubbo-incubating-${release_version}-source-release.zip to the default 
directory and check the following:
• Directory with 'incubating' in name 
dubbo-incubating-${release_version}-bin-release
• DISCLAIMER exists
• LICENSE and NOTICE exists and contents are good
• All files and no binary files exist
• All files has standard ASF License header
• Can compile from source
• All unit tests can pass
mvn clean test # This will run all unit tests
mvn clean install -Drat.skip=false -Dcheckstyle.skip=false # 
Open rat and style plugin to check if every file meets requirements.
• Release candidates match with corresponding tags, you can find tag 
link and hash in vote email.

3. Unzip dubbo-incubating-${release_version}-bin-release.zip and check:
* 'incubating' in name
* LICENSE and NOTICE exists and contents are good

Best regards,
Jun

> On 12 Aug 2018, at 15:12, Jun Liu  wrote:
> 
> Hello All,
> 
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
> 
> The Apache Dubbo community has voted on and approved a proposal to release 
> Apache Dubbo (Incubating) version 2.6.3.
> 
> We now kindly request the Incubator PMC members review and vote on this 
> incubator release.
> 
> Apache Dubbo™ (incubating) is a high-performance, java based, open source RPC 
> framework. Dubbo offers three key functionalities, which include interface 
> based remote call, fault tolerance & load balancing, and automatic service 
> registration & discovery. 
> 
> Dubbo community vote thread:
> https://lists.apache.org/thread.html/9e692f525dfbd004e98707ecac33ab10d07741500433a24370e64c67@%3Cdev.dubbo.apache.org%3E
> 
> Dubbo community vote result thread:
> https://lists.apache.org/thread.html/630d7ed97ca06a341a7c6626c34af52eab42515439f76e0810504533@%3Cdev.dubbo.apache.org%3E
> 
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
> 
> Git tag for the release:
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
> 
> Hash for the release tag:
> 22899a4b395411496ebf03c514e7674e8073e0c3
> 
> Release Notes:
> https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.3/CHANGES.md
> 
> The artifacts have been signed with Key : 28681CB1, which can be found in the 
> keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
> 
> The vote will be open for at least 72 hours or until necessary number of 
> votes are reached.
> 
> Please vote accordingly:
> [ ] +1 approve 
> [ ] +0 no opinion 
> [ ] -1 disapprove with the reason
> 
> Thanks.
> Jun Liu,
> The Apache Dubbo (Incubating) Team
> 
> 
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

[VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

[Jun Liu]

Hello All,

This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.

The Apache Dubbo community has voted on and approved a proposal to release 
Apache Dubbo (Incubating) version 2.6.3.

We now kindly request the Incubator PMC members review and vote on this 
incubator release.

Apache Dubbo™ (incubating) is a high-performance, java based, open source RPC 
framework. Dubbo offers three key functionalities, which include interface 
based remote call, fault tolerance & load balancing, and automatic service 
registration & discovery. 

Dubbo community vote thread:
https://lists.apache.org/thread.html/9e692f525dfbd004e98707ecac33ab10d07741500433a24370e64c67@%3Cdev.dubbo.apache.org%3E

Dubbo community vote result thread:
https://lists.apache.org/thread.html/630d7ed97ca06a341a7c6626c34af52eab42515439f76e0810504533@%3Cdev.dubbo.apache.org%3E

The release candidates:
https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3

Git tag for the release:
https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3

Hash for the release tag:
22899a4b395411496ebf03c514e7674e8073e0c3

Release Notes:
https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.3/CHANGES.md

The artifacts have been signed with Key : 28681CB1, which can be found in the 
keys file:
https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS

The vote will be open for at least 72 hours or until necessary number of votes 
are reached.

Please vote accordingly:
[ ] +1 approve 
[ ] +0 no opinion 
[ ] -1 disapprove with the reason

Thanks.
Jun Liu,
The Apache Dubbo (Incubating) Team


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org