Re: [VOTE] DataSketches-memory RC2
Hi, > I will do a thorough license search. Ask your mentor for help they will be able to help you with this. > I will try to locate the WIP Disclaimer ... do you have a link? Yes https://incubator.apache.org/policy/incubation.html#disclaimers. There also an email to this list today with the text in a more convenient form. > Right now I am struggling with pom issue related to the > maven-remote-resources-plugin. Hopefully someone with more maven experience than I can help you out here. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] DataSketches-memory RC2
HI, > [*INFO*] Exclude: **/test/resources/**/*.txt That missed one of the files in question, I found it by running rat manually. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] DataSketches-memory RC2
I ran "mvn apache-rat:check" // didn't find anything:
[*INFO*] *--- *apache-rat-plugin:0.12:check *(default-cli)* @
datasketches-memory* ---*
[*INFO*] Enabled default license matchers.
[*INFO*] Will parse SCM ignores for exclusions...
[*INFO*] Parsing exclusions from
/Users/lrhodes/dev/git/Apache/datasketches-memory/.gitignore
[*INFO*] Finished adding exclusions from SCM ignore files.
[*INFO*] 86 implicit excludes (use -debug for more details).
[*INFO*] Exclude: **/test/resources/**/*.txt
[*INFO*] Exclude: LICENSE
[*INFO*] Exclude: NOTICE
[*INFO*] Exclude: DISCLAIMER
[*INFO*] 99 resources included (use -debug for more details)
[*INFO*] Rat check: Summary over all files. Unapproved: 0, unknown: 0,
generated: 0, approved: 99 licenses.
On Thu, Aug 1, 2019 at 10:06 PM leerho wrote:
> Found the WIP Disclaimer.
>
> On Thu, Aug 1, 2019 at 9:58 PM leerho wrote:
>
>> Justin,
>> Thank you so much for your response!
>> ( I feel like I'm in a vacuum at times ... so your help is much
>> appreciated!! )
>>
>> I will do a thorough license search.
>> I will try to locate the WIP Disclaimer ... do you have a link?
>>
>> Right now I am struggling with pom issue related to the
>> maven-remote-resources-plugin.
>> It is creating errors no matter what I do, so I must be doing something
>> wrong:
>>
>>- If I don't have it in pom at all I get the error: "missing required
>>source folder: 'target/maven-shared-archive-resources'
>>- If I include the plugin in the pom project build as:
>>
>>
>> org.apache.maven.plugins
>> maven-remote-resources-plugin
>>
>> ${maven-remote-resources-plugin.version}
>>
>>
>>
>> process
>>
>>
>>
>> Apache DataSketches Memory
>> (incubating)
>>
>>
>>
>> org.apache:apache-jar-resource-bundle:1.5-SNAPSHOT
>>
>> org.apache:apache-incubator-disclaimer-resource-bundle:1.2-SNAPSHOT
>>
>>
>>
>>
>>
>>
>>
>> I get the error: maven-remote-resources-plugin:[1.0,) or one of its
>> dependencies could not be resolved: Failure to find
>> org.apache.maven.plugins:maven-remote-resources-plugin:jar:[1.0,) in
>> https://repo.maven.apache.org/maven2 was cached in the local repository,
>> resolution will not be reattempted until the update interval of central has
>> elapsed or updates are forced.
>>
>> Yet I know I have the above versions in my local .m2 !
>>
>> Changing the versions to 1.4 and 1.1 doesn't help -- still can't find it.
>>
>> Running mvn process-resources doesn't help.
>>
>> Running maven project update from eclipse doesn't help.
>>
>> Now if I place the plug-in into its own profile like this ( found this in
>> a blog ) :
>>
>>
>> m2e
>>
>>
>> m2e.version
>>
>>
>>
>>
>>
>>
>> org.eclipse.m2e
>> lifecycle-mapping
>> ${lifecycle-mapping.version}
>>
>>
>>
>>
>>
>>
>> org.apache.maven.plugins
>>
>> maven-remote-resources-plugin
>>
>> ${maven-remote-resources-plugin.version}
>>
>> process
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> Then if I do a "mvn clean" I am back to the error: "missing required
>> source folder: 'target/maven-shared-archive-resources"
>>
>> Then if I do a "mvn clean process-resources" the errors go away! And I do
>> get the "target/maven-shared-archive-resources" folder with the right
>> stuff.
>>
>> Studying other project is even more confusing: Apache Pinot and Apache
>> Druid have the plugin under project build. (how do they get it to work?)
>>
>> Apache Beam doesn't specify it at all (they use the
>> maven-resources-plugin).
>>
>> Apache Commons-CSV doesn't specify the plugin at all.
>>
>> I am not confident that my placing it in its own profile is the right
>> thing to do, but it is the only thing that seems to work right now, but no
>> other project I have found does it this way.
>>
>> Advice please.
>>
>> Lee.
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
Re: [VOTE] DataSketches-memory RC2
Found the WIP Disclaimer.
On Thu, Aug 1, 2019 at 9:58 PM leerho wrote:
> Justin,
> Thank you so much for your response!
> ( I feel like I'm in a vacuum at times ... so your help is much
> appreciated!! )
>
> I will do a thorough license search.
> I will try to locate the WIP Disclaimer ... do you have a link?
>
> Right now I am struggling with pom issue related to the
> maven-remote-resources-plugin.
> It is creating errors no matter what I do, so I must be doing something
> wrong:
>
>- If I don't have it in pom at all I get the error: "missing required
>source folder: 'target/maven-shared-archive-resources'
>- If I include the plugin in the pom project build as:
>
>
> org.apache.maven.plugins
> maven-remote-resources-plugin
> ${maven-remote-resources-plugin.version}
>
>
>
> process
>
>
>
> Apache DataSketches Memory
> (incubating)
>
>
>
> org.apache:apache-jar-resource-bundle:1.5-SNAPSHOT
>
> org.apache:apache-incubator-disclaimer-resource-bundle:1.2-SNAPSHOT
>
>
>
>
>
>
>
> I get the error: maven-remote-resources-plugin:[1.0,) or one of its
> dependencies could not be resolved: Failure to find
> org.apache.maven.plugins:maven-remote-resources-plugin:jar:[1.0,) in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced.
>
> Yet I know I have the above versions in my local .m2 !
>
> Changing the versions to 1.4 and 1.1 doesn't help -- still can't find it.
>
> Running mvn process-resources doesn't help.
>
> Running maven project update from eclipse doesn't help.
>
> Now if I place the plug-in into its own profile like this ( found this in
> a blog ) :
>
>
> m2e
>
>
> m2e.version
>
>
>
>
>
>
> org.eclipse.m2e
> lifecycle-mapping
> ${lifecycle-mapping.version}
>
>
>
>
>
>
> org.apache.maven.plugins
>
> maven-remote-resources-plugin
>
> ${maven-remote-resources-plugin.version}
>
> process
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> Then if I do a "mvn clean" I am back to the error: "missing required
> source folder: 'target/maven-shared-archive-resources"
>
> Then if I do a "mvn clean process-resources" the errors go away! And I do
> get the "target/maven-shared-archive-resources" folder with the right
> stuff.
>
> Studying other project is even more confusing: Apache Pinot and Apache
> Druid have the plugin under project build. (how do they get it to work?)
>
> Apache Beam doesn't specify it at all (they use the
> maven-resources-plugin).
>
> Apache Commons-CSV doesn't specify the plugin at all.
>
> I am not confident that my placing it in its own profile is the right
> thing to do, but it is the only thing that seems to work right now, but no
> other project I have found does it this way.
>
> Advice please.
>
> Lee.
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> On Thu, Aug 1, 2019 at 7:26 PM Justin Mclean
> wrote:
>
>> Hi,
>>
>> > I have fixed the LICENSE file as you requested.
>>
>> I hope you noticed that a couple of the files included multiple,
>> differently licensed, pieces of 3rd party code. Each license needs to be
>> listed and checked if it is compatible with the Apache License. If Apache
>> LIcense you need to check if they have a NOTICE file and copy it’s contents
>> into your NOTICE file.
>>
>> > Is it OK if these fixes go into the next release?
>>
>> Sure, as always you can make a release if you get 3 or more +1 votes, and
>> more +1 than -1 votes. You have no -1 votes, and I believe more than 3 +1
>> votes form IPMC members, 72 hours have passed so you are all good to go.
>>
>> Not however the recent discussion around a work in progress disclaimer,
>> you might want to move to using that rather than the standard disclaimer.
>>
>> You might want to make sure there ar
Re: [VOTE] DataSketches-memory RC2
Justin,
Thank you so much for your response!
( I feel like I'm in a vacuum at times ... so your help is much
appreciated!! )
I will do a thorough license search.
I will try to locate the WIP Disclaimer ... do you have a link?
Right now I am struggling with pom issue related to the
maven-remote-resources-plugin.
It is creating errors no matter what I do, so I must be doing something
wrong:
- If I don't have it in pom at all I get the error: "missing required
source folder: 'target/maven-shared-archive-resources'
- If I include the plugin in the pom project build as:
org.apache.maven.plugins
maven-remote-resources-plugin
${maven-remote-resources-plugin.version}
process
Apache DataSketches Memory
(incubating)
org.apache:apache-jar-resource-bundle:1.5-SNAPSHOT
org.apache:apache-incubator-disclaimer-resource-bundle:1.2-SNAPSHOT
I get the error: maven-remote-resources-plugin:[1.0,) or one of its
dependencies could not be resolved: Failure to find
org.apache.maven.plugins:maven-remote-resources-plugin:jar:[1.0,) in
https://repo.maven.apache.org/maven2 was cached in the local repository,
resolution will not be reattempted until the update interval of central has
elapsed or updates are forced.
Yet I know I have the above versions in my local .m2 !
Changing the versions to 1.4 and 1.1 doesn't help -- still can't find it.
Running mvn process-resources doesn't help.
Running maven project update from eclipse doesn't help.
Now if I place the plug-in into its own profile like this ( found this in a
blog ) :
m2e
m2e.version
org.eclipse.m2e
lifecycle-mapping
${lifecycle-mapping.version}
org.apache.maven.plugins
maven-remote-resources-plugin
${maven-remote-resources-plugin.version}
process
Then if I do a "mvn clean" I am back to the error: "missing required source
folder: 'target/maven-shared-archive-resources"
Then if I do a "mvn clean process-resources" the errors go away! And I do
get the "target/maven-shared-archive-resources" folder with the right
stuff.
Studying other project is even more confusing: Apache Pinot and Apache
Druid have the plugin under project build. (how do they get it to work?)
Apache Beam doesn't specify it at all (they use the maven-resources-plugin).
Apache Commons-CSV doesn't specify the plugin at all.
I am not confident that my placing it in its own profile is the right thing
to do, but it is the only thing that seems to work right now, but no other
project I have found does it this way.
Advice please.
Lee.
On Thu, Aug 1, 2019 at 7:26 PM Justin Mclean
wrote:
> Hi,
>
> > I have fixed the LICENSE file as you requested.
>
> I hope you noticed that a couple of the files included multiple,
> differently licensed, pieces of 3rd party code. Each license needs to be
> listed and checked if it is compatible with the Apache License. If Apache
> LIcense you need to check if they have a NOTICE file and copy it’s contents
> into your NOTICE file.
>
> > Is it OK if these fixes go into the next release?
>
> Sure, as always you can make a release if you get 3 or more +1 votes, and
> more +1 than -1 votes. You have no -1 votes, and I believe more than 3 +1
> votes form IPMC members, 72 hours have passed so you are all good to go.
>
> Not however the recent discussion around a work in progress disclaimer,
> you might want to move to using that rather than the standard disclaimer.
>
> You might want to make sure there are not other issues, I didn’t do a full
> check of what was in the release. I’d suggest running rat on it (which
> found some issues) and search for copyright statements or URLs that
> reference GitHub or other repos.
>
> Thanks,
> Justin
>
>
> -
> To unsubscribe, e-mail: gene
Re: [VOTE] DataSketches-memory RC2
Hi, > I have fixed the LICENSE file as you requested. I hope you noticed that a couple of the files included multiple, differently licensed, pieces of 3rd party code. Each license needs to be listed and checked if it is compatible with the Apache License. If Apache LIcense you need to check if they have a NOTICE file and copy it’s contents into your NOTICE file. > Is it OK if these fixes go into the next release? Sure, as always you can make a release if you get 3 or more +1 votes, and more +1 than -1 votes. You have no -1 votes, and I believe more than 3 +1 votes form IPMC members, 72 hours have passed so you are all good to go. Not however the recent discussion around a work in progress disclaimer, you might want to move to using that rather than the standard disclaimer. You might want to make sure there are not other issues, I didn’t do a full check of what was in the release. I’d suggest running rat on it (which found some issues) and search for copyright statements or URLs that reference GitHub or other repos. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] DataSketches-memory RC2
Justin, Thank you for finding these. I have fixed the LICENSE file as you requested. I have deleted the stylesheet.css as it is no longer needed. The Gettysburg Address is public domain and indicated so in the License file. All the other files have corrected notices and are also listed in the LICENSE file. These are the only files that I am aware of that had these issues. The README file has a "compile with Java 1.8." notice. Is it OK if these fixes go into the next release? That is, may we continue with the current RC2 release we just voted on? Lee. On Thu, Aug 1, 2019 at 3:45 PM Justin Mclean wrote: > Hi, > > Can you please fix up your LICENSE file, the source release contains a > number of 3rd party content (not al of which is under an ALv2 license) but > none it it is mentioned in LICENSE. You are also not binding by the terms > of some of those licenses (i.e. they require you to include the license > text). > > For example [1][2][3][4][5][6][7][8][9], there may be other files. [4] > may incorrectly have an ASF header on the file. > > Thanks, > Justin > > 1. ./src/test/java/org/apache/datasketches/memory/IsValidUtf8TestUtil.java > 2. ./src/test/java/org/apache/datasketches/memory/Utf8Test.java > 3. ./src/main/java/org/apache/datasketches/memory/Utf8.java > 4. ./src/main/javadoc/stylesheet.css > 5. ./src/test/resources/GettysburgAddress.txt > 6. ./src/test/java/org/apache/datasketches/memory/XxHash64Test.java > 7. ./src/test/java/org/apache/datasketches/memory/XxHash64LoopingTest.java > 8. ./src/main/java/org/apache/datasketches/memory/XxHash64.java > 9 ./src/main/java/org/apache/datasketches/memory/AccessByteBuffer.java > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] DataSketches-memory RC2
Hi, Can you please fix up your LICENSE file, the source release contains a number of 3rd party content (not al of which is under an ALv2 license) but none it it is mentioned in LICENSE. You are also not binding by the terms of some of those licenses (i.e. they require you to include the license text). For example [1][2][3][4][5][6][7][8][9], there may be other files. [4] may incorrectly have an ASF header on the file. Thanks, Justin 1. ./src/test/java/org/apache/datasketches/memory/IsValidUtf8TestUtil.java 2. ./src/test/java/org/apache/datasketches/memory/Utf8Test.java 3. ./src/main/java/org/apache/datasketches/memory/Utf8.java 4. ./src/main/javadoc/stylesheet.css 5. ./src/test/resources/GettysburgAddress.txt 6. ./src/test/java/org/apache/datasketches/memory/XxHash64Test.java 7. ./src/test/java/org/apache/datasketches/memory/XxHash64LoopingTest.java 8. ./src/main/java/org/apache/datasketches/memory/XxHash64.java 9 ./src/main/java/org/apache/datasketches/memory/AccessByteBuffer.java - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] DataSketches-memory RC2
Ted, I upgraded Maven to 3.6.1 -- now I see the warning above. I think I understand, after some research..., the new Maven doesn't like the ... style of specifying what Maven to use, it want us to use the Maven enforcer plugin instead. Jeez, the error message could have just said that. On Thu, Aug 1, 2019 at 1:01 PM leerho wrote: > Thank you Furkan KAMACI, Greg Stein, and Ted Dunning. You all responded > within a one hour window! > > Ted, > > [*WARNING*] The >> project org.apache.datasketches:datasketches-memory:jar:1.0.0-incubating >> uses >> prerequisites which is only intended for maven-plugin projects but not >> for non maven-plugin projects. >> For such purposes you should use the maven-enforcer-plugin. See >> https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html > > > I have never seen this warning. > Which prerequisite is it complaining about? What exactly is the > conflict? > The link points to a Require Maven Version rule. > I am using Maven 3.3.9. > The pom specifies a prerequisite of Maven 3.0.4, which I assume means a > minimum of 3.0.4. Is this not an enforcement? > It appears you are using Maven 3.6.1. > Is it a problem to be running a newer version of maven than 3.0.4 ? > Do we need to "enforce" the Maven version as long as it is > 3.0.4 ? > How can I reproduce this warning? (run a new version of Maven ?? ) > > The maven-compiler-plugin is configured to use java version 1.8 for both > source and target. > Apparently, you are saying that this configuration is not being enforced > when you ran mvn clean test! > > Clearly, if this is the case, we need the enforcer plugin for the JVM > version! > > This is an eye-opener for me. Thank you for catching this! > > Lee. > > > > > > > > > > > > > On Thu, Aug 1, 2019 at 11:54 AM Ted Dunning wrote: > >> +1 (binding) >> >> As a side comment, I know that you said it in your second email, but the >> restriction to *exactly* java 1.8 isn't clear from the README. Also, it is >> easy to *think* you have changed which version of java you are using, but >> not actually have done so. For an example of how this illusion can play >> out, see below. >> >> It would be good if you could actually detect the version mismatch and >> fail >> early with a coherent message. This can be done with the enforcer plugin >> (see >> https://maven.apache.org/enforcer/enforcer-rules/requireJavaVersion.html >> ) >> >> $ java -version >> >> openjdk version "1.8.0_222" >> >> OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_222-b10) >> >> OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.222-b10, mixed mode) >> >> >> $ javac -version >> >> javac 1.8.0_222 >> >> >> $ mvn clean test >> >> [*INFO*] Scanning for projects... >> >> [*WARNING*] The project >> org.apache.datasketches:datasketches-memory:jar:1.0.0-incubating uses >> prerequisites which is only intended for maven-plugin projects but not for >> non maven-plugin projects. For such purposes you should use the >> maven-enforcer-plugin. See >> https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html >> >> [*INFO*] >> >> ... >> >> [*INFO*] - >> >> [*WARNING*] COMPILATION WARNING : >> >> [*INFO*] - >> >> [*WARNING*] >> >> /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/UnsafeUtil.java:[25,16] >> sun.misc.Unsafe is internal proprietary API and may be removed in a future >> release >> >> [*WARNING*] >> >> /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/AllocateDirectMap.java:[37,18] >> sun.nio.ch.FileChannelImpl is internal proprietary API and may be removed >> in a future release >> >> ... >> >> [*INFO*] 8 warnings >> >> [*INFO*] - >> >> [*INFO*] - >> >> [*ERROR*] COMPILATION ERROR : >> >> [*INFO*] - >> >> [*ERROR*] >> >> /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/AllocateDirect.java:[27,16] >> cannot find symbol >> >> symbol: class Cleaner >> >> location: package sun.misc >> >> [*ERROR*] >> >> /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/AllocateDirect.java:[39,17] >> cannot find symbol >> >> symbol: class Cleaner >> >> location: class ... >> >> [*INFO*] 6 errors >> >> [*INFO*] - >> >> [*INFO*] >> ** >> >> [*INFO*] *BUILD FAILURE* >> >> [*INFO*] >> ** >> >> [*INFO*] Total time: 3.676 s >> >> [*INFO*] Finished at: 2019-08-01T11:44:50-07:00 >> >> ... >> >> $
Re: [VOTE] DataSketches-memory RC2
Thank you Furkan KAMACI, Greg Stein, and Ted Dunning. You all responded within a one hour window! Ted, [*WARNING*] The > project org.apache.datasketches:datasketches-memory:jar:1.0.0-incubating > uses > prerequisites which is only intended for maven-plugin projects but not > for non maven-plugin projects. > For such purposes you should use the maven-enforcer-plugin. See > https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html I have never seen this warning. Which prerequisite is it complaining about? What exactly is the conflict? The link points to a Require Maven Version rule. I am using Maven 3.3.9. The pom specifies a prerequisite of Maven 3.0.4, which I assume means a minimum of 3.0.4. Is this not an enforcement? It appears you are using Maven 3.6.1. Is it a problem to be running a newer version of maven than 3.0.4 ? Do we need to "enforce" the Maven version as long as it is > 3.0.4 ? How can I reproduce this warning? (run a new version of Maven ?? ) The maven-compiler-plugin is configured to use java version 1.8 for both source and target. Apparently, you are saying that this configuration is not being enforced when you ran mvn clean test! Clearly, if this is the case, we need the enforcer plugin for the JVM version! This is an eye-opener for me. Thank you for catching this! Lee. On Thu, Aug 1, 2019 at 11:54 AM Ted Dunning wrote: > +1 (binding) > > As a side comment, I know that you said it in your second email, but the > restriction to *exactly* java 1.8 isn't clear from the README. Also, it is > easy to *think* you have changed which version of java you are using, but > not actually have done so. For an example of how this illusion can play > out, see below. > > It would be good if you could actually detect the version mismatch and fail > early with a coherent message. This can be done with the enforcer plugin > (see > https://maven.apache.org/enforcer/enforcer-rules/requireJavaVersion.html ) > > $ java -version > > openjdk version "1.8.0_222" > > OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_222-b10) > > OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.222-b10, mixed mode) > > > $ javac -version > > javac 1.8.0_222 > > > $ mvn clean test > > [*INFO*] Scanning for projects... > > [*WARNING*] The project > org.apache.datasketches:datasketches-memory:jar:1.0.0-incubating uses > prerequisites which is only intended for maven-plugin projects but not for > non maven-plugin projects. For such purposes you should use the > maven-enforcer-plugin. See > https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html > > [*INFO*] > > ... > > [*INFO*] - > > [*WARNING*] COMPILATION WARNING : > > [*INFO*] - > > [*WARNING*] > > /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/UnsafeUtil.java:[25,16] > sun.misc.Unsafe is internal proprietary API and may be removed in a future > release > > [*WARNING*] > > /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/AllocateDirectMap.java:[37,18] > sun.nio.ch.FileChannelImpl is internal proprietary API and may be removed > in a future release > > ... > > [*INFO*] 8 warnings > > [*INFO*] - > > [*INFO*] - > > [*ERROR*] COMPILATION ERROR : > > [*INFO*] - > > [*ERROR*] > > /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/AllocateDirect.java:[27,16] > cannot find symbol > > symbol: class Cleaner > > location: package sun.misc > > [*ERROR*] > > /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/AllocateDirect.java:[39,17] > cannot find symbol > > symbol: class Cleaner > > location: class ... > > [*INFO*] 6 errors > > [*INFO*] - > > [*INFO*] > ** > > [*INFO*] *BUILD FAILURE* > > [*INFO*] > ** > > [*INFO*] Total time: 3.676 s > > [*INFO*] Finished at: 2019-08-01T11:44:50-07:00 > > ... > > $ > > > The problem is that maven is ignoring all efforts to specify a different > JDK, of course, as shown here: > > $ mvn -version > > *Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; > 2019-04-04T12:00:29-07:00)* > > Maven home: /usr/local/Cellar/maven/3.6.1/libexec > > Java version: 12.0.2, vendor: AdoptOpenJDK, runtime: > /Library/Java/JavaVirtualMachines/adoptopenjdk-12.0.2.jdk/Contents/Home > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "mac os x", version: "10.14.6", arch: "x86_64",
Re: [VOTE] DataSketches-memory RC2
+1 (binding) As a side comment, I know that you said it in your second email, but the restriction to *exactly* java 1.8 isn't clear from the README. Also, it is easy to *think* you have changed which version of java you are using, but not actually have done so. For an example of how this illusion can play out, see below. It would be good if you could actually detect the version mismatch and fail early with a coherent message. This can be done with the enforcer plugin (see https://maven.apache.org/enforcer/enforcer-rules/requireJavaVersion.html ) $ java -version openjdk version "1.8.0_222" OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_222-b10) OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.222-b10, mixed mode) $ javac -version javac 1.8.0_222 $ mvn clean test [*INFO*] Scanning for projects... [*WARNING*] The project org.apache.datasketches:datasketches-memory:jar:1.0.0-incubating uses prerequisites which is only intended for maven-plugin projects but not for non maven-plugin projects. For such purposes you should use the maven-enforcer-plugin. See https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html [*INFO*] ... [*INFO*] - [*WARNING*] COMPILATION WARNING : [*INFO*] - [*WARNING*] /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/UnsafeUtil.java:[25,16] sun.misc.Unsafe is internal proprietary API and may be removed in a future release [*WARNING*] /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/AllocateDirectMap.java:[37,18] sun.nio.ch.FileChannelImpl is internal proprietary API and may be removed in a future release ... [*INFO*] 8 warnings [*INFO*] - [*INFO*] - [*ERROR*] COMPILATION ERROR : [*INFO*] - [*ERROR*] /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/AllocateDirect.java:[27,16] cannot find symbol symbol: class Cleaner location: package sun.misc [*ERROR*] /Users/tdunning/Apache/incubator-datasketches-memory/src/main/java/org/apache/datasketches/memory/AllocateDirect.java:[39,17] cannot find symbol symbol: class Cleaner location: class ... [*INFO*] 6 errors [*INFO*] - [*INFO*] ** [*INFO*] *BUILD FAILURE* [*INFO*] ** [*INFO*] Total time: 3.676 s [*INFO*] Finished at: 2019-08-01T11:44:50-07:00 ... $ The problem is that maven is ignoring all efforts to specify a different JDK, of course, as shown here: $ mvn -version *Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T12:00:29-07:00)* Maven home: /usr/local/Cellar/maven/3.6.1/libexec Java version: 12.0.2, vendor: AdoptOpenJDK, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-12.0.2.jdk/Contents/Home Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" On Thu, Aug 1, 2019 at 10:59 AM Greg Stein wrote: > +1 (binding) > > > On Mon, Jul 29, 2019 at 12:09 AM leerho wrote: > > > Hello Apache general@incubator community. > > > > 1. This is a call for vote to release Apache DataSketches-memory version: > > 1.0.0-incubating-RC2 > > > > NOTE 1: This is one component of the DataSketches library which needs to > be > > released first as other repositories have a dependency on this one. Once > > this is released, the other components of the library will be able to be > > released. > > > > > > 2. Results from the PPMC vote (open for more than 102 hours not counting > > the weekend) > > > > - 5 votes were cast. All of the votes were (+1). Two of the votes were > > from Mentors. > > > > - The vote thread can be found at: > > > > > https://mail-archives.apache.org/mod_mbox/datasketches-dev/201907.mbox/browser > > > > > > 3. Testing/actions/votes performed by the voters: > > > > - Lee Rhodes: (+1) > > - All of the code has been properly refactored with > > "org.apache.datasketches...". > > - All source files have the proper Apache license and have been > checked > > with the Maven Rat Plugin. > > - The code passes all tests with a coverage of > 98%. > > - Checkstyle: passes with no warnings. This uses the configuration > > MemoryCheckstyle.xml located in the /tools/ directory. > > - SpotBugs: passes with no bugs found: This uses the configuration > > FindBugsExcludeFilter.xml located in the /tools/directory. > > - mvn clean javadoc:javadoc produces no javadoc errors. The javadocs > > will be found under /target
Re: [VOTE] DataSketches-memory RC2
+1 (binding) On Mon, Jul 29, 2019 at 12:09 AM leerho wrote: > Hello Apache general@incubator community. > > 1. This is a call for vote to release Apache DataSketches-memory version: > 1.0.0-incubating-RC2 > > NOTE 1: This is one component of the DataSketches library which needs to be > released first as other repositories have a dependency on this one. Once > this is released, the other components of the library will be able to be > released. > > > 2. Results from the PPMC vote (open for more than 102 hours not counting > the weekend) > > - 5 votes were cast. All of the votes were (+1). Two of the votes were > from Mentors. > > - The vote thread can be found at: > > https://mail-archives.apache.org/mod_mbox/datasketches-dev/201907.mbox/browser > > > 3. Testing/actions/votes performed by the voters: > > - Lee Rhodes: (+1) > - All of the code has been properly refactored with > "org.apache.datasketches...". > - All source files have the proper Apache license and have been checked > with the Maven Rat Plugin. > - The code passes all tests with a coverage of > 98%. > - Checkstyle: passes with no warnings. This uses the configuration > MemoryCheckstyle.xml located in the /tools/ directory. > - SpotBugs: passes with no bugs found: This uses the configuration > FindBugsExcludeFilter.xml located in the /tools/directory. > - mvn clean javadoc:javadoc produces no javadoc errors. The javadocs > will be found under /target/site/ > - mvn versions:display-plugin-updates. This has 2 warnings, but the > versions are inherited from the super-pom. >- [WARNING] The following plugins do not have their version > specified: >- [WARNING] maven-assembly-plugin . (from > super-pom) 2.6 >- [WARNING] maven-compiler-plugin . (from > super-pom) 3.5. >Note: In the next release we can add the version numbers to the > local pom to eliminate this warning. > - The assembly file signatures and checksums have been verified. > > - Alex Saydakov: (+1) > - mvn package > - mvn test > > - Jon Malkin: (+1) > - mvn test > - mvn install > > - Furkan Kamaci (+1 IPMC Member) > - incubating in name > - Disclamer exists > - License is fine > - Notice is fine > - no unexpected binary files > - code compiles and tests successfully run > > - Kenneth Knowles (+1 IPMC Member) > Double checked: > - DISCLAIMER, LICENSE and NOTICE > - mvn install succeeded > > > 4. Source repository: > https://github.com/apache/incubator-datasketches-memory > > - Git Tag for this release: 1.0.0-incubating-RC2 > > > https://github.com/apache/incubator-datasketches-memory/tree/1.0.0-incubating-RC2 > > - Git HashId for this release starts with: ec8f16e > > > 5. DIST/DEV: The release candidate assembly: > > - > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/memory/1.0.0-incubating-RC2/apache-datasketches-memory-1.0.0-incubating-src.zip > > - The assembly file has been signed with --keyid-format SHORT : 8CD4A902 > > - The public signing key can be found in the KEYS file: > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS > > - Upon acceptance, the above assembly and signatures will be deployed > into the official Apache release repository: > > https://dist.apache.org/repos/dist/release/incubator/datasketches/memory/ > > > 6. NEXUS: The Jar and pom attributes have been deployed to Nexus Staging > Repository "orgapachedatasketches-1000", which can be examined from the > Nexus UI. > >- Upon acceptance, the staging repository holding the artifacts will be > closed and then the artifacts will be released. > > > 7. Note that Mentors k...@apache.org and furkankam...@gmail.com as well as > pa...@asert.com.au have made a number of valuable suggestions on improving > the process that are recorded in a separate thread. None of the > suggestions impact the voting for this release. This has been valuable > learning for us and we will be implementing these suggestions in the next > release. > > Lee > lee...@apache.org >
Re: [VOTE] DataSketches-memory RC2
Hi, +1 from me. I checked: - Incubating in name - Disclaimer exists - LICENSE is fine - NOTICE is fine - No unexpected binary files - Code compiles and tests successfully run Kind Regards, Furkan KAMACI On Mon, Jul 29, 2019 at 7:01 PM leerho wrote: > Additional information accidentally omitted from the vote letter: > > 8. Build Guide: > > The DataSketches-memory component is pure Java and is structured as a Maven > project. You must compile using JDK 8. There is one run-time dependency > and, of course, a number of test and Maven plugin dependencies, all of > which can be resolved by Maven. > > This component is a set of low-level library functions that is used by the > other DataSketches components. It has no user interface so the only thing > you can do is compile and run the unit tests. > There are two types of tests: normal unit tests and tests run by the strict > profile. To run normal unit tests: > > $ mvn clean test > > To run the strict profile tests: > > $ mvn clean test -P strict > > Note also that when running the test suite, you might get the following > message: > > SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". > SLF4J: Defaulting to no-operation (NOP) logger implementation > SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for > further > details. > > This is normal. It just indicates that in your environment, you do not > have a logger in your class-path so the default logger of a no-op is used > instead. > > To install jars in your local .m2 repository: > > $ mvn clean install > > If you are interested in the actual functions of the Memory, you will need > to write some code that calls the Memory functions. > > 9. The documentation for the DataSketches Memory component is part of the > website. > > Overview documentation: > - https://datasketches.github.io/docs/Memory/MemoryPackage.html > - https://datasketches.github.io/docs/Memory/MemoryPerformance.html > > Javadocs: > https://datasketches.github.io/api/memory/snapshot/apidocs/index.html > > This Memory component has been split out from the rest of the DataSketches > code because there have been a number of requests from folks that are > interested in these high-performance functions independently of the > remainder of the DataSketches library. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Thanks, > Lee > lee...@apache.org > > On Sun, Jul 28, 2019 at 10:09 PM leerho wrote: > > > Hello Apache general@incubator community. > > > > 1. This is a call for vote to release Apache DataSketches-memory version: > > 1.0.0-incubating-RC2 > > > > NOTE 1: This is one component of the DataSketches library which needs to > > be released first as other repositories have a dependency on this one. > Once > > this is released, the other components of the library will be able to be > > released. > > > > > > 2. Results from the PPMC vote (open for more than 102 hours not counting > > the weekend) > > > > - 5 votes were cast. All of the votes were (+1). Two of the votes were > > from Mentors. > > > > - The vote thread can be found at: > > > https://mail-archives.apache.org/mod_mbox/datasketches-dev/201907.mbox/browser > > > > > > 3. Testing/actions/votes performed by the voters: > > > > - Lee Rhodes: (+1) > > - All of the code has been properly refactored with > > "org.apache.datasketches...". > > - All source files have the proper Apache license and have been > > checked with the Maven Rat Plugin. > > - The code passes all tests with a coverage of > 98%. > > - Checkstyle: passes with no warnings. This uses the configuration > > MemoryCheckstyle.xml located in the /tools/ directory. > > - SpotBugs: passes with no bugs found: This uses the configuration > > FindBugsExcludeFilter.xml located in the /tools/directory. > > - mvn clean javadoc:javadoc produces no javadoc errors. The javadocs > > will be found under /target/site/ > > - mvn versions:display-plugin-updates. This has 2 warnings, but the > > versions are inherited from the super-pom. > >- [WARNING] The following plugins do not have their version > > specified: > >- [WARNING] maven-assembly-plugin . (from > > super-pom) 2.6 > >- [WARNING] maven-compiler-plugin . (from > > super-pom) 3.5. > >Note: In the next release we can add the version numbers to the > > local pom to eliminate this warning. > > - The assembly file signatures and checksums have been verified. > > > > - Alex Saydakov: (+1) > > - mvn package > > - mvn test > > > > - Jon Malkin: (+1) > > - mvn test > > - mvn install > > > > - Furkan Kamaci (+1 IPMC Member) > > - incubating in name > > - Disclamer exists > > - License is fine > > - Notice is fine > > - no unexpected binary files > > - code compiles and tests successfully run > > > > - Kenneth Knowles (+1 IPMC Member)
Re: [VOTE] DataSketches-memory RC2
Additional information accidentally omitted from the vote letter: 8. Build Guide: The DataSketches-memory component is pure Java and is structured as a Maven project. You must compile using JDK 8. There is one run-time dependency and, of course, a number of test and Maven plugin dependencies, all of which can be resolved by Maven. This component is a set of low-level library functions that is used by the other DataSketches components. It has no user interface so the only thing you can do is compile and run the unit tests. There are two types of tests: normal unit tests and tests run by the strict profile. To run normal unit tests: $ mvn clean test To run the strict profile tests: $ mvn clean test -P strict Note also that when running the test suite, you might get the following message: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. This is normal. It just indicates that in your environment, you do not have a logger in your class-path so the default logger of a no-op is used instead. To install jars in your local .m2 repository: $ mvn clean install If you are interested in the actual functions of the Memory, you will need to write some code that calls the Memory functions. 9. The documentation for the DataSketches Memory component is part of the website. Overview documentation: - https://datasketches.github.io/docs/Memory/MemoryPackage.html - https://datasketches.github.io/docs/Memory/MemoryPerformance.html Javadocs: https://datasketches.github.io/api/memory/snapshot/apidocs/index.html This Memory component has been split out from the rest of the DataSketches code because there have been a number of requests from folks that are interested in these high-performance functions independently of the remainder of the DataSketches library. Please vote accordingly: [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove with the reason Thanks, Lee lee...@apache.org On Sun, Jul 28, 2019 at 10:09 PM leerho wrote: > Hello Apache general@incubator community. > > 1. This is a call for vote to release Apache DataSketches-memory version: > 1.0.0-incubating-RC2 > > NOTE 1: This is one component of the DataSketches library which needs to > be released first as other repositories have a dependency on this one. Once > this is released, the other components of the library will be able to be > released. > > > 2. Results from the PPMC vote (open for more than 102 hours not counting > the weekend) > > - 5 votes were cast. All of the votes were (+1). Two of the votes were > from Mentors. > > - The vote thread can be found at: > https://mail-archives.apache.org/mod_mbox/datasketches-dev/201907.mbox/browser > > > 3. Testing/actions/votes performed by the voters: > > - Lee Rhodes: (+1) > - All of the code has been properly refactored with > "org.apache.datasketches...". > - All source files have the proper Apache license and have been > checked with the Maven Rat Plugin. > - The code passes all tests with a coverage of > 98%. > - Checkstyle: passes with no warnings. This uses the configuration > MemoryCheckstyle.xml located in the /tools/ directory. > - SpotBugs: passes with no bugs found: This uses the configuration > FindBugsExcludeFilter.xml located in the /tools/directory. > - mvn clean javadoc:javadoc produces no javadoc errors. The javadocs > will be found under /target/site/ > - mvn versions:display-plugin-updates. This has 2 warnings, but the > versions are inherited from the super-pom. >- [WARNING] The following plugins do not have their version > specified: >- [WARNING] maven-assembly-plugin . (from > super-pom) 2.6 >- [WARNING] maven-compiler-plugin . (from > super-pom) 3.5. >Note: In the next release we can add the version numbers to the > local pom to eliminate this warning. > - The assembly file signatures and checksums have been verified. > > - Alex Saydakov: (+1) > - mvn package > - mvn test > > - Jon Malkin: (+1) > - mvn test > - mvn install > > - Furkan Kamaci (+1 IPMC Member) > - incubating in name > - Disclamer exists > - License is fine > - Notice is fine > - no unexpected binary files > - code compiles and tests successfully run > > - Kenneth Knowles (+1 IPMC Member) > Double checked: > - DISCLAIMER, LICENSE and NOTICE > - mvn install succeeded > > > 4. Source repository: > https://github.com/apache/incubator-datasketches-memory > > - Git Tag for this release: 1.0.0-incubating-RC2 > > https://github.com/apache/incubator-datasketches-memory/tree/1.0.0-incubating-RC2 > > - Git HashId for this release starts with: ec8f16e > > > 5. DIST/DEV: The release candidate assembly: > > - > https://dist.apache.org/repos/dist/dev/incubator/datasketches/
[VOTE] DataSketches-memory RC2
Hello Apache general@incubator community. 1. This is a call for vote to release Apache DataSketches-memory version: 1.0.0-incubating-RC2 NOTE 1: This is one component of the DataSketches library which needs to be released first as other repositories have a dependency on this one. Once this is released, the other components of the library will be able to be released. 2. Results from the PPMC vote (open for more than 102 hours not counting the weekend) - 5 votes were cast. All of the votes were (+1). Two of the votes were from Mentors. - The vote thread can be found at: https://mail-archives.apache.org/mod_mbox/datasketches-dev/201907.mbox/browser 3. Testing/actions/votes performed by the voters: - Lee Rhodes: (+1) - All of the code has been properly refactored with "org.apache.datasketches...". - All source files have the proper Apache license and have been checked with the Maven Rat Plugin. - The code passes all tests with a coverage of > 98%. - Checkstyle: passes with no warnings. This uses the configuration MemoryCheckstyle.xml located in the /tools/ directory. - SpotBugs: passes with no bugs found: This uses the configuration FindBugsExcludeFilter.xml located in the /tools/directory. - mvn clean javadoc:javadoc produces no javadoc errors. The javadocs will be found under /target/site/ - mvn versions:display-plugin-updates. This has 2 warnings, but the versions are inherited from the super-pom. - [WARNING] The following plugins do not have their version specified: - [WARNING] maven-assembly-plugin . (from super-pom) 2.6 - [WARNING] maven-compiler-plugin . (from super-pom) 3.5. Note: In the next release we can add the version numbers to the local pom to eliminate this warning. - The assembly file signatures and checksums have been verified. - Alex Saydakov: (+1) - mvn package - mvn test - Jon Malkin: (+1) - mvn test - mvn install - Furkan Kamaci (+1 IPMC Member) - incubating in name - Disclamer exists - License is fine - Notice is fine - no unexpected binary files - code compiles and tests successfully run - Kenneth Knowles (+1 IPMC Member) Double checked: - DISCLAIMER, LICENSE and NOTICE - mvn install succeeded 4. Source repository: https://github.com/apache/incubator-datasketches-memory - Git Tag for this release: 1.0.0-incubating-RC2 https://github.com/apache/incubator-datasketches-memory/tree/1.0.0-incubating-RC2 - Git HashId for this release starts with: ec8f16e 5. DIST/DEV: The release candidate assembly: - https://dist.apache.org/repos/dist/dev/incubator/datasketches/memory/1.0.0-incubating-RC2/apache-datasketches-memory-1.0.0-incubating-src.zip - The assembly file has been signed with --keyid-format SHORT : 8CD4A902 - The public signing key can be found in the KEYS file: https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS - Upon acceptance, the above assembly and signatures will be deployed into the official Apache release repository: https://dist.apache.org/repos/dist/release/incubator/datasketches/memory/ 6. NEXUS: The Jar and pom attributes have been deployed to Nexus Staging Repository "orgapachedatasketches-1000", which can be examined from the Nexus UI. - Upon acceptance, the staging repository holding the artifacts will be closed and then the artifacts will be released. 7. Note that Mentors k...@apache.org and furkankam...@gmail.com as well as pa...@asert.com.au have made a number of valuable suggestions on improving the process that are recorded in a separate thread. None of the suggestions impact the voting for this release. This has been valuable learning for us and we will be implementing these suggestions in the next release. Lee lee...@apache.org
