Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-23 Thread Maxime Beauchemin
Ok, I have an RC2 ready to go with very minor changes, will kick off [only] a general@ vote and tell dev@ & PPMC they can vote on general@ Max On Thu, Aug 22, 2019 at 11:44 AM Julian Feinauer < j.feina...@pragmaticminds.de> wrote: > Hi, > > I agree with Alan that its really minor but as the sign

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-22 Thread Julian Feinauer
Hi, I agree with Alan that its really minor but as the signatures will change I would prefer another Vote to have this checked. If you (as Justin suggests) state your changes clearly in the thread I think everybody will easily carry over the vote from the previous thread so its just about waiti

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-22 Thread Alan Gates
I would call a revote over that, it's not like you're changing anything of import. I'd just regen the package with the change, create the new hash, and let everyone know. I don't see any reason to drag back through the voting process on two lists over this. Alan. On Wed, Aug 21, 2019 at 10:43 P

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-22 Thread Craig Russell
Hi Justin, > On Aug 21, 2019, at 10:42 PM, Justin Mclean wrote: > > Hi, > ... >> Oh, mentors, quick question about the [RESULT] post, do I account for both >> threads (dev@+general@) in it, or just the general@ one? > > Just the IPMC votes. My understanding of best practice is to combine vote

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-21 Thread Justin Mclean
Hi, > Oh here's something. Somewhere inside the source release I have a version > string that says "0.34.0rc1" and that now I'm realizing should really say > "0.34.0" as it becomes an official release. Now changing that string will > make for a different SHA. That's a bit awkward. It would be bes

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-21 Thread Justin Mclean
Hi, > since these issues seems non-blocking (given your +1) the fixes won't make > 0.34.0 which > looks like it is good to go. That’s fine. > I couldn't get a clear read on the monokai theme's license either, I'll see > with Erik who introduced these line whether we can just remove the lines.

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-21 Thread Maxime Beauchemin
Oh here's something. Somewhere inside the source release I have a version string that says "0.34.0rc1" and that now I'm realizing should really say "0.34.0" as it becomes an official release. Now changing that string will make for a different SHA. How should I go about this? On Wed, Aug 21, 2019

[RESULT][VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-21 Thread Maxime Beauchemin
Dear community, I'm happy to announce that the vote passes with 9 * +1 votes (7 binding, 2 non-binding) *+1 votes* * Justin Mclean (binding) * Jim Jagielski (binding) * Julian Feinauer (binding) * Alan Gates (binding) * Abhishek Sharma (binding) * Jakob Homan (binding) * Furkan Kamaci (binding) *

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-21 Thread Maxime Beauchemin
Thanks Justin, I just addressed 1,2 and 3 here https://github.com/apache/incubator-superset/pull/8087, but since these issues seems non-blocking (given your +1) the fixes won't make 0.34.0 which looks like it is good to go. I couldn't get a clear read on the monokai theme's license either, I'll se

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-20 Thread Justin Mclean
Hi, +1 (binding) I checked: - incubating in name - signatures and hashes fine - DISCLAIMER exists, although you may want to use the DISCLAIMER_WIP [8] - LICENSE is probably missing a few things (se below) - NOTICE is fine - No unexpected binary files - I didn’t check compiling from source LiCENS

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-19 Thread Abhishek Sharma
+! On Mon, Aug 19, 2019 at 10:20 AM Jeff Feng wrote: > This is very exciting. Thanks Max! > > +1 Binding > > > On Mon, Aug 19, 2019 at 6:36 AM Julian Feinauer < > j.feina...@pragmaticminds.de> wrote: > > > Hi, > > > > as it seems like the PPMC vote is already closed I'll repost my vote > > here.

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-19 Thread Furkan KAMACI
Hi, +1 from me. I checked: - Incubating in name - Disclaimer exists - LICENSE and NOTICE are fine - No unexpected binary files - Code compiles Kind Regards, Furkan KAMACI On Mon, Aug 19, 2019 at 10:32 PM Jakob Homan wrote: > Carrying my binding +1 forward from the Poding vote. > -Jakob > >

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-19 Thread Jakob Homan
Carrying my binding +1 forward from the Poding vote. -Jakob On Mon, Aug 19, 2019 at 11:01 AM Abhishek Sharma wrote: > > +1, Binding. > > On Mon, Aug 19, 2019 at 1:28 PM Bolke de Bruin wrote: > > > +1, non-binding > > > > Awesome! (And Do i need to say finally? ;-)) > > > > B. > > > > Verstuurd v

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-19 Thread Abhishek Sharma
+1, Binding. On Mon, Aug 19, 2019 at 1:28 PM Bolke de Bruin wrote: > +1, non-binding > > Awesome! (And Do i need to say finally? ;-)) > > B. > > Verstuurd vanaf mijn iPad > > > Op 19 aug. 2019 om 18:05 heeft Alan Gates het > volgende geschreven: > > > > Forwarding my +1 from the dev list. I ch

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-19 Thread Bolke de Bruin
+1, non-binding Awesome! (And Do i need to say finally? ;-)) B. Verstuurd vanaf mijn iPad > Op 19 aug. 2019 om 18:05 heeft Alan Gates het volgende > geschreven: > > Forwarding my +1 from the dev list. I checked the LICENSE, NOTICE, and > DISCLAIMER files, as well as looking over the content

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-19 Thread Alan Gates
Forwarding my +1 from the dev list. I checked the LICENSE, NOTICE, and DISCLAIMER files, as well as looking over the contents of the release for licenses and to make sure there weren't any binary files (beyond image files). Alan. On Sun, Aug 18, 2019 at 9:41 PM Maxime Beauchemin < maximebeauche.

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-19 Thread Jeff Feng
This is very exciting. Thanks Max! +1 Binding On Mon, Aug 19, 2019 at 6:36 AM Julian Feinauer < j.feina...@pragmaticminds.de> wrote: > Hi, > > as it seems like the PPMC vote is already closed I'll repost my vote > here... > > +1 (binding) > > I checked: > - Checked out release > - Verified hash

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-19 Thread Julian Feinauer
Hi, as it seems like the PPMC vote is already closed I'll repost my vote here... +1 (binding) I checked: - Checked out release - Verified hashes - Verified incubating in names - No binaries in release - Checked NOTICE and LICENSE.txt, README - Started superset from sources using ` docker-compose

Re: [VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-19 Thread Jim Jagielski
+1 (binding) > On Aug 19, 2019, at 12:41 AM, Maxime Beauchemin > wrote: > > Hi IPMC, > > The Apache Superset community has voted on and approved a proposal to > release > Apache Superset (incubating) 0.34.0 (rc1). *This would be the first Apache > release of Superset.* > > We now kindly reque

[VOTE] Release Apache Superset (incubating) 0.34.0 [RC1]

2019-08-18 Thread Maxime Beauchemin
Hi IPMC, The Apache Superset community has voted on and approved a proposal to release Apache Superset (incubating) 0.34.0 (rc1). *This would be the first Apache release of Superset.* We now kindly request the Incubator PMC members review and vote on this incubator release. Apache Superset (incu