[ofa-general] possible bugs in IB code usage of min() and max()

2009-03-18 Thread Or Gerlitz
Roland, I came across these sparse warnings, are they false-negative or bugs that should be fixed? drivers/infiniband/hw/mlx4/qp.c:421:22: warning: symbol '_min1' shadows an earlier one drivers/infiniband/hw/mlx4/qp.c:421:22: warning: symbol '_min1' shadows an earlier one

Re: [ofa-general] 4K MTU with OpenSM?

2009-03-18 Thread Sasha Khapyorsky
On 18:17 Tue 17 Mar , Dave Olson wrote: On Tue, 17 Mar 2009, Hal Rosenstock wrote: | On Tue, Mar 17, 2009 at 3:02 PM, Ted H. Kim ted@sun.com wrote: | Is there way to config 4K IB MTU with OpenSM? | What's the option of file setting for that? | | See the partition configuration

[ofa-general] ***SPAM*** [PATCH] add c99 definitions within the ib_mad_f structure

2009-03-18 Thread Eli Dorfman (Voltaire)
add c99 definitions to ib_mad_f Signed-off-by: Eli Dorfman e...@voltaire.com --- libibmad/src/fields.c | 525 - 1 files changed, 262 insertions(+), 263 deletions(-) diff --git a/libibmad/src/fields.c b/libibmad/src/fields.c index 19c8fc1..c142f39

***SPAM*** Re: [ofa-general] 4K MTU with OpenSM?

2009-03-18 Thread Hal Rosenstock
On Wed, Mar 18, 2009 at 5:44 AM, Sasha Khapyorsky sas...@voltaire.com wrote: On 18:17 Tue 17 Mar     , Dave Olson wrote: On Tue, 17 Mar 2009, Hal Rosenstock wrote: | On Tue, Mar 17, 2009 at 3:02 PM, Ted H. Kim ted@sun.com wrote: | Is there way to config 4K IB MTU with OpenSM? | What's

***SPAM*** Re: ***SPAM*** Re: [ofa-general] 4K MTU with OpenSM?

2009-03-18 Thread Hal Rosenstock
On Wed, Mar 18, 2009 at 5:53 AM, Hal Rosenstock hal.rosenst...@gmail.com wrote: On Wed, Mar 18, 2009 at 5:44 AM, Sasha Khapyorsky sas...@voltaire.com wrote: On 18:17 Tue 17 Mar     , Dave Olson wrote: On Tue, 17 Mar 2009, Hal Rosenstock wrote: | On Tue, Mar 17, 2009 at 3:02 PM, Ted H. Kim

[ofa-general] ofa_1_4_kernel 20090318-0200 daily build status

2009-03-18 Thread Vladimir Sokolovsky (Mellanox)
-Wdeclaration-after-statement -Wno-pointer-sign -DMODULE -DKBUILD_STR(s)=#s -DKBUILD_BASENAME=KBUILD_STR(af_rds) -DKBUILD_MODNAME=KBUILD_STR(rds) -c -o /home/vlad/tmp/ofa_1_4_kernel-20090318-0200_linux-2.6.18-128.el5_x86_64_check/net/rds/.tmp_af_rds.o /home/vlad/tmp/ofa_1_4_kernel-20090318-0200_linux

[ofa-general] ***SPAM*** [PATCH] opensm/osm_helper.c: Add more info for traps 144 and 256-259 in osm_dump_notice

2009-03-18 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock hal.rosenst...@gmail.com --- diff --git a/opensm/opensm/osm_helper.c b/opensm/opensm/osm_helper.c index b40ba0c..593bbf7 100644 --- a/opensm/opensm/osm_helper.c +++ b/opensm/opensm/osm_helper.c @@ -2,6 +2,7 @@ * Copyright (c) 2004-2008 Voltaire, Inc. All rights

[ofa-general] Re: [PATCH] ib_types.h: Adding BKEY violation trap (259)

2009-03-18 Thread Sasha Khapyorsky
On 16:14 Tue 17 Mar , Itai Baz wrote: Hi Sasha, The following patch adds B_Key violation trap definition. Signed-off-by: Itai Baz it...@mellanox.co.il Applied. Thanks. Sasha ___ general mailing list general@lists.openfabrics.org

[ofa-general] Re: [PATCH] libibmad/serv.c: Fixed respond function to return proper result code

2009-03-18 Thread Sasha Khapyorsky
On 16:17 Tue 17 Mar , Itai Baz wrote: Hi Sasha, mad_respond_via() function was always returning OK. Fixing it to return the proper status. Signed-off-by: Itai Baz it...@mellanox.co.il Applied. Thanks. Sasha ___ general mailing list

Re: ***SPAM*** Re: [ofa-general] Need help with Infiniband problem

2009-03-18 Thread jeffrey Lang
I did a soft reset on the switch to see what errors would appear during the reboot. Below is what was in the log after the reboot: W|2009/03/18 07:36:41.998S: Thread ssiSpawnDelayedResetCardTask (0x831d8530) Osa: Info, rebooting the local card. W|2009/03/18 07:36:42.928S: Thread

[ofa-general] Any documents

2009-03-18 Thread jeffrey Lang
Being new and not totally understanding of the in's and out's of infiniband, are there any documents, tutorials, etc that would help me get a better working understanding of how infiniband and it's software is all put together? jeff begin:vcard fn:Jeffrey Lang n:Lang;Jeffrey org:University of

[ofa-general] RE: [PATCH] add c99 definitions within the ib_mad_f structure

2009-03-18 Thread Sean Hefty
this knowingly breaks the windows build... ___ general mailing list general@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Re: [ofa-general] [PATCH v3] RDMA/cxgb3: Handle EEH events for active connections.

2009-03-18 Thread Steve Wise
Hey Roland, Have you had a chance to review this and the other patch I sent out for inclusion in 2.6.30? Thanks! Steve. ___ general mailing list general@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To

[ofa-general] Re: [PATCH] add c99 definitions within the ib_mad_f structure

2009-03-18 Thread Eli Dorfman (Voltaire)
Sean Hefty wrote: this knowingly breaks the windows build... So what do you suggest? Ira replied that he has no problems with it. ___ general mailing list general@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To

[ofa-general] RE: [PATCH] add c99 definitions within the ib_mad_f structure

2009-03-18 Thread Davis, Arlin R
Sean Hefty wrote: this knowingly breaks the windows build... So what do you suggest? Ira replied that he has no problems with it. What happened? I thought we were all in agreement when we advocated removal of c99 definitions. I think this is a small price to pay for mantainability and

[ofa-general] Re: [PATCH] add c99 definitions within the ib_mad_f structure

2009-03-18 Thread Ira Weiny
On Wed, 18 Mar 2009 18:34:54 +0200 Eli Dorfman (Voltaire) dorfman@gmail.com wrote: Sean Hefty wrote: this knowingly breaks the windows build... So what do you suggest? Ira replied that he has no problems with it. I am sorry if I was unclear but I was speaking in _favor_ of having

[ofa-general] RE: [PATCH] add c99 definitions within the ib_mad_f structure

2009-03-18 Thread Sean Hefty
So what do you suggest? Changing the WinOF build environment is something that could be brought up in Sonoma, if there will be enough representatives there. Alternatively, WinOF schedules regular con-calls. Ira replied that he has no problems with it. I remember Ira stating that he couldn't

[ofa-general] Re: [PATCH] libibmad: added support for handling of BM (Baseboard management) MADs

2009-03-18 Thread Sasha Khapyorsky
Hi Itai, On 16:22 Tue 17 Mar , Itai Baz wrote: diff --git a/libibmad/include/infiniband/mad.h b/libibmad/include/infiniband/mad.h index b8290a7..efc887a 100644 --- a/libibmad/include/infiniband/mad.h +++ b/libibmad/include/infiniband/mad.h snip... @@ -876,6 +922,9 @@ MAD_EXPORT

***SPAM*** Re: ***SPAM*** Re: [ofa-general] Need help with Infiniband problem

2009-03-18 Thread Hal Rosenstock
On Wed, Mar 18, 2009 at 10:45 AM, jeffrey Lang jrl...@uwyo.edu wrote: I did a soft reset on the switch to see what errors would appear during the reboot.  Below is what was in the log after the reboot: W|2009/03/18 07:36:41.998S: Thread ssiSpawnDelayedResetCardTask (0x831d8530) Osa:

***SPAM*** Re: [ofa-general] Need help with Infiniband problem

2009-03-18 Thread Hal Rosenstock
On Wed, Mar 18, 2009 at 10:37 AM, jeffrey Lang jrl...@uwyo.edu wrote: Here's the output for ibchecknet: [r...@h2o01 ~]# ibchecknet perfquery: iberror: failed: smp query nodeinfo: Node type not CA What diags version is being used ? Error check on lid 1 (SilverStorm 9024

Re: [ofa-general] Need help with Infiniband problem

2009-03-18 Thread jeffrey Lang
I'm using the version currently that is released with Centos 4.X which shows as infiniband-diags-1.3.6-1.el4. found this in the syslog Mar 18 13:47:43 h2o01 saquery[21966]: Unable to Open IBT Device[/dev/SysIbt] Now i just need to figure out why the device entry doesn't exist. With the

***SPAM*** Re: [ofa-general] Need help with Infiniband problem

2009-03-18 Thread Hal Rosenstock
On Wed, Mar 18, 2009 at 5:15 PM, jeffrey Lang jrl...@uwyo.edu wrote: I'm using the version currently that is released with Centos 4.X which shows as infiniband-diags-1.3.6-1.el4.   found this in the syslog Mar 18 13:47:43 h2o01 saquery[21966]: Unable to Open IBT Device[/dev/SysIbt] I'm

***SPAM*** Re: [ofa-general] possible bugs in IB code usage of min() and max()

2009-03-18 Thread Or Gerlitz
Roland Dreier rdre...@cisco.com wrote: Did you look at the code in question?  What's your opinion? Oh, I see - its min(A,B) where B=min(C,D) so when evaluating B sparse complains on the shadowing which isn't really a problem - that is false alarm. Or.

Re: [ofa-general][PATCH 2/2 V2] mlx4_core: Link sensing support

2009-03-18 Thread Roland Dreier
+if ((port_type[i] == MLX4_PORT_TYPE_ETH) || +(port_type[i+1] == MLX4_PORT_TYPE_IB)) seems there is a typo here -- should be instead of ||. I fixed this by hand but I'm wondering how much testing this version of the patch got... +

Re: [ofa-general][PATCH] mlx4_ib: Unregister IB device prior to performing CLOSE PORT command

2009-03-18 Thread Roland Dreier
thanks, applied. ___ general mailing list general@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Re: [ofa-general] [PATCH v3] RDMA/cxgb3: Handle EEH events for active connections.

2009-03-18 Thread Roland Dreier
wanted to apply this patch but it seems to be relative to some intermediate state of your tree -- for example: @@ -701,7 +701,7 @@ static int __cxio_tpt_op(struct cxio_rdev *rdev_p, u32 reset_tpt_entry, u32 stag_idx; u32 wptr; -if (rdev_p-flags) +if

Re: [ofa-general] [PATCH v3] RDMA/cxgb3: Handle EEH events for active connections.

2009-03-18 Thread Steve Wise
Roland Dreier wrote: wanted to apply this patch but it seems to be relative to some intermediate state of your tree -- for example: @@ -701,7 +701,7 @@ static int __cxio_tpt_op(struct cxio_rdev *rdev_p, u32 reset_tpt_entry, u32 stag_idx; u32 wptr; - if (rdev_p-flags) + if

Re: [ofa-general] [PATCH v3] RDMA/cxgb3: Handle EEH events for active connections.

2009-03-18 Thread Steve Wise
where upstream doesn't have the rdev_p-flags test. please resend the full patch. It is on top of this series which is upstream somewhere: http://lkml.org/lkml/2009/1/26/196 these dependent patches are in net-next. ___ general mailing list

Re: [ofa-general] [PATCH v3] RDMA/cxgb3: Handle EEH events for active connections.

2009-03-18 Thread Roland Dreier
these dependent patches are in net-next. OK I'll hang onto this and merge this into my second batch of things after net-next goes into Linus's tree. ___ general mailing list general@lists.openfabrics.org